You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by ew...@apache.org on 2016/04/21 02:50:56 UTC
kafka git commit: MINOR: Fix comment in DistributedHerder
Repository: kafka
Updated Branches:
refs/heads/trunk 8a863ecee -> f213625fc
MINOR: Fix comment in DistributedHerder
ewencp
Author: Liquan Pei <li...@gmail.com>
Reviewers: Ewen Cheslack-Postava <ew...@confluent.io>
Closes #1243 from Ishiihara/docs
Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/f213625f
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/f213625f
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/f213625f
Branch: refs/heads/trunk
Commit: f213625fc55dd0eb9087ba6482ce67fcb737172d
Parents: 8a863ec
Author: Liquan Pei <li...@gmail.com>
Authored: Wed Apr 20 17:50:00 2016 -0700
Committer: Ewen Cheslack-Postava <me...@ewencp.org>
Committed: Wed Apr 20 17:50:00 2016 -0700
----------------------------------------------------------------------
.../kafka/connect/runtime/distributed/DistributedHerder.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kafka/blob/f213625f/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java
----------------------------------------------------------------------
diff --git a/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java b/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java
index 1512603..3aa6c33 100644
--- a/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java
+++ b/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java
@@ -866,8 +866,8 @@ public class DistributedHerder extends AbstractHerder implements Runnable {
configBackingStore.putTaskConfigs(connName, taskConfigListAsMap(connName, taskProps));
cb.onCompletion(null, null);
} else {
- // We cannot forward the request on the same thread because this reconfiguration can happen in as a
- // result of . If we blocked
+ // We cannot forward the request on the same thread because this reconfiguration can happen as a result of connector
+ // addition or removal. If we blocked waiting for the response from leader, we may be kicked out of the worker group.
forwardRequestExecutor.submit(new Runnable() {
@Override
public void run() {