[PATCH] Using --batch-mode in check-release.sh ?

[Robert Munteanu <rm...@adobe.com>]

Hi,

(This is a one-liner with potential wide impact, so sending to dev
list).

Reading the output of check-release.sh is hard since recent versions of
Maven will use escape sequences to generate colored output. I proposed
that we use --batch-mode to prevent that in the check-release.sh
script.

Does anyone see an issue with that?

Thanks,
Robert

Index: check-release.sh
===================================================================
--- check-release.sh	(revision 45375)
+++ check-release.sh	(working copy)
@@ -226,7 +226,7 @@
 info ""
 info "   Running the Maven build: mvn clean verify $MVN_ARGS"
 info ""
-if (cd $ZIPDIR; exec mvn clean verify $MVN_ARGS) 2>> "$LOGFILE" 1>&2;
then
+if (cd $ZIPDIR; exec mvn --batch-mode clean verify $MVN_ARGS) 2>>
"$LOGFILE" 1>&2; then
   info "   OK: mvn clean verify $MVN_ARGS"
 else
   error "  NOT OK: mvn clean verify $MVN_ARGS"

Re: [PATCH] Using --batch-mode in check-release.sh ?

[Robert Munteanu <ro...@apache.org>]

On Tue, 2021-01-12 at 09:49 +0000, Marcel Reutegger wrote:
> Hi,
> 
> On 12.01.21, 10:46, "Robert Munteanu" <rm...@adobe.com> wrote:
> > Reading the output of check-release.sh is hard since recent
> > versions of
> > Maven will use escape sequences to generate colored output. I
> > proposed
> > that we use --batch-mode to prevent that in the check-release.sh
> > script.
> 
> +1

Thanks. Updated in r45377.

Robert

Re: [PATCH] Using --batch-mode in check-release.sh ?

[Marcel Reutegger <mr...@adobe.com>]

Hi,

On 12.01.21, 10:46, "Robert Munteanu" <rm...@adobe.com> wrote:
> Reading the output of check-release.sh is hard since recent versions of
> Maven will use escape sequences to generate colored output. I proposed
> that we use --batch-mode to prevent that in the check-release.sh
> script.

+1

Regards
 Marcel