You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2026/05/04 13:37:37 UTC
[PR] Add lychee prek hook (offline mode) and fix internal markdown links [airflow]
potiuk opened a new pull request, #66356:
URL: https://github.com/apache/airflow/pull/66356
## Summary
Add the lychee link checker as a prek hook in **offline mode** so we catch
broken intra-repo Markdown links before they land, and fix the 13
existing broken internal links the hook surfaced on `main`.
### The hook
Configured in `.pre-commit-config.yaml`:
```yaml
- repo: https://github.com/lycheeverse/lychee
rev: e85aaf5524b2f808e63bae55e594c843220f10f2 # frozen: lychee-v0.24.2
hooks:
- id: lychee
types: [markdown]
args:
- LYCHEE_VERSION=0.24.2
- --offline
- --no-progress
- --root-dir
- .
exclude: |
(?x)
^clients/python/|
^.*/openapi-gen/|
^.*/node_modules/|
^\.build/|
^generated/
```
Notes:
- `--offline` means lychee skips every HTTP/HTTPS link and only validates
on-disk references (relative paths, anchors, `file://` links).
- `--root-dir .` makes root-relative GitHub-style links like
`[X](/contributing-docs/X.rst)` resolve from the repo root.
- `LYCHEE_VERSION=0.24.2` is passed as the first arg because lychee's
pre-commit script otherwise requires the `rev` field to be a version
tag, but airflow's convention is to pin SHAs. The arg keeps both
happy. When bumping lychee, update both the `rev` SHA and the version
string together.
- Auto-generated content is excluded (the Python OpenAPI client docs
under `clients/python/`, JS `node_modules/`, `openapi-gen` output,
`.build/`, the `generated/` dir).
### The 13 broken links fixed
- **Missing locale guides** (6 hits across 2 tables): added one-line stub
files for `ar`, `it`, `tr` under
`.github/skills/airflow-translations/locales/`. They are listed in the
`airflow-translations` SKILL.md table because those locales are active
in the UI i18n directory; until a full style-guide is authored each
stub redirects the reader at the parent SKILL.md global rules.
- **`airflow-core/src/airflow/_shared/{AGENTS,README}.md`**: the
`[shared folder](../../shared)` link resolved inside `airflow-core/`
rather than at the repo root. Fixed to `../../../../shared`.
- **`airflow-core/src/airflow/api_fastapi/execution_api/AGENTS.md`**:
one missing `../` segment; the `contributing-docs/...` link was
resolving to `airflow-core/contributing-docs/` instead of the repo
root. Fixed.
- **`airflow-core/src/airflow/ui/tests/e2e/README.md`**: the
`dag-trigger.spec.ts` example referenced no longer exists; pointed
at the existing `dag-runs.spec.ts` instead.
- **`dev/breeze/doc/ci/02_images.md`**: docs moved from
`docs/docker-stack/` to `docker-stack-docs/`; link updated.
- **`dev/README_RELEASE_HELM_CHART.md`**: helm-chart docs moved from
`docs/helm-chart/` to `chart/docs/`; link updated.
- **`dev/system_tests/README.md`**: dropped the dangling reference to
a `dev/requirements.txt` that no longer exists; replaced with a
`uv run --with PyGithub --with rich-click --with rich` invocation
that picks up the script's actual dependencies.
## Test plan
- [ ] `prek run lychee --all-files` passes (verified locally — 13
errors on `main` → 0 errors after this PR).
- [ ] `prek run insert-license lint-markdown --all-files` still passes
across the touched files.
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Claude Code (Opus 4.7)
Generated-by: Claude Code (Opus 4.7) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add lychee prek hook (offline mode) and fix internal markdown links [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #66356:
URL: https://github.com/apache/airflow/pull/66356#issuecomment-4380861224
### Backport failed to create: v3-2-test. View the failure log <a href='https://github.com/apache/airflow/actions/runs/25386761801'> Run details </a>
Note: As of [Merging PRs targeted for Airflow 3.X](https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#merging-prs-targeted-for-airflow-3x)
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.
In matter of doubt please ask in [#release-management](https://apache-airflow.slack.com/archives/C03G9H97MM2) Slack channel.
<table>
<tr>
<th>Status</th>
<th>Branch</th>
<th>Result</th>
</tr>
<tr>
<td>❌</td>
<td>v3-2-test</td>
<td><a href="https://github.com/apache/airflow/commit/5936cf8b71a6c131baf7886abc992e93ffa67556"><img src='https://img.shields.io/badge/Commit-5936cf8-red' alt='Commit Link'></a></td>
</tr>
</table>
You can attempt to backport this manually by running:
```bash
cherry_picker 5936cf8 v3-2-test
```
This should apply the commit to the v3-2-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.
After you have resolved the conflicts, you can continue the backport process by running:
```bash
cherry_picker --continue
```
If you don't have cherry-picker installed, see the [installation guide](https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#how-to-backport-pr-with-cherry-picker-cli).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add lychee prek hook (offline mode) and fix internal markdown links [airflow]
Posted by "parkhojeong (via GitHub)" <gi...@apache.org>.
parkhojeong commented on PR #66356:
URL: https://github.com/apache/airflow/pull/66356#issuecomment-4378946173
> Good catch — added `--include-fragments` to the args. It surfaced three genuinely broken anchors which I fixed in this push:
>
> 1. `.github/skills/pr-triage/classify-and-act.md` and `SKILL.md` were both linking at `actions.md#mark-ready` and `actions.md#mark-ready-with-ping`, but GitHub's auto-anchors for those `##` headings actually include the full descriptive text (`mark-ready--add-ready-for-maintainer-review-label`). Added explicit `<a id="mark-ready"></a>` / `<a id="mark-ready-with-ping"></a>` markers in `actions.md` so the existing short-form links resolve.
> 2. `dev/README_RELEASE_AIRFLOW.md` was linking at the i18n README's `#removing-or-replacing-ownership`, but that section is actually called "Relinquishing translation/code ownership" — fixed the link to `#relinquishing-translationcode-ownership`.
>
> I also switched the hook to `lychee-docker` to fix the unrelated GLIBC incompatibility that was failing CI (the lychee 0.24 prebuilt binary needs glibc 2.39+, ubuntu-22.04 runners have 2.35). The docker image bundles its own libc so it works portably.
>
> Drafted-by: Claude Code (Opus 4.7); reviewed by @potiuk before posting
Thanks for the quick follow-up. I reviewed the latest commit (https://github.com/apache/airflow/pull/66356/commits/fe61ea2cc0174bae42dacd5738d57f08b9ac201d), and it looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add lychee prek hook (offline mode) and fix internal markdown links [airflow]
Posted by "parkhojeong (via GitHub)" <gi...@apache.org>.
parkhojeong commented on code in PR #66356:
URL: https://github.com/apache/airflow/pull/66356#discussion_r3182300339
##########
.pre-commit-config.yaml:
##########
@@ -400,6 +400,34 @@ repos:
files: ^\.github/workflows/.*$|^\.github/actions/.*$
require_serial: true
entry: zizmor
+ - repo: https://github.com/lycheeverse/lychee
+ rev: e85aaf5524b2f808e63bae55e594c843220f10f2 # frozen: lychee-v0.24.2
+ hooks:
+ - id: lychee
+ name: Check internal Markdown links with lychee (offline mode)
+ description: >-
+ Validate intra-repo links in Markdown files (relative paths, anchors)
+ without making any HTTP requests. Auto-generated client docs are
+ excluded because they are regenerated from OpenAPI specs.
+ types: [markdown]
+ args:
+ # Pin the lychee binary version explicitly. Airflow follows the
+ # SHA-pinning convention for `rev`, but the lychee pre-commit
+ # script needs a version tag — passing it via this arg keeps both
+ # happy. Update both the `rev` SHA above and this version string
+ # together when bumping.
+ - LYCHEE_VERSION=0.24.2
+ - --offline
+ - --no-progress
+ - --root-dir
+ - .
Review Comment:
```suggestion
- --root-dir
- .
- --include-fragments
```
this configuration works
<img width="1360" height="345" alt="Image" src="https://github.com/user-attachments/assets/f4b39530-a319-4ae6-8306-62d617b7b25e" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add lychee prek hook (offline mode) and fix internal markdown links [airflow]
Posted by "parkhojeong (via GitHub)" <gi...@apache.org>.
parkhojeong commented on code in PR #66356:
URL: https://github.com/apache/airflow/pull/66356#discussion_r3182300339
##########
.pre-commit-config.yaml:
##########
@@ -400,6 +400,34 @@ repos:
files: ^\.github/workflows/.*$|^\.github/actions/.*$
require_serial: true
entry: zizmor
+ - repo: https://github.com/lycheeverse/lychee
+ rev: e85aaf5524b2f808e63bae55e594c843220f10f2 # frozen: lychee-v0.24.2
+ hooks:
+ - id: lychee
+ name: Check internal Markdown links with lychee (offline mode)
+ description: >-
+ Validate intra-repo links in Markdown files (relative paths, anchors)
+ without making any HTTP requests. Auto-generated client docs are
+ excluded because they are regenerated from OpenAPI specs.
+ types: [markdown]
+ args:
+ # Pin the lychee binary version explicitly. Airflow follows the
+ # SHA-pinning convention for `rev`, but the lychee pre-commit
+ # script needs a version tag — passing it via this arg keeps both
+ # happy. Update both the `rev` SHA above and this version string
+ # together when bumping.
+ - LYCHEE_VERSION=0.24.2
+ - --offline
+ - --no-progress
+ - --root-dir
+ - .
Review Comment:
```suggestion
- --root-dir
- .
- --include-fragments
```
Adding `--include-fragments` makes lychee report broken Markdown anchor fragments. For example, `airflow-core/src/airflow/ui/public/i18n/README.md#removing-or-replacing-ownership` points to an anchor that does not exist in that README.
<img width="1360" height="345" alt="Image" src="https://github.com/user-attachments/assets/f4b39530-a319-4ae6-8306-62d617b7b25e" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add lychee prek hook (offline mode) and fix internal markdown links [airflow]
Posted by "parkhojeong (via GitHub)" <gi...@apache.org>.
parkhojeong commented on code in PR #66356:
URL: https://github.com/apache/airflow/pull/66356#discussion_r3182300339
##########
.pre-commit-config.yaml:
##########
@@ -400,6 +400,34 @@ repos:
files: ^\.github/workflows/.*$|^\.github/actions/.*$
require_serial: true
entry: zizmor
+ - repo: https://github.com/lycheeverse/lychee
+ rev: e85aaf5524b2f808e63bae55e594c843220f10f2 # frozen: lychee-v0.24.2
+ hooks:
+ - id: lychee
+ name: Check internal Markdown links with lychee (offline mode)
+ description: >-
+ Validate intra-repo links in Markdown files (relative paths, anchors)
+ without making any HTTP requests. Auto-generated client docs are
+ excluded because they are regenerated from OpenAPI specs.
+ types: [markdown]
+ args:
+ # Pin the lychee binary version explicitly. Airflow follows the
+ # SHA-pinning convention for `rev`, but the lychee pre-commit
+ # script needs a version tag — passing it via this arg keeps both
+ # happy. Update both the `rev` SHA above and this version string
+ # together when bumping.
+ - LYCHEE_VERSION=0.24.2
+ - --offline
+ - --no-progress
+ - --root-dir
+ - .
Review Comment:
```suggestion
- --root-dir
- .
- --include-fragments
```
this configuration works
<img width="1360" height="345" alt="Image" src="https://github.com/user-attachments/assets/f4b39530-a319-4ae6-8306-62d617b7b25e" />
actually `airflow-core/src/airflow/ui/public/i18n/README.md#removing-or-replacing-ownership` is not in README.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add lychee prek hook (offline mode) and fix internal markdown links [airflow]
Posted by "parkhojeong (via GitHub)" <gi...@apache.org>.
parkhojeong commented on code in PR #66356:
URL: https://github.com/apache/airflow/pull/66356#discussion_r3182300339
##########
.pre-commit-config.yaml:
##########
@@ -400,6 +400,34 @@ repos:
files: ^\.github/workflows/.*$|^\.github/actions/.*$
require_serial: true
entry: zizmor
+ - repo: https://github.com/lycheeverse/lychee
+ rev: e85aaf5524b2f808e63bae55e594c843220f10f2 # frozen: lychee-v0.24.2
+ hooks:
+ - id: lychee
+ name: Check internal Markdown links with lychee (offline mode)
+ description: >-
+ Validate intra-repo links in Markdown files (relative paths, anchors)
+ without making any HTTP requests. Auto-generated client docs are
+ excluded because they are regenerated from OpenAPI specs.
+ types: [markdown]
+ args:
+ # Pin the lychee binary version explicitly. Airflow follows the
+ # SHA-pinning convention for `rev`, but the lychee pre-commit
+ # script needs a version tag — passing it via this arg keeps both
+ # happy. Update both the `rev` SHA above and this version string
+ # together when bumping.
+ - LYCHEE_VERSION=0.24.2
+ - --offline
+ - --no-progress
+ - --root-dir
+ - .
Review Comment:
```suggestion
- --root-dir
- .
- --include-fragments
```
Adding `--include-fragments` makes lychee report broken Markdown anchor fragments.
<img width="1360" height="345" alt="Image" src="https://github.com/user-attachments/assets/f4b39530-a319-4ae6-8306-62d617b7b25e" />
actually the third item `airflow-core/src/airflow/ui/public/i18n/README.md#removing-or-replacing-ownership` is not in README.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add lychee prek hook (offline mode) and fix internal markdown links [airflow]
Posted by "parkhojeong (via GitHub)" <gi...@apache.org>.
parkhojeong commented on code in PR #66356:
URL: https://github.com/apache/airflow/pull/66356#discussion_r3182300339
##########
.pre-commit-config.yaml:
##########
@@ -400,6 +400,34 @@ repos:
files: ^\.github/workflows/.*$|^\.github/actions/.*$
require_serial: true
entry: zizmor
+ - repo: https://github.com/lycheeverse/lychee
+ rev: e85aaf5524b2f808e63bae55e594c843220f10f2 # frozen: lychee-v0.24.2
+ hooks:
+ - id: lychee
+ name: Check internal Markdown links with lychee (offline mode)
+ description: >-
+ Validate intra-repo links in Markdown files (relative paths, anchors)
+ without making any HTTP requests. Auto-generated client docs are
+ excluded because they are regenerated from OpenAPI specs.
+ types: [markdown]
+ args:
+ # Pin the lychee binary version explicitly. Airflow follows the
+ # SHA-pinning convention for `rev`, but the lychee pre-commit
+ # script needs a version tag — passing it via this arg keeps both
+ # happy. Update both the `rev` SHA above and this version string
+ # together when bumping.
+ - LYCHEE_VERSION=0.24.2
+ - --offline
+ - --no-progress
+ - --root-dir
+ - .
Review Comment:
```suggestion
- --root-dir
- .
- --include-fragments
```
this configuration works
<img width="1360" height="345" alt="Image" src="https://github.com/user-attachments/assets/f4b39530-a319-4ae6-8306-62d617b7b25e" />
actually third item `airflow-core/src/airflow/ui/public/i18n/README.md#removing-or-replacing-ownership` is not in README.md
##########
.pre-commit-config.yaml:
##########
@@ -400,6 +400,34 @@ repos:
files: ^\.github/workflows/.*$|^\.github/actions/.*$
require_serial: true
entry: zizmor
+ - repo: https://github.com/lycheeverse/lychee
+ rev: e85aaf5524b2f808e63bae55e594c843220f10f2 # frozen: lychee-v0.24.2
+ hooks:
+ - id: lychee
+ name: Check internal Markdown links with lychee (offline mode)
+ description: >-
+ Validate intra-repo links in Markdown files (relative paths, anchors)
+ without making any HTTP requests. Auto-generated client docs are
+ excluded because they are regenerated from OpenAPI specs.
+ types: [markdown]
+ args:
+ # Pin the lychee binary version explicitly. Airflow follows the
+ # SHA-pinning convention for `rev`, but the lychee pre-commit
+ # script needs a version tag — passing it via this arg keeps both
+ # happy. Update both the `rev` SHA above and this version string
+ # together when bumping.
+ - LYCHEE_VERSION=0.24.2
+ - --offline
+ - --no-progress
+ - --root-dir
+ - .
Review Comment:
```suggestion
- --root-dir
- .
- --include-fragments
```
this configuration works
<img width="1360" height="345" alt="Image" src="https://github.com/user-attachments/assets/f4b39530-a319-4ae6-8306-62d617b7b25e" />
actually the third item `airflow-core/src/airflow/ui/public/i18n/README.md#removing-or-replacing-ownership` is not in README.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add lychee prek hook (offline mode) and fix internal markdown links [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #66356:
URL: https://github.com/apache/airflow/pull/66356#issuecomment-4371672844
Should help us to keep our markdown cross-references in order :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add lychee prek hook (offline mode) and fix internal markdown links [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 merged PR #66356:
URL: https://github.com/apache/airflow/pull/66356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add lychee prek hook (offline mode) and fix internal markdown links [airflow]
Posted by "parkhojeong (via GitHub)" <gi...@apache.org>.
parkhojeong commented on code in PR #66356:
URL: https://github.com/apache/airflow/pull/66356#discussion_r3182300339
##########
.pre-commit-config.yaml:
##########
@@ -400,6 +400,34 @@ repos:
files: ^\.github/workflows/.*$|^\.github/actions/.*$
require_serial: true
entry: zizmor
+ - repo: https://github.com/lycheeverse/lychee
+ rev: e85aaf5524b2f808e63bae55e594c843220f10f2 # frozen: lychee-v0.24.2
+ hooks:
+ - id: lychee
+ name: Check internal Markdown links with lychee (offline mode)
+ description: >-
+ Validate intra-repo links in Markdown files (relative paths, anchors)
+ without making any HTTP requests. Auto-generated client docs are
+ excluded because they are regenerated from OpenAPI specs.
+ types: [markdown]
+ args:
+ # Pin the lychee binary version explicitly. Airflow follows the
+ # SHA-pinning convention for `rev`, but the lychee pre-commit
+ # script needs a version tag — passing it via this arg keeps both
+ # happy. Update both the `rev` SHA above and this version string
+ # together when bumping.
+ - LYCHEE_VERSION=0.24.2
+ - --offline
+ - --no-progress
+ - --root-dir
+ - .
Review Comment:
```suggestion
- --root-dir
- .
- --include-fragments
```
Adding `--include-fragments` makes lychee report broken Markdown anchor fragments.
<img width="1360" height="345" alt="Image" src="https://github.com/user-attachments/assets/f4b39530-a319-4ae6-8306-62d617b7b25e" />
For example, `airflow-core/src/airflow/ui/public/i18n/README.md#removing-or-replacing-ownership` points to an anchor that does not exist in that README.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add lychee prek hook (offline mode) and fix internal markdown links [airflow]
Posted by "parkhojeong (via GitHub)" <gi...@apache.org>.
parkhojeong commented on code in PR #66356:
URL: https://github.com/apache/airflow/pull/66356#discussion_r3182300339
##########
.pre-commit-config.yaml:
##########
@@ -400,6 +400,34 @@ repos:
files: ^\.github/workflows/.*$|^\.github/actions/.*$
require_serial: true
entry: zizmor
+ - repo: https://github.com/lycheeverse/lychee
+ rev: e85aaf5524b2f808e63bae55e594c843220f10f2 # frozen: lychee-v0.24.2
+ hooks:
+ - id: lychee
+ name: Check internal Markdown links with lychee (offline mode)
+ description: >-
+ Validate intra-repo links in Markdown files (relative paths, anchors)
+ without making any HTTP requests. Auto-generated client docs are
+ excluded because they are regenerated from OpenAPI specs.
+ types: [markdown]
+ args:
+ # Pin the lychee binary version explicitly. Airflow follows the
+ # SHA-pinning convention for `rev`, but the lychee pre-commit
+ # script needs a version tag — passing it via this arg keeps both
+ # happy. Update both the `rev` SHA above and this version string
+ # together when bumping.
+ - LYCHEE_VERSION=0.24.2
+ - --offline
+ - --no-progress
+ - --root-dir
+ - .
Review Comment:
```suggestion
- --root-dir
- .
- --include-fragments
```
Adding `--include-fragments` makes lychee report broken Markdown anchor fragments.
For example, `airflow-core/src/airflow/ui/public/i18n/README.md#removing-or-replacing-ownership` points to an anchor that does not exist in that README.
<img width="1360" height="345" alt="Image" src="https://github.com/user-attachments/assets/f4b39530-a319-4ae6-8306-62d617b7b25e" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add lychee prek hook (offline mode) and fix internal markdown links [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #66356:
URL: https://github.com/apache/airflow/pull/66356#issuecomment-4378287312
Good catch — added `--include-fragments` to the args. It surfaced three genuinely broken anchors which I fixed in this push:
1. `.github/skills/pr-triage/classify-and-act.md` and `SKILL.md` were both linking at `actions.md#mark-ready` and `actions.md#mark-ready-with-ping`, but GitHub's auto-anchors for those `##` headings actually include the full descriptive text (`mark-ready--add-ready-for-maintainer-review-label`). Added explicit `<a id="mark-ready"></a>` / `<a id="mark-ready-with-ping"></a>` markers in `actions.md` so the existing short-form links resolve.
2. `dev/README_RELEASE_AIRFLOW.md` was linking at the i18n README's `#removing-or-replacing-ownership`, but that section is actually called "Relinquishing translation/code ownership" — fixed the link to `#relinquishing-translationcode-ownership`.
I also switched the hook to `lychee-docker` to fix the unrelated GLIBC incompatibility that was failing CI (the lychee 0.24 prebuilt binary needs glibc 2.39+, ubuntu-22.04 runners have 2.35). The docker image bundles its own libc so it works portably.
---
Drafted-by: Claude Code (Opus 4.7); reviewed by @potiuk before posting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add lychee prek hook (offline mode) and fix internal markdown links [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on PR #66356:
URL: https://github.com/apache/airflow/pull/66356#issuecomment-4380847797
@parkhojeong thanks for helping reviewing it!
LGTM and merging :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org