You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "bryancall (via GitHub)" <gi...@apache.org> on 2023/02/13 19:46:35 UTC
[GitHub] [trafficserver] bryancall opened a new pull request, #9405: Clean up the formatting of build options
bryancall opened a new pull request, #9405:
URL: https://github.com/apache/trafficserver/pull/9405
The flags are now aligned.
```
CC: ccache cc
CXX: ccache c++
CPP: cc -E
CFLAGS:
CXXFLAGS:
CPPFLAGS: -D_GNU_SOURCE -DOPENSSL_NO_SSL_INTERN -DOPENSSL_API_COMPAT=10002 -DOPENSSL_IS_OPENSSL3 -I/opt/quiche/include
LDFLAGS: -L/opt/quiche/lib
AM_CFLAGS: -std=gnu99 -g -pipe -Wall -Wextra -Wno-ignored-qualifiers -Wno-unused-parameter -Wno-format-truncation -Wno-cast-function-type -Wno-stringop-overflow -O3 -feliminate-unused-debug-symbols -fno-strict-aliasing -Werror -mcx16
AM_CXXFLAGS: -std=c++17 -g -pipe -Wall -Wextra -Wno-ignored-qualifiers -Wno-unused-parameter -Wno-format-truncation -Wno-cast-function-type -Wno-stringop-overflow -O3 -feliminate-unused-debug-symbols -fno-strict-aliasing -Werror -Wno-invalid-offsetof -Wno-noexcept-type -Wsuggest-override -mcx16
AM_CPPFLAGS: -Dlinux -D_LARGEFILE64_SOURCE=1 -D_COMPILE64BIT_SOURCE=1 -D_REENTRANT -D__STDC_LIMIT_MACROS=1 -D__STDC_FORMAT_MACROS=1
AM_LDFLAGS: -rdynamic -Wl,--as-needed -R/opt/quiche/lib
TS_INCLUDES:
OPENSSL_LDFLAGS:
OPENSSL_INCLUDES:
YAMLCPP_LDFLAGS: -L${abs_top_builddir}/lib/yamlcpp
YAMLCPP_INCLUDES: -I${abs_top_srcdir}/lib/yamlcpp/include
SWOC_LDFLAGS: -L${abs_top_builddir}/lib/swoc
SWOC_INCLUDES: -I${abs_top_srcdir}/lib/swoc/include
NURAFT_LDFLAGS:
NURAFT_INCLUDES:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #9405: Clean up the formatting of build options
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #9405:
URL: https://github.com/apache/trafficserver/pull/9405#issuecomment-1546190452
[approve ci cmake]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 commented on a diff in pull request #9405: Clean up the formatting of build options
Posted by "masaori335 (via GitHub)" <gi...@apache.org>.
masaori335 commented on code in PR #9405:
URL: https://github.com/apache/trafficserver/pull/9405#discussion_r1106546449
##########
configure.ac:
##########
@@ -2443,10 +2443,10 @@ AC_MSG_NOTICE([Build option summary:
CXXFLAGS: $CXXFLAGS
CPPFLAGS: $CPPFLAGS
LDFLAGS: $LDFLAGS
- AM@&t@_CFLAGS: $AM_CFLAGS
Review Comment:
Just curious what's `@&t@`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] masaori335 commented on a diff in pull request #9405: Clean up the formatting of build options
Posted by "masaori335 (via GitHub)" <gi...@apache.org>.
masaori335 commented on code in PR #9405:
URL: https://github.com/apache/trafficserver/pull/9405#discussion_r1133351599
##########
configure.ac:
##########
@@ -2443,10 +2443,10 @@ AC_MSG_NOTICE([Build option summary:
CXXFLAGS: $CXXFLAGS
CPPFLAGS: $CPPFLAGS
LDFLAGS: $LDFLAGS
- AM@&t@_CFLAGS: $AM_CFLAGS
Review Comment:
This is it! The last section of the page is pretty interesting. Thanks!
> The name ‘@&t@’ was suggested by Paul Eggert:
> I should give some credit to the ‘@&t@’ pun. The ‘&’ is my own invention, but the ‘t’ came from the source code of the ALGOL68C compiler, written by Steve Bourne (of Bourne shell fame), and which used ‘mt’ to denote the empty string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ezelkow1 commented on pull request #9405: Clean up the formatting of build options
Posted by "ezelkow1 (via GitHub)" <gi...@apache.org>.
ezelkow1 commented on PR #9405:
URL: https://github.com/apache/trafficserver/pull/9405#issuecomment-1554940647
[approve ci centos]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall merged pull request #9405: Clean up the formatting of build options
Posted by "bryancall (via GitHub)" <gi...@apache.org>.
bryancall merged PR #9405:
URL: https://github.com/apache/trafficserver/pull/9405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on a diff in pull request #9405: Clean up the formatting of build options
Posted by "randall (via GitHub)" <gi...@apache.org>.
randall commented on code in PR #9405:
URL: https://github.com/apache/trafficserver/pull/9405#discussion_r1132635187
##########
configure.ac:
##########
@@ -2443,10 +2443,10 @@ AC_MSG_NOTICE([Build option summary:
CXXFLAGS: $CXXFLAGS
CPPFLAGS: $CPPFLAGS
LDFLAGS: $LDFLAGS
- AM@&t@_CFLAGS: $AM_CFLAGS
Review Comment:
You got me wondering that now, and I found this: https://www.gnu.org/software/autoconf/manual/autoconf-2.67/html_node/Quadrigraphs.html
maybe for this?
```
to escape occurrences of forbidden patterns
For instance you might want to mention AC_FOO in a comment, while still being sure that autom4te still catches unexpanded ‘AC_*’. Then write ‘AC@&t@_FOO’.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org