You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/03/12 05:28:12 UTC

[GitHub] [incubator-gobblin] codecov-io commented on issue #2921: compile a flow before storing it in spec catalog

codecov-io commented on issue #2921: compile a flow before storing it in spec catalog
URL: https://github.com/apache/incubator-gobblin/pull/2921#issuecomment-598013567
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2921?src=pr&el=h1) Report
   > Merging [#2921](https://codecov.io/gh/apache/incubator-gobblin/pull/2921?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/6418dcfbb928aaade047ef51366595957d7bdf81?src=pr&el=desc) will **decrease** coverage by `0.39%`.
   > The diff coverage is `48.38%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-gobblin/pull/2921/graphs/tree.svg?width=650&token=4MgURJ0bGc&height=150&src=pr)](https://codecov.io/gh/apache/incubator-gobblin/pull/2921?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##             master    #2921     +/-   ##
   ===========================================
   - Coverage     45.87%   45.47%   -0.4%     
   + Complexity     9188     9109     -79     
   ===========================================
     Files          1934     1936      +2     
     Lines         72930    73057    +127     
     Branches       8044     8051      +7     
   ===========================================
   - Hits          33455    33223    -232     
   - Misses        36404    36772    +368     
   + Partials       3071     3062      -9
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2921?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../org/apache/gobblin/service/ServiceConfigKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2921/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9TZXJ2aWNlQ29uZmlnS2V5cy5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...blin/service/FlowConfigV2ResourceLocalHandler.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2921/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnVjJSZXNvdXJjZUxvY2FsSGFuZGxlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [.../modules/scheduler/GobblinServiceJobScheduler.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2921/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9zY2hlZHVsZXIvR29iYmxpblNlcnZpY2VKb2JTY2hlZHVsZXIuamF2YQ==) | `50.85% <50%> (-2.86%)` | `15 <0> (-4)` | |
   | [...ache/gobblin/runtime/spec\_catalog/FlowCatalog.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2921/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvc3BlY19jYXRhbG9nL0Zsb3dDYXRhbG9nLmphdmE=) | `47.69% <57.14%> (-0.25%)` | `16 <1> (+1)` | |
   | [...bblin/runtime/job\_monitor/KafkaAvroJobMonitor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2921/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX21vbml0b3IvS2Fma2FBdnJvSm9iTW9uaXRvci5qYXZh) | `0% <0%> (-93.11%)` | `0% <0%> (-7%)` | |
   | [...pache/gobblin/runtime/kafka/HighLevelConsumer.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2921/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUva2Fma2EvSGlnaExldmVsQ29uc3VtZXIuamF2YQ==) | `0% <0%> (-81.04%)` | `0% <0%> (-12%)` | |
   | [...n/runtime/job\_monitor/SLAEventKafkaJobMonitor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2921/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX21vbml0b3IvU0xBRXZlbnRLYWZrYUpvYk1vbml0b3IuamF2YQ==) | `0% <0%> (-80.27%)` | `0% <0%> (-17%)` | |
   | [...blin/service/monitoring/KafkaJobStatusMonitor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2921/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9uaXRvcmluZy9LYWZrYUpvYlN0YXR1c01vbml0b3IuamF2YQ==) | `0% <0%> (-72.23%)` | `0% <0%> (-16%)` | |
   | [...e/gobblin/runtime/job\_monitor/KafkaJobMonitor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2921/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX21vbml0b3IvS2Fma2FKb2JNb25pdG9yLmphdmE=) | `0% <0%> (-65.22%)` | `0% <0%> (-9%)` | |
   | [.../service/monitoring/KafkaAvroJobStatusMonitor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2921/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9uaXRvcmluZy9LYWZrYUF2cm9Kb2JTdGF0dXNNb25pdG9yLmphdmE=) | `0% <0%> (-56.67%)` | `0% <0%> (-13%)` | |
   | ... and [21 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2921/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2921?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2921?src=pr&el=footer). Last update [6418dcf...82525a5](https://codecov.io/gh/apache/incubator-gobblin/pull/2921?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services