Re: Review Request 71203: Added check script to check for license headers.

[James Peach <jp...@apache.org>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71203/#review217265
-----------------------------------------------------------


Ship it!




Should be named `check-license.py` to be consistent with other scripts.

- James Peach


On July 30, 2019, 9:01 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71203/
> -----------------------------------------------------------
> 
> (Updated July 30, 2019, 9:01 p.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-9630
>     https://issues.apache.org/jira/browse/MESOS-9630
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This check adds a script which validates that source files have valid
> license headers. This will allow us to reuse this functionality with
> e.g., the pre-commit tool.
> 
> At the moment the code added here is not invoked from
> `support/mesos-style.py` since it will be removed in a follow-up commit.
> 
> 
> Diffs
> -----
> 
>   support/check_license.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71203/diff/3/
> 
> 
> Testing
> -------
> 
> * tested against files with license headers present or absent
> * tested against all Python and C++ source files in the repo
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>