Re: [PR] [Enhancement] support simple sql function for factorial(from Hive) [doris]

["K-handle-Y (via GitHub)" <gi...@apache.org>]

K-handle-Y commented on PR #57144:
URL: https://github.com/apache/doris/pull/57144#issuecomment-3508885620

   > basically good! please also add some case:
   > 
   > 1. factorial(column) which column is nullable and non-nullable
   > 2. factorial(nullable(literal))
   
   done. not sure if its ok. looking forward to ur review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org