You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Thierry Monney (JIRA)" <de...@myfaces.apache.org> on 2006/11/29 16:47:21 UTC
[jira] Created: (TOBAGO-204) APT does not see sources in "self"
project when processing generated sources
APT does not see sources in "self" project when processing generated sources
----------------------------------------------------------------------------
Key: TOBAGO-204
URL: http://issues.apache.org/jira/browse/TOBAGO-204
Project: MyFaces Tobago
Issue Type: Bug
Components: Maven Apt Plugin
Affects Versions: 1.0.8
Reporter: Thierry Monney
Priority: Minor
We have a multi-module setup in which module A defines an annotation processor and module B uses maven-apt-plugin to generate source code. The generation itself works OK.
When APT runs on the generated sources, since the working directory is ${tempRoot} in forked mode, APT has no access to source files. This looks like normal behavior from APT point of view (the same happens on the command line), but results in parsing errors (although the generated code is correct and builds correctly).
A solution would be to add a ${workingDir} parameter to the mojo and make it point to the project source folder. I will submit a patch shortly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (TOBAGO-204) APT does not see sources in "self"
project when processing generated sources
Posted by "Thierry Monney (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/TOBAGO-204?page=all ]
Thierry Monney updated TOBAGO-204:
----------------------------------
Status: Patch Available (was: Open)
> APT does not see sources in "self" project when processing generated sources
> ----------------------------------------------------------------------------
>
> Key: TOBAGO-204
> URL: http://issues.apache.org/jira/browse/TOBAGO-204
> Project: MyFaces Tobago
> Issue Type: Bug
> Components: Maven Apt Plugin
> Affects Versions: 1.0.8
> Reporter: Thierry Monney
> Priority: Minor
> Attachments: projects.zip
>
>
> We have a multi-module setup in which module A defines an annotation processor and module B uses maven-apt-plugin to generate source code. The generation itself works OK.
> When APT runs on the generated sources, since the working directory is ${tempRoot} in forked mode, APT has no access to source files. This looks like normal behavior from APT point of view (the same happens on the command line), but results in parsing errors (although the generated code is correct and builds correctly).
> A solution would be to add a ${workingDir} parameter to the mojo and make it point to the project source folder. I will submit a patch shortly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (TOBAGO-204) APT does not see sources in "self"
project when processing generated sources
Posted by "Bernd Bohmann (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOBAGO-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462985 ]
Bernd Bohmann commented on TOBAGO-204:
--------------------------------------
I' m only using linux.
And before I commit the patch I should verify that the patch works under a different OS.
> APT does not see sources in "self" project when processing generated sources
> ----------------------------------------------------------------------------
>
> Key: TOBAGO-204
> URL: https://issues.apache.org/jira/browse/TOBAGO-204
> Project: MyFaces Tobago
> Issue Type: Bug
> Components: Maven Apt Plugin
> Affects Versions: 1.0.8
> Reporter: Thierry Monney
> Assigned To: Bernd Bohmann
> Priority: Minor
> Fix For: 1.0.10
>
> Attachments: projects.zip, workingDir.patch
>
>
> We have a multi-module setup in which module A defines an annotation processor and module B uses maven-apt-plugin to generate source code. The generation itself works OK.
> When APT runs on the generated sources, since the working directory is ${tempRoot} in forked mode, APT has no access to source files. This looks like normal behavior from APT point of view (the same happens on the command line), but results in parsing errors (although the generated code is correct and builds correctly).
> A solution would be to add a ${workingDir} parameter to the mojo and make it point to the project source folder. I will submit a patch shortly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (TOBAGO-204) APT does not see sources in "self"
project when processing generated sources
Posted by "Bernd Bohmann (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOBAGO-204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bernd Bohmann resolved TOBAGO-204.
----------------------------------
Resolution: Fixed
> APT does not see sources in "self" project when processing generated sources
> ----------------------------------------------------------------------------
>
> Key: TOBAGO-204
> URL: https://issues.apache.org/jira/browse/TOBAGO-204
> Project: MyFaces Tobago
> Issue Type: Bug
> Components: Maven Apt Plugin
> Affects Versions: 1.0.8
> Reporter: Thierry Monney
> Assigned To: Bernd Bohmann
> Priority: Minor
> Fix For: 1.0.10
>
> Attachments: projects.zip, workingDir.patch
>
>
> We have a multi-module setup in which module A defines an annotation processor and module B uses maven-apt-plugin to generate source code. The generation itself works OK.
> When APT runs on the generated sources, since the working directory is ${tempRoot} in forked mode, APT has no access to source files. This looks like normal behavior from APT point of view (the same happens on the command line), but results in parsing errors (although the generated code is correct and builds correctly).
> A solution would be to add a ${workingDir} parameter to the mojo and make it point to the project source folder. I will submit a patch shortly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (TOBAGO-204) APT does not see sources in "self"
project when processing generated sources
Posted by "Bernd Bohmann (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/TOBAGO-204?page=comments#action_12461576 ]
Bernd Bohmann commented on TOBAGO-204:
--------------------------------------
I'm not able to test the patch on windows.
Have you tested the patch in a windows environment?
> APT does not see sources in "self" project when processing generated sources
> ----------------------------------------------------------------------------
>
> Key: TOBAGO-204
> URL: http://issues.apache.org/jira/browse/TOBAGO-204
> Project: MyFaces Tobago
> Issue Type: Bug
> Components: Maven Apt Plugin
> Affects Versions: 1.0.8
> Reporter: Thierry Monney
> Assigned To: Bernd Bohmann
> Priority: Minor
> Fix For: 1.0.10
>
> Attachments: projects.zip, workingDir.patch
>
>
> We have a multi-module setup in which module A defines an annotation processor and module B uses maven-apt-plugin to generate source code. The generation itself works OK.
> When APT runs on the generated sources, since the working directory is ${tempRoot} in forked mode, APT has no access to source files. This looks like normal behavior from APT point of view (the same happens on the command line), but results in parsing errors (although the generated code is correct and builds correctly).
> A solution would be to add a ${workingDir} parameter to the mojo and make it point to the project source folder. I will submit a patch shortly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (TOBAGO-204) APT does not see sources in "self"
project when processing generated sources
Posted by "Thierry Monney (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/TOBAGO-204?page=all ]
Thierry Monney updated TOBAGO-204:
----------------------------------
Status: Patch Available (was: Open)
> APT does not see sources in "self" project when processing generated sources
> ----------------------------------------------------------------------------
>
> Key: TOBAGO-204
> URL: http://issues.apache.org/jira/browse/TOBAGO-204
> Project: MyFaces Tobago
> Issue Type: Bug
> Components: Maven Apt Plugin
> Affects Versions: 1.0.8
> Reporter: Thierry Monney
> Priority: Minor
> Attachments: projects.zip
>
>
> We have a multi-module setup in which module A defines an annotation processor and module B uses maven-apt-plugin to generate source code. The generation itself works OK.
> When APT runs on the generated sources, since the working directory is ${tempRoot} in forked mode, APT has no access to source files. This looks like normal behavior from APT point of view (the same happens on the command line), but results in parsing errors (although the generated code is correct and builds correctly).
> A solution would be to add a ${workingDir} parameter to the mojo and make it point to the project source folder. I will submit a patch shortly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (TOBAGO-204) APT does not see sources in "self"
project when processing generated sources
Posted by "Christian E Gruber (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/TOBAGO-204?page=comments#action_12457218 ]
Christian E Gruber commented on TOBAGO-204:
-------------------------------------------
Whom can we contact to have this patch considered for inclusion in the next release of the plugin. At this point, without the patch this plugin is not useful to us, but with it it's the money. It's the cleanest APT maven plugin I've yet seen.
> APT does not see sources in "self" project when processing generated sources
> ----------------------------------------------------------------------------
>
> Key: TOBAGO-204
> URL: http://issues.apache.org/jira/browse/TOBAGO-204
> Project: MyFaces Tobago
> Issue Type: Bug
> Components: Maven Apt Plugin
> Affects Versions: 1.0.8
> Reporter: Thierry Monney
> Priority: Minor
> Attachments: projects.zip, workingDir.patch
>
>
> We have a multi-module setup in which module A defines an annotation processor and module B uses maven-apt-plugin to generate source code. The generation itself works OK.
> When APT runs on the generated sources, since the working directory is ${tempRoot} in forked mode, APT has no access to source files. This looks like normal behavior from APT point of view (the same happens on the command line), but results in parsing errors (although the generated code is correct and builds correctly).
> A solution would be to add a ${workingDir} parameter to the mojo and make it point to the project source folder. I will submit a patch shortly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (TOBAGO-204) APT does not see sources in "self"
project when processing generated sources
Posted by "Thierry Monney (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/TOBAGO-204?page=all ]
Thierry Monney updated TOBAGO-204:
----------------------------------
Status: Open (was: Patch Available)
> APT does not see sources in "self" project when processing generated sources
> ----------------------------------------------------------------------------
>
> Key: TOBAGO-204
> URL: http://issues.apache.org/jira/browse/TOBAGO-204
> Project: MyFaces Tobago
> Issue Type: Bug
> Components: Maven Apt Plugin
> Affects Versions: 1.0.8
> Reporter: Thierry Monney
> Priority: Minor
> Attachments: projects.zip
>
>
> We have a multi-module setup in which module A defines an annotation processor and module B uses maven-apt-plugin to generate source code. The generation itself works OK.
> When APT runs on the generated sources, since the working directory is ${tempRoot} in forked mode, APT has no access to source files. This looks like normal behavior from APT point of view (the same happens on the command line), but results in parsing errors (although the generated code is correct and builds correctly).
> A solution would be to add a ${workingDir} parameter to the mojo and make it point to the project source folder. I will submit a patch shortly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (TOBAGO-204) APT does not see sources in "self"
project when processing generated sources
Posted by "Thierry Monney (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/TOBAGO-204?page=comments#action_12454554 ]
Thierry Monney commented on TOBAGO-204:
---------------------------------------
It seems to work well. You can try by just changing the path to the projects I submitted. It seems the command line passed to APT has all its arguments quoted, so I guess there should be no issue.
> APT does not see sources in "self" project when processing generated sources
> ----------------------------------------------------------------------------
>
> Key: TOBAGO-204
> URL: http://issues.apache.org/jira/browse/TOBAGO-204
> Project: MyFaces Tobago
> Issue Type: Bug
> Components: Maven Apt Plugin
> Affects Versions: 1.0.8
> Reporter: Thierry Monney
> Priority: Minor
> Attachments: projects.zip, workingDir.patch
>
>
> We have a multi-module setup in which module A defines an annotation processor and module B uses maven-apt-plugin to generate source code. The generation itself works OK.
> When APT runs on the generated sources, since the working directory is ${tempRoot} in forked mode, APT has no access to source files. This looks like normal behavior from APT point of view (the same happens on the command line), but results in parsing errors (although the generated code is correct and builds correctly).
> A solution would be to add a ${workingDir} parameter to the mojo and make it point to the project source folder. I will submit a patch shortly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (TOBAGO-204) APT does not see sources in "self"
project when processing generated sources
Posted by "Thierry Monney (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOBAGO-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463026 ]
Thierry Monney commented on TOBAGO-204:
---------------------------------------
OK, then you should be fine, I wrote the patch on Windows XP.
> APT does not see sources in "self" project when processing generated sources
> ----------------------------------------------------------------------------
>
> Key: TOBAGO-204
> URL: https://issues.apache.org/jira/browse/TOBAGO-204
> Project: MyFaces Tobago
> Issue Type: Bug
> Components: Maven Apt Plugin
> Affects Versions: 1.0.8
> Reporter: Thierry Monney
> Assigned To: Bernd Bohmann
> Priority: Minor
> Fix For: 1.0.10
>
> Attachments: projects.zip, workingDir.patch
>
>
> We have a multi-module setup in which module A defines an annotation processor and module B uses maven-apt-plugin to generate source code. The generation itself works OK.
> When APT runs on the generated sources, since the working directory is ${tempRoot} in forked mode, APT has no access to source files. This looks like normal behavior from APT point of view (the same happens on the command line), but results in parsing errors (although the generated code is correct and builds correctly).
> A solution would be to add a ${workingDir} parameter to the mojo and make it point to the project source folder. I will submit a patch shortly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (TOBAGO-204) APT does not see sources in "self"
project when processing generated sources
Posted by "Thierry Monney (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOBAGO-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462983 ]
Thierry Monney commented on TOBAGO-204:
---------------------------------------
Sorry for the late response, I was still on holiday...
I tried to test my patch on Windows, it works for me. I am applying the patch with eclipse (it was created with eclipse too).
Is the problem in applying the patch or testing the patched plug-in ?
> APT does not see sources in "self" project when processing generated sources
> ----------------------------------------------------------------------------
>
> Key: TOBAGO-204
> URL: https://issues.apache.org/jira/browse/TOBAGO-204
> Project: MyFaces Tobago
> Issue Type: Bug
> Components: Maven Apt Plugin
> Affects Versions: 1.0.8
> Reporter: Thierry Monney
> Assigned To: Bernd Bohmann
> Priority: Minor
> Fix For: 1.0.10
>
> Attachments: projects.zip, workingDir.patch
>
>
> We have a multi-module setup in which module A defines an annotation processor and module B uses maven-apt-plugin to generate source code. The generation itself works OK.
> When APT runs on the generated sources, since the working directory is ${tempRoot} in forked mode, APT has no access to source files. This looks like normal behavior from APT point of view (the same happens on the command line), but results in parsing errors (although the generated code is correct and builds correctly).
> A solution would be to add a ${workingDir} parameter to the mojo and make it point to the project source folder. I will submit a patch shortly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (TOBAGO-204) APT does not see sources in "self"
project when processing generated sources
Posted by "Bernd Bohmann (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/TOBAGO-204?page=comments#action_12454461 ]
Bernd Bohmann commented on TOBAGO-204:
--------------------------------------
Can you test it with a project path that contains spaces, please.
> APT does not see sources in "self" project when processing generated sources
> ----------------------------------------------------------------------------
>
> Key: TOBAGO-204
> URL: http://issues.apache.org/jira/browse/TOBAGO-204
> Project: MyFaces Tobago
> Issue Type: Bug
> Components: Maven Apt Plugin
> Affects Versions: 1.0.8
> Reporter: Thierry Monney
> Priority: Minor
> Attachments: projects.zip, workingDir.patch
>
>
> We have a multi-module setup in which module A defines an annotation processor and module B uses maven-apt-plugin to generate source code. The generation itself works OK.
> When APT runs on the generated sources, since the working directory is ${tempRoot} in forked mode, APT has no access to source files. This looks like normal behavior from APT point of view (the same happens on the command line), but results in parsing errors (although the generated code is correct and builds correctly).
> A solution would be to add a ${workingDir} parameter to the mojo and make it point to the project source folder. I will submit a patch shortly.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira