You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/09 11:30:26 UTC

[GitHub] [flink] V1ncentzzZ commented on a change in pull request #13472: [FLINK-19291][Formats] Fix `SchemaParseException` when use `AvroSchemaConverter` converts flink logical type

V1ncentzzZ commented on a change in pull request #13472:
URL: https://github.com/apache/flink/pull/13472#discussion_r502364497



##########
File path: flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/typeutils/AvroSchemaConverter.java
##########
@@ -297,10 +297,10 @@ private static DataType convertToDataType(Schema schema) {
 	 * @return Avro's {@link Schema} matching this logical type.
 	 */
 	public static Schema convertToSchema(LogicalType logicalType) {
-		return convertToSchema(logicalType, 0);
+		return convertToSchema(logicalType, "row_0");

Review comment:
       Yeah, I think we can use "row_" append the current timestamp as default row name. Do you have any good idea?
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org