You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/08/17 22:27:52 UTC
[GitHub] codecov-io edited a comment on issue #5664: Make the filter
dropdown choices in the Filter Box cascading
codecov-io edited a comment on issue #5664: Make the filter dropdown choices in the Filter Box cascading
URL: https://github.com/apache/incubator-superset/pull/5664#issuecomment-414003518
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5664?src=pr&el=h1) Report
> Merging [#5664](https://codecov.io/gh/apache/incubator-superset/pull/5664?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5a4b70dad727e32427f498a1d3bd97a3ef119013?src=pr&el=desc) will **increase** coverage by `0.52%`.
> The diff coverage is `69.16%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/5664?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5664 +/- ##
==========================================
+ Coverage 63.49% 64.02% +0.52%
==========================================
Files 360 361 +1
Lines 22889 22940 +51
Branches 2549 2557 +8
==========================================
+ Hits 14534 14687 +153
+ Misses 8340 8238 -102
Partials 15 15
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5664?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ssets/src/visualizations/filter\_box/filter\_box.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5664/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9maWx0ZXJfYm94L2ZpbHRlcl9ib3guanN4) | `0% <0%> (ø)` | |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/5664/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `83.65% <100%> (+1.09%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/5664/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.12% <100%> (+0.19%)` | :arrow_up: |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/5664/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `91.5% <100%> (ø)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/5664/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `92.64% <100%> (+0.05%)` | :arrow_up: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/5664/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `78.94% <52.17%> (+0.28%)` | :arrow_up: |
| [...assets/src/visualizations/filter\_box/FilterBox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5664/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9maWx0ZXJfYm94L0ZpbHRlckJveC5qc3g=) | `77.95% <97.67%> (ø)` | |
| ... and [2 more](https://codecov.io/gh/apache/incubator-superset/pull/5664/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5664?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5664?src=pr&el=footer). Last update [5a4b70d...e5ef6a8](https://codecov.io/gh/apache/incubator-superset/pull/5664?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org