You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@deltaspike.apache.org by "John D. Ament" <jo...@gmail.com> on 2014/08/31 22:23:27 UTC
Commit messages
Hi all
Don't forget to include your JIRA tickets in your commit messages. Helps
create traceability!
- John
Re: Commit messages
Posted by "John D. Ament" <jo...@gmail.com>.
Agreed, hence why I said "if we have.." I doubt all doc fixes will have a
JIRA ticket, though the more the better. Definitely for any new
contributors it will be nice, this way we can track who is giving what.
On Wed, Oct 1, 2014 at 9:32 AM, Mark Struberg <st...@yahoo.de> wrote:
> Well, this is a general rule and is very important for functional changes.
>
> However, like with all rules there are certain exceptions. E.g. I will not
> create a JIRA ticket for fixing a spelling error in a JavaDoc ;)
>
> LieGrue,
> strub
>
>
>
>
> > On Wednesday, 1 October 2014, 18:24, John D. Ament <
> john.d.ament@gmail.com> wrote:
> > > I think if we have a JIRA ticket for the documentation change, we
> should
> > use that. If there is no JIRA ticket then this prefix is fine.
> >
> >
> > On Wed, Oct 1, 2014 at 9:21 AM, Gerhard Petracek <
> gerhard.petracek@gmail.com
> >> wrote:
> >
> >> hi @ all,
> >>
> >> since our documentation has moved to our git-repository, we could use a
> >> special prefix instead of a jira-ticket number for small (doc-)changes.
> >> e.g.: [DELTASPIKE-DOC]
> >>
> >> regards,
> >> gerhard
> >>
> >>
> >>
> >> 2014-08-31 23:09 GMT+02:00 Gerhard Petracek
> > <ge...@gmail.com>:
> >>
> >> > so far everybody should do it for the git-repository.
> >> > however, for the cms we haven't agreed on it.
> >> >
> >> > regards,
> >> > gerhard
> >> >
> >> >
> >> >
> >> > 2014-08-31 22:23 GMT+02:00 John D. Ament
> > <jo...@gmail.com>:
> >> >
> >> > Hi all
> >> >>
> >> >> Don't forget to include your JIRA tickets in your commit
> > messages.
> >> Helps
> >> >> create traceability!
> >> >>
> >> >> - John
> >> >>
> >> >
> >> >
> >>
> >
>
Re: Commit messages
Posted by Mark Struberg <st...@yahoo.de>.
Well, this is a general rule and is very important for functional changes.
However, like with all rules there are certain exceptions. E.g. I will not create a JIRA ticket for fixing a spelling error in a JavaDoc ;)
LieGrue,
strub
> On Wednesday, 1 October 2014, 18:24, John D. Ament <jo...@gmail.com> wrote:
> > I think if we have a JIRA ticket for the documentation change, we should
> use that. If there is no JIRA ticket then this prefix is fine.
>
>
> On Wed, Oct 1, 2014 at 9:21 AM, Gerhard Petracek <gerhard.petracek@gmail.com
>> wrote:
>
>> hi @ all,
>>
>> since our documentation has moved to our git-repository, we could use a
>> special prefix instead of a jira-ticket number for small (doc-)changes.
>> e.g.: [DELTASPIKE-DOC]
>>
>> regards,
>> gerhard
>>
>>
>>
>> 2014-08-31 23:09 GMT+02:00 Gerhard Petracek
> <ge...@gmail.com>:
>>
>> > so far everybody should do it for the git-repository.
>> > however, for the cms we haven't agreed on it.
>> >
>> > regards,
>> > gerhard
>> >
>> >
>> >
>> > 2014-08-31 22:23 GMT+02:00 John D. Ament
> <jo...@gmail.com>:
>> >
>> > Hi all
>> >>
>> >> Don't forget to include your JIRA tickets in your commit
> messages.
>> Helps
>> >> create traceability!
>> >>
>> >> - John
>> >>
>> >
>> >
>>
>
Re: Commit messages
Posted by "John D. Ament" <jo...@gmail.com>.
I think if we have a JIRA ticket for the documentation change, we should
use that. If there is no JIRA ticket then this prefix is fine.
On Wed, Oct 1, 2014 at 9:21 AM, Gerhard Petracek <gerhard.petracek@gmail.com
> wrote:
> hi @ all,
>
> since our documentation has moved to our git-repository, we could use a
> special prefix instead of a jira-ticket number for small (doc-)changes.
> e.g.: [DELTASPIKE-DOC]
>
> regards,
> gerhard
>
>
>
> 2014-08-31 23:09 GMT+02:00 Gerhard Petracek <ge...@gmail.com>:
>
> > so far everybody should do it for the git-repository.
> > however, for the cms we haven't agreed on it.
> >
> > regards,
> > gerhard
> >
> >
> >
> > 2014-08-31 22:23 GMT+02:00 John D. Ament <jo...@gmail.com>:
> >
> > Hi all
> >>
> >> Don't forget to include your JIRA tickets in your commit messages.
> Helps
> >> create traceability!
> >>
> >> - John
> >>
> >
> >
>
Re: Commit messages
Posted by Gerhard Petracek <ge...@gmail.com>.
hi @ all,
since our documentation has moved to our git-repository, we could use a
special prefix instead of a jira-ticket number for small (doc-)changes.
e.g.: [DELTASPIKE-DOC]
regards,
gerhard
2014-08-31 23:09 GMT+02:00 Gerhard Petracek <ge...@gmail.com>:
> so far everybody should do it for the git-repository.
> however, for the cms we haven't agreed on it.
>
> regards,
> gerhard
>
>
>
> 2014-08-31 22:23 GMT+02:00 John D. Ament <jo...@gmail.com>:
>
> Hi all
>>
>> Don't forget to include your JIRA tickets in your commit messages. Helps
>> create traceability!
>>
>> - John
>>
>
>
Re: Commit messages
Posted by Gerhard Petracek <ge...@gmail.com>.
so far everybody should do it for the git-repository.
however, for the cms we haven't agreed on it.
regards,
gerhard
2014-08-31 22:23 GMT+02:00 John D. Ament <jo...@gmail.com>:
> Hi all
>
> Don't forget to include your JIRA tickets in your commit messages. Helps
> create traceability!
>
> - John
>