You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/08/20 19:00:29 UTC
[GitHub] [geode] onichols-pivotal commented on a change in pull request #6781: GEODE-9527: Use TLS v 1.2 in test
onichols-pivotal commented on a change in pull request #6781:
URL: https://github.com/apache/geode/pull/6781#discussion_r693158652
##########
File path: geode-experimental-driver/src/integrationTest/java/org/apache/geode/experimental/driver/SSLTest.java
##########
@@ -179,7 +179,7 @@ public void driverCanConnectWithOneWayAuthentication() throws Exception {
@Test
public void driverCannotConnectIfProtocolsMismatch() throws Exception {
- startLocator(SERVER_KEY_STORE, SERVER_TRUST_STORE, true, "TLSv1.1", "any");
+ startLocator(SERVER_KEY_STORE, SERVER_TRUST_STORE, true, "TLSv1.2", "any");
Review comment:
since the test is trying to create a mismatch (by choosing TLS1.1 and TLS1.2), it isn't the same test anymore to use 1.2 vs 1.2. Maybe it should now be changed to TLSv1.3 on line 187?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org