You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/05/19 07:28:24 UTC

[GitHub] [kafka] kowshik opened a new pull request #10723: MINOR: Remove unused maxProducerIdExpirationMs parameter in Log constructor

kowshik opened a new pull request #10723:
URL: https://github.com/apache/kafka/pull/10723


   In this PR, I have cleaned up the unused `maxProducerIdExpirationMs` parameter in Log constructor.
   https://github.com/apache/kafka/pull/10280 had moved the `maxProducerIdExpirationMs` parameter into `LogLoader`, so this is no longer required to be passed into the `Log` constructor. 
   
   **Tests:**
   Relying on existing tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] chia7712 merged pull request #10723: MINOR: Remove unused maxProducerIdExpirationMs parameter in Log constructor

Posted by GitBox <gi...@apache.org>.
chia7712 merged pull request #10723:
URL: https://github.com/apache/kafka/pull/10723


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] kowshik edited a comment on pull request #10723: MINOR: Remove unused maxProducerIdExpirationMs parameter in Log constructor

Posted by GitBox <gi...@apache.org>.
kowshik edited a comment on pull request #10723:
URL: https://github.com/apache/kafka/pull/10723#issuecomment-843826213


   cc @junrao @ijuma @chia7712 @satishd for review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] kowshik commented on pull request #10723: MINOR: Remove unused maxProducerIdExpirationMs parameter in Log constructor

Posted by GitBox <gi...@apache.org>.
kowshik commented on pull request #10723:
URL: https://github.com/apache/kafka/pull/10723#issuecomment-843826213


   cc @junrao @ijuma @chia7712 for review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org