You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "bneradt (via GitHub)" <gi...@apache.org> on 2023/06/24 17:22:21 UTC

[GitHub] [trafficserver] bneradt commented on a diff in pull request #9891: tests: minor autest script fixes

bneradt commented on code in PR #9891:
URL: https://github.com/apache/trafficserver/pull/9891#discussion_r1240904990


##########
tests/test-env-check.sh:
##########
@@ -26,20 +26,11 @@ _END_
 
 if [ $? = 1 ]; then
     echo "Python 3.6 or newer is not installed/enabled."
-    return
+    exit 1
 else
     echo "Python 3.6 or newer detected!"
 fi
 
-# check for python development header -- for autest
-python3-config &> /dev/null
-if [ $? = 1 ]; then
-    echo "python3-dev/devel detected!"
-else
-    echo "python3-dev/devel is not installed. "
-    return
-fi
-

Review Comment:
   Huh... on my fedora:38 system, `pipenv install` fails without python3-devel. I guess we should leave this check in.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org