You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergey Shelukhin <se...@hortonworks.com> on 2017/09/05 18:47:51 UTC
Review Request 62091: HIVE-17386 support LLAP workload management in
HS2 (low level only)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62091/
-----------------------------------------------------------
Review request for hive, Zhiyuan Yang, Gunther Hagleitner, and Siddharth Seth.
Repository: hive-git
Description
-------
see jira
Diffs
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 6de07d2e76
itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java b3677322ca
llap-client/src/java/org/apache/hadoop/hive/llap/tez/LlapProtocolClientProxy.java b6501842e8
llap-client/src/test/org/apache/hadoop/hive/llap/TestAsyncPbRpcProxy.java 1c4f0e7a09
llap-common/src/gen/protobuf/gen-java/org/apache/hadoop/hive/llap/plugin/rpc/LlapPluginProtocolProtos.java 61eb21afb0
llap-common/src/java/org/apache/hadoop/hive/llap/AsyncPbRpcProxy.java 7726794fea
llap-common/src/java/org/apache/hadoop/hive/llap/impl/LlapPluginProtocolClientImpl.java 19e81e6fa5
llap-common/src/java/org/apache/hadoop/hive/llap/impl/ProtobufProxy.java fa99536bea
llap-common/src/protobuf/LlapPluginProtocol.proto 39349b119d
llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java cf8bd469dc
llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/endpoint/LlapPluginServerImpl.java f3c0d5213f
ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java 93a36c612d
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/GuaranteedTasksAllocator.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/LlapPluginEndpointClient.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/LlapPluginEndpointClientImpl.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/QueryAllocationManager.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java 4f58565a4c
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java 1f4705c083
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolSession.java 005eeedc02
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java fe5c6a1e45
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java f1f10286a3
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WmTezSession.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/TezJobMonitor.java 9e2846ca6c
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/LlapClusterStateForCompile.java 7a02a563e9
ql/src/test/org/apache/hadoop/hive/ql/exec/tez/SampleTezSessionState.java 973c0cc630
ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestGuaranteedTaskAllocator.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezSessionPool.java d2b98c46ca
ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java PRE-CREATION
service/src/java/org/apache/hive/service/server/HiveServer2.java e5f449122b
Diff: https://reviews.apache.org/r/62091/diff/1/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 62091: HIVE-17386 support LLAP workload management
in HS2 (low level only)
Posted by Sergey Shelukhin <se...@hortonworks.com>.
> On Sept. 12, 2017, 6:56 p.m., Zhiyuan Yang wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/GuaranteedTasksAllocator.java
> > Lines 191 (patched)
> > <https://reviews.apache.org/r/62091/diff/2/?file=1815854#file1815854line191>
> >
> > How would AM registry help in AM recovery? If that's not the case, this piece means any update during AM failure & recovery will fail the session, which make AM recovery in vain.
What do you mean by AM recovery? Reopening the session would produce a new session object in the pool.
> On Sept. 12, 2017, 6:56 p.m., Zhiyuan Yang wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/GuaranteedTasksAllocator.java
> > Lines 201-215 (patched)
> > <https://reviews.apache.org/r/62091/diff/2/?file=1815854#file1815854line201>
> >
> > You are really determined to knock out that field...
This is gone now.
> On Sept. 12, 2017, 6:56 p.m., Zhiyuan Yang wrote:
> > service/src/java/org/apache/hive/service/server/HiveServer2.java
> > Lines 169 (patched)
> > <https://reviews.apache.org/r/62091/diff/2/?file=1815871#file1815871line170>
> >
> > Where is the code that really put this wm instance in use? Additional jira?
It's used thru the global, see getInstance called from TezTask. I have a separate patch to get rid of some globals in HS2 that may make it more clear.
- Sergey
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62091/#review185018
-----------------------------------------------------------
On Sept. 5, 2017, 6:52 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62091/
> -----------------------------------------------------------
>
> (Updated Sept. 5, 2017, 6:52 p.m.)
>
>
> Review request for hive, Zhiyuan Yang, Gunther Hagleitner, and Siddharth Seth.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 6de07d2e76
> itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java b3677322ca
> llap-client/src/java/org/apache/hadoop/hive/llap/tez/LlapProtocolClientProxy.java b6501842e8
> llap-client/src/test/org/apache/hadoop/hive/llap/TestAsyncPbRpcProxy.java 1c4f0e7a09
> llap-common/src/java/org/apache/hadoop/hive/llap/AsyncPbRpcProxy.java 7726794fea
> llap-common/src/java/org/apache/hadoop/hive/llap/impl/LlapPluginProtocolClientImpl.java 19e81e6fa5
> llap-common/src/java/org/apache/hadoop/hive/llap/impl/ProtobufProxy.java fa99536bea
> llap-common/src/protobuf/LlapPluginProtocol.proto 39349b119d
> llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java cf8bd469dc
> llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/endpoint/LlapPluginServerImpl.java f3c0d5213f
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java 93a36c612d
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/GuaranteedTasksAllocator.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/LlapPluginEndpointClient.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/LlapPluginEndpointClientImpl.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/QueryAllocationManager.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java 4f58565a4c
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java 1f4705c083
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolSession.java 005eeedc02
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java fe5c6a1e45
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java f1f10286a3
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WmTezSession.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/TezJobMonitor.java 9e2846ca6c
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/LlapClusterStateForCompile.java 7a02a563e9
> ql/src/test/org/apache/hadoop/hive/ql/exec/tez/SampleTezSessionState.java 973c0cc630
> ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestGuaranteedTaskAllocator.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezSessionPool.java d2b98c46ca
> ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java PRE-CREATION
> service/src/java/org/apache/hive/service/server/HiveServer2.java e5f449122b
>
>
> Diff: https://reviews.apache.org/r/62091/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 62091: HIVE-17386 support LLAP workload management
in HS2 (low level only)
Posted by Zhiyuan Yang <sj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62091/#review185018
-----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
Lines 2385-2386 (patched)
<https://reviews.apache.org/r/62091/#comment261351>
Should mention setting this conf means enable workload management
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/GuaranteedTasksAllocator.java
Lines 101-106 (patched)
<https://reviews.apache.org/r/62091/#comment261379>
Why is this here given it's already a daemon thread
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/GuaranteedTasksAllocator.java
Lines 147 (patched)
<https://reviews.apache.org/r/62091/#comment261433>
Additional define statement will be better.
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/GuaranteedTasksAllocator.java
Lines 191 (patched)
<https://reviews.apache.org/r/62091/#comment261361>
How would AM registry help in AM recovery? If that's not the case, this piece means any update during AM failure & recovery will fail the session, which make AM recovery in vain.
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/GuaranteedTasksAllocator.java
Lines 201-215 (patched)
<https://reviews.apache.org/r/62091/#comment261362>
You are really determined to knock out that field...
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/LlapPluginEndpointClientImpl.java
Lines 61 (patched)
<https://reviews.apache.org/r/62091/#comment261251>
git apply complains
HIVE-17386.02.patch:1162: trailing whitespace.
}
warning: 1 line adds whitespace errors.
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java
Lines 220 (patched)
<https://reviews.apache.org/r/62091/#comment261507>
Wrong log message
service/src/java/org/apache/hive/service/server/HiveServer2.java
Lines 169 (patched)
<https://reviews.apache.org/r/62091/#comment261514>
Where is the code that really put this wm instance in use? Additional jira?
- Zhiyuan Yang
On Sept. 5, 2017, 6:52 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62091/
> -----------------------------------------------------------
>
> (Updated Sept. 5, 2017, 6:52 p.m.)
>
>
> Review request for hive, Zhiyuan Yang, Gunther Hagleitner, and Siddharth Seth.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 6de07d2e76
> itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java b3677322ca
> llap-client/src/java/org/apache/hadoop/hive/llap/tez/LlapProtocolClientProxy.java b6501842e8
> llap-client/src/test/org/apache/hadoop/hive/llap/TestAsyncPbRpcProxy.java 1c4f0e7a09
> llap-common/src/java/org/apache/hadoop/hive/llap/AsyncPbRpcProxy.java 7726794fea
> llap-common/src/java/org/apache/hadoop/hive/llap/impl/LlapPluginProtocolClientImpl.java 19e81e6fa5
> llap-common/src/java/org/apache/hadoop/hive/llap/impl/ProtobufProxy.java fa99536bea
> llap-common/src/protobuf/LlapPluginProtocol.proto 39349b119d
> llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java cf8bd469dc
> llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/endpoint/LlapPluginServerImpl.java f3c0d5213f
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java 93a36c612d
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/GuaranteedTasksAllocator.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/LlapPluginEndpointClient.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/LlapPluginEndpointClientImpl.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/QueryAllocationManager.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java 4f58565a4c
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java 1f4705c083
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolSession.java 005eeedc02
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java fe5c6a1e45
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java f1f10286a3
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WmTezSession.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/TezJobMonitor.java 9e2846ca6c
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/LlapClusterStateForCompile.java 7a02a563e9
> ql/src/test/org/apache/hadoop/hive/ql/exec/tez/SampleTezSessionState.java 973c0cc630
> ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestGuaranteedTaskAllocator.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezSessionPool.java d2b98c46ca
> ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java PRE-CREATION
> service/src/java/org/apache/hive/service/server/HiveServer2.java e5f449122b
>
>
> Diff: https://reviews.apache.org/r/62091/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 62091: HIVE-17386 support LLAP workload management
in HS2 (low level only)
Posted by Zhiyuan Yang <sj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62091/#review186173
-----------------------------------------------------------
Ship it!
Ship It!
- Zhiyuan Yang
On Sept. 13, 2017, 1:04 a.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62091/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2017, 1:04 a.m.)
>
>
> Review request for hive, Zhiyuan Yang, Gunther Hagleitner, and Siddharth Seth.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 24c5db0e47
> itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java b3677322ca
> llap-client/src/java/org/apache/hadoop/hive/llap/tez/LlapProtocolClientProxy.java b6501842e8
> llap-client/src/java/org/apache/hadoop/hive/registry/impl/TezAmInstance.java a71904cf34
> llap-client/src/test/org/apache/hadoop/hive/llap/TestAsyncPbRpcProxy.java 1c4f0e7a09
> llap-common/src/java/org/apache/hadoop/hive/llap/AsyncPbRpcProxy.java 7726794fea
> llap-common/src/java/org/apache/hadoop/hive/llap/impl/LlapPluginProtocolClientImpl.java 19e81e6fa5
> llap-common/src/java/org/apache/hadoop/hive/llap/impl/ProtobufProxy.java fa99536bea
> llap-common/src/protobuf/LlapPluginProtocol.proto 39349b119d
> llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java 26747fc5ca
> llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/endpoint/LlapPluginServerImpl.java 4d5333f995
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java 93a36c612d
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/AmPluginNode.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/GuaranteedTasksAllocator.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/LlapPluginEndpointClient.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/LlapPluginEndpointClientImpl.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/QueryAllocationManager.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java 6e8122dc85
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java 9f721553d6
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolSession.java 8ecdbbf999
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java 170de2143d
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java e6e236de6e
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WmTezSession.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/TezJobMonitor.java 9e2846ca6c
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/LlapClusterStateForCompile.java 7a02a563e9
> ql/src/test/org/apache/hadoop/hive/ql/exec/tez/SampleTezSessionState.java 4e5d99134b
> ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestGuaranteedTaskAllocator.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezSessionPool.java 5e1e68cfa8
> ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezTask.java 9b9eead0af
> ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java PRE-CREATION
> service/src/java/org/apache/hive/service/server/HiveServer2.java e5f449122b
>
>
> Diff: https://reviews.apache.org/r/62091/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 62091: HIVE-17386 support LLAP workload management
in HS2 (low level only)
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62091/
-----------------------------------------------------------
(Updated Sept. 13, 2017, 1:04 a.m.)
Review request for hive, Zhiyuan Yang, Gunther Hagleitner, and Siddharth Seth.
Changes
-------
removing protobuf changes, please diff iterations 2 and 4, ignore 3
Repository: hive-git
Description
-------
see jira
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 24c5db0e47
itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java b3677322ca
llap-client/src/java/org/apache/hadoop/hive/llap/tez/LlapProtocolClientProxy.java b6501842e8
llap-client/src/java/org/apache/hadoop/hive/registry/impl/TezAmInstance.java a71904cf34
llap-client/src/test/org/apache/hadoop/hive/llap/TestAsyncPbRpcProxy.java 1c4f0e7a09
llap-common/src/java/org/apache/hadoop/hive/llap/AsyncPbRpcProxy.java 7726794fea
llap-common/src/java/org/apache/hadoop/hive/llap/impl/LlapPluginProtocolClientImpl.java 19e81e6fa5
llap-common/src/java/org/apache/hadoop/hive/llap/impl/ProtobufProxy.java fa99536bea
llap-common/src/protobuf/LlapPluginProtocol.proto 39349b119d
llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java 26747fc5ca
llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/endpoint/LlapPluginServerImpl.java 4d5333f995
ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java 93a36c612d
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/AmPluginNode.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/GuaranteedTasksAllocator.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/LlapPluginEndpointClient.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/LlapPluginEndpointClientImpl.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/QueryAllocationManager.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java 6e8122dc85
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java 9f721553d6
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolSession.java 8ecdbbf999
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java 170de2143d
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java e6e236de6e
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WmTezSession.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/TezJobMonitor.java 9e2846ca6c
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/LlapClusterStateForCompile.java 7a02a563e9
ql/src/test/org/apache/hadoop/hive/ql/exec/tez/SampleTezSessionState.java 4e5d99134b
ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestGuaranteedTaskAllocator.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezSessionPool.java 5e1e68cfa8
ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezTask.java 9b9eead0af
ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java PRE-CREATION
service/src/java/org/apache/hive/service/server/HiveServer2.java e5f449122b
Diff: https://reviews.apache.org/r/62091/diff/4/
Changes: https://reviews.apache.org/r/62091/diff/3-4/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 62091: HIVE-17386 support LLAP workload management
in HS2 (low level only)
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62091/
-----------------------------------------------------------
(Updated Sept. 13, 2017, 12:59 a.m.)
Review request for hive, Zhiyuan Yang, Gunther Hagleitner, and Siddharth Seth.
Repository: hive-git
Description
-------
see jira
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 24c5db0e47
itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java b3677322ca
llap-client/src/java/org/apache/hadoop/hive/llap/tez/LlapProtocolClientProxy.java b6501842e8
llap-client/src/java/org/apache/hadoop/hive/registry/impl/TezAmInstance.java a71904cf34
llap-client/src/test/org/apache/hadoop/hive/llap/TestAsyncPbRpcProxy.java 1c4f0e7a09
llap-common/src/gen/protobuf/gen-java/org/apache/hadoop/hive/llap/plugin/rpc/LlapPluginProtocolProtos.java 61eb21afb0
llap-common/src/java/org/apache/hadoop/hive/llap/AsyncPbRpcProxy.java 7726794fea
llap-common/src/java/org/apache/hadoop/hive/llap/impl/LlapPluginProtocolClientImpl.java 19e81e6fa5
llap-common/src/java/org/apache/hadoop/hive/llap/impl/ProtobufProxy.java fa99536bea
llap-common/src/protobuf/LlapPluginProtocol.proto 39349b119d
llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java 26747fc5ca
llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/endpoint/LlapPluginServerImpl.java 4d5333f995
ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java 93a36c612d
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/AmPluginNode.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/GuaranteedTasksAllocator.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/LlapPluginEndpointClient.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/LlapPluginEndpointClientImpl.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/QueryAllocationManager.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java 6e8122dc85
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java 9f721553d6
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolSession.java 8ecdbbf999
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java 170de2143d
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java e6e236de6e
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WmTezSession.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/TezJobMonitor.java 9e2846ca6c
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/LlapClusterStateForCompile.java 7a02a563e9
ql/src/test/org/apache/hadoop/hive/ql/exec/tez/SampleTezSessionState.java 4e5d99134b
ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestGuaranteedTaskAllocator.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezSessionPool.java 5e1e68cfa8
ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezTask.java 9b9eead0af
ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java PRE-CREATION
service/src/java/org/apache/hive/service/server/HiveServer2.java e5f449122b
Diff: https://reviews.apache.org/r/62091/diff/3/
Changes: https://reviews.apache.org/r/62091/diff/2-3/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 62091: HIVE-17386 support LLAP workload management
in HS2 (low level only)
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62091/
-----------------------------------------------------------
(Updated Sept. 5, 2017, 6:52 p.m.)
Review request for hive, Zhiyuan Yang, Gunther Hagleitner, and Siddharth Seth.
Changes
-------
excluding generated code
Repository: hive-git
Description
-------
see jira
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 6de07d2e76
itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java b3677322ca
llap-client/src/java/org/apache/hadoop/hive/llap/tez/LlapProtocolClientProxy.java b6501842e8
llap-client/src/test/org/apache/hadoop/hive/llap/TestAsyncPbRpcProxy.java 1c4f0e7a09
llap-common/src/java/org/apache/hadoop/hive/llap/AsyncPbRpcProxy.java 7726794fea
llap-common/src/java/org/apache/hadoop/hive/llap/impl/LlapPluginProtocolClientImpl.java 19e81e6fa5
llap-common/src/java/org/apache/hadoop/hive/llap/impl/ProtobufProxy.java fa99536bea
llap-common/src/protobuf/LlapPluginProtocol.proto 39349b119d
llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java cf8bd469dc
llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/endpoint/LlapPluginServerImpl.java f3c0d5213f
ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java 93a36c612d
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/GuaranteedTasksAllocator.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/LlapPluginEndpointClient.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/LlapPluginEndpointClientImpl.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/QueryAllocationManager.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java 4f58565a4c
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java 1f4705c083
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolSession.java 005eeedc02
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java fe5c6a1e45
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java f1f10286a3
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WmTezSession.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/TezJobMonitor.java 9e2846ca6c
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/LlapClusterStateForCompile.java 7a02a563e9
ql/src/test/org/apache/hadoop/hive/ql/exec/tez/SampleTezSessionState.java 973c0cc630
ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestGuaranteedTaskAllocator.java PRE-CREATION
ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezSessionPool.java d2b98c46ca
ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java PRE-CREATION
service/src/java/org/apache/hive/service/server/HiveServer2.java e5f449122b
Diff: https://reviews.apache.org/r/62091/diff/2/
Changes: https://reviews.apache.org/r/62091/diff/1-2/
Testing
-------
Thanks,
Sergey Shelukhin