You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "Alonexc (via GitHub)" <gi...@apache.org> on 2023/03/10 02:04:37 UTC

[GitHub] [incubator-eventmesh] Alonexc opened a new issue, #3400: [Enhancement] Do some code optimization.[ WebhookPushRequest]

Alonexc opened a new issue, #3400:
URL: https://github.com/apache/incubator-eventmesh/issues/3400

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Enhancement Request
   
   ![image](https://user-images.githubusercontent.com/91315508/224203326-f42227c0-350e-4da3-a4a0-132f4195c93e.png)
   ![image](https://user-images.githubusercontent.com/91315508/224203336-68b7a58e-cd00-4b03-bed4-55e842ec75b2.png)
   ![image](https://user-images.githubusercontent.com/91315508/224203351-4a281c89-687b-4013-b0c0-c3ce512a9362.png)
   ![image](https://user-images.githubusercontent.com/91315508/224203361-da75794c-1909-4cd8-aa58-f2d4fe145aed.png)
   located at:
   eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/grpc/push/WebhookPushRequest.java line 136,180,182,360
   
   
   ### Describe the solution you'd like
   
   a. Remove invalid code.
   b. Use Objects.requireNonNull() to avoid NPE.
   ![image](https://user-images.githubusercontent.com/91315508/224203410-2cf1ea8b-8501-4452-8ca9-16b4fb2fa742.png)
   
   c. Replace "Collections.EMPTY_LIST" by "Collections.emptyList()".
   ![image](https://user-images.githubusercontent.com/91315508/224203445-fed1ca2b-f0d0-4b32-b326-21736fe2bceb.png)
   
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [eventmesh] himansh295 commented on issue #3400: [Enhancement] Do some code optimization.[WebhookPushRequest]

Posted by "himansh295 (via GitHub)" <gi...@apache.org>.
himansh295 commented on issue #3400:
URL: https://github.com/apache/eventmesh/issues/3400#issuecomment-1537512009

   Hi @Alonexc 
   Is this issue still open?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

[GitHub] [eventmesh] Alonexc commented on issue #3400: [Enhancement] Do some code optimization.[WebhookPushRequest]

Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on issue #3400:
URL: https://github.com/apache/eventmesh/issues/3400#issuecomment-1547351553

   @himansh295 Yes, this issue is fixed and I will close it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

[GitHub] [eventmesh] Alonexc closed issue #3400: [Enhancement] Do some code optimization.[WebhookPushRequest]

Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc closed issue #3400: [Enhancement] Do some code optimization.[WebhookPushRequest]
URL: https://github.com/apache/eventmesh/issues/3400


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org