You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by EricCheung3 <gi...@git.apache.org> on 2015/09/10 22:18:27 UTC
[GitHub] cordova-plugin-camera pull request: [android] fix crop from galler...
GitHub user EricCheung3 opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/124
[android] fix crop from gallery doesn't work
fix crop from gallery doesn't work
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/EricCheung3/cordova-plugin-camera master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-camera/pull/124.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #124
----
commit c975ba14f2cebbadff997dc33f317e0b23c0939a
Author: Hu Zhang <ti...@gmail.com>
Date: 2015-07-29T02:09:29Z
fix the cropping doesn't work on Kithat and when allowEdit=true, crop from PHOTOLIBRARY doesn't work on android
commit 4354c95c6259052b2d5234409b3e155e7522ded3
Author: Hu Zhang <ti...@gmail.com>
Date: 2015-07-29T03:02:51Z
forget to add 'srcType' parameter in performCrop() function
commit 00ebb4a791b8122a7799b51f582ec48c9c9bbb28
Author: Hu Zhang <ti...@gmail.com>
Date: 2015-07-29T04:10:19Z
sorry, I push a wrong code, this is right, thanks!
commit f05be9f73ed05b6b8afc044a97fb492cdd6954a0
Author: Hu Zhang <ti...@gmail.com>
Date: 2015-07-29T04:18:23Z
a little type error
commit 933dbfbff821c9a86e2937a573e3cca56227fb9c
Author: Hu Zhang <ti...@gmail.com>
Date: 2015-08-07T03:16:12Z
fix:crop from gallery bug.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request #124: [android] fix crop from gallery doe...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/124
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: [android] fix crop from galler...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/124#issuecomment-149169522
@EricCheung3, is this still actual? Are you sure this is correct?
I believe the crop should work fine with both PHOTOLIBRARY and CAMERA if your photo app have crop support. Please see https://github.com/apache/cordova-plugin-camera#android-quirks-1 for more details
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera issue #124: [android] fix crop from gallery doesn't wo...
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/124
Works for me, closing this really old issue
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org