[GitHub] brodybits commented on issue #368: package.json cleanup devDependencies

[GitBox <gi...@apache.org>]

brodybits commented on issue #368: package.json cleanup devDependencies
URL: https://github.com/apache/cordova-ios/pull/368#issuecomment-396787973
 
 
   ## Updated description
   
   Description is updated as follows:
   
   ### What does this PR do?
   
   Removes devDependencies no longer needed from `package.json`:
   - `coffee-script` (package name was deprecated in favor of `coffeescript`)
   - `uncrustify`
   
   includes plist@3 update proposed in #367
   
   ### What testing has been done on this change?
   
   - `npm run unit-tests` passes
   - starter project from `cordova create` with iOS platform added by `cordova platform add https://github.com/brodybits/cordova-ios#dev-dep-cleanup` runs on iOS simulator
   - `npm test` stages passing on Travis CI in this PR
   
   ## Moving forward
   
   As I said above this PR includes the change I proposed in #367 to update plist to 3.0.x. I would be happy to remove from this PR if needed.
   
   I also would be happy to squash the commits that remove `coffee-script` & `uncrustify` from `package.json` if needed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org