You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "github-actions[bot] (via GitHub)" <gi...@apache.org> on 2024/03/28 00:29:48 UTC
Re: [PR] [branch-2.1](partition) Support OLAP table null partition (#31827) [doris]
github-actions[bot] commented on code in PR #32936:
URL: https://github.com/apache/doris/pull/32936#discussion_r1542178719
##########
be/src/exec/tablet_info.cpp:
##########
@@ -543,16 +497,80 @@ Status VOlapTablePartitionParam::_create_partition_key(const TExprNode& t_expr,
part_key->second = column->size() - 1;
return Status::OK();
}
+// NOLINTEND(readability-function-size)
+
+Status VOlapTablePartitionParam::_create_partition_keys(const std::vector<TExprNode>& t_exprs,
Review Comment:
warning: method '_create_partition_keys' can be made static [readability-convert-member-functions-to-static]
```suggestion
static Status VOlapTablePartitionParam::_create_partition_keys(const std::vector<TExprNode>& t_exprs,
```
##########
be/src/vec/columns/column_const.h:
##########
@@ -21,11 +21,10 @@
#pragma once
#include <glog/logging.h>
Review Comment:
warning: 'glog/logging.h' file not found [clang-diagnostic-error]
```cpp
#include <glog/logging.h>
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org