You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/15 14:49:16 UTC
[GitHub] [flink] 1u0 commented on a change in pull request #9090:
[FLINK-13124] Don't forward exceptions when finishing SourceStreamTask
1u0 commented on a change in pull request #9090: [FLINK-13124] Don't forward exceptions when finishing SourceStreamTask
URL: https://github.com/apache/flink/pull/9090#discussion_r303476295
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SourceStreamTask.java
##########
@@ -127,6 +127,10 @@ protected void cancelTask() {
@Override
protected void finishTask() throws Exception {
+ // We tell the mailbox to finish, to prevent any exceptions that might occur during
+ // finishing from leading to a FAILED state. This could happen, for example, when cancelling
+ // sources as part of a "stop-with-savepoint".
+ mailboxProcessor.allActionsCompleted();
Review comment:
Sorry for being late in this PR.
Is there a reason why in `master` branch version there is `mailboxProcessor.allActionsCompleted();` in `finishTask()` but in `release-1.9` branch doesn't have it (#9115)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services