You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/05/29 15:40:38 UTC
[GitHub] [incubator-pekko] pjfanning opened a new pull request, #361: remove out of date note about java8 compat
pjfanning opened a new pull request, #361:
URL: https://github.com/apache/incubator-pekko/pull/361
a lot of this is now inlined in Pekko instead to simplify the jar dependencies
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #361: modify out of date note about java8 compat
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #361:
URL: https://github.com/apache/incubator-pekko/pull/361#discussion_r1209441567
##########
CONTRIBUTING.md:
##########
@@ -533,9 +533,7 @@ Scala has proven the most viable way to do it, as long as you keep the following
1. If the underlying Scala code requires an `ExecutionContext`, make the Java API take an `Executor` and use
`ExecutionContext.fromExecutor(executor)` for conversion.
-1. Make use of `scala-java8-compat` conversions, see [GitHub](https://github.com/scala/scala-java8-compat)
- (eg. `scala.compat.java8.FutureConverters` to translate Futures to `CompletionStage`s).
- Note that we cannot upgrade to a newer version scala-java8-compat because of binary compatibility issues.
+1. Use `org.apache.pekko.util.FutureConverters` to translate Futures to `CompletionStage`s.
Review Comment:
The whole point of having it private is so that we can completely drop these API's when we drop support for Scala 2.12 without having to break users.
I think the discussion of making these API's public is a bit of a red herring (i.e. 红鲱鱼). For me the real question is whether https://github.com/lomigmegard/pekko-http-cors and https://github.com/pjfanning/aws-spi-pekko-http should be included within Pekko itself. While Pekko having dependencies is generally not a problem, the issue in this case is that these dependencies use Pekko while Pekko happens to also rely on these dependencies.
I brought this up elsewhere and in an ideal world I would have preferred to put of these within the core Pekko codebase however we didn't have time to dicuss/contemplate this. https://github.com/pjfanning/aws-spi-pekko isn't so hard since it can be included as another module inside of pekko-connectors however pekko-http-cors should probably be its own repo but we don't have the capacity for this overhead now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on a diff in pull request #361: modify out of date note about java8 compat
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #361:
URL: https://github.com/apache/incubator-pekko/pull/361#discussion_r1209436839
##########
CONTRIBUTING.md:
##########
@@ -533,9 +533,7 @@ Scala has proven the most viable way to do it, as long as you keep the following
1. If the underlying Scala code requires an `ExecutionContext`, make the Java API take an `Executor` and use
`ExecutionContext.fromExecutor(executor)` for conversion.
-1. Make use of `scala-java8-compat` conversions, see [GitHub](https://github.com/scala/scala-java8-compat)
- (eg. `scala.compat.java8.FutureConverters` to translate Futures to `CompletionStage`s).
- Note that we cannot upgrade to a newer version scala-java8-compat because of binary compatibility issues.
+1. Use `org.apache.pekko.util.FutureConverters` to translate Futures to `CompletionStage`s.
Review Comment:
It's private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #361: modify out of date note about java8 compat
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #361:
URL: https://github.com/apache/incubator-pekko/pull/361#discussion_r1209443484
##########
CONTRIBUTING.md:
##########
@@ -533,9 +533,7 @@ Scala has proven the most viable way to do it, as long as you keep the following
1. If the underlying Scala code requires an `ExecutionContext`, make the Java API take an `Executor` and use
`ExecutionContext.fromExecutor(executor)` for conversion.
-1. Make use of `scala-java8-compat` conversions, see [GitHub](https://github.com/scala/scala-java8-compat)
- (eg. `scala.compat.java8.FutureConverters` to translate Futures to `CompletionStage`s).
- Note that we cannot upgrade to a newer version scala-java8-compat because of binary compatibility issues.
+1. Use `org.apache.pekko.util.FutureConverters` to translate Futures to `CompletionStage`s.
Review Comment:
This particular notes are for people contributing code to Pekko project. They are not about public APIs.
Users writing code that uses Pekko: if they are using Java APIs of Pekko, they should not be getting Scala Futures as return types - so they won't need to convert them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #361: modify out of date note about java8 compat
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #361:
URL: https://github.com/apache/incubator-pekko/pull/361#discussion_r1209443237
##########
CONTRIBUTING.md:
##########
@@ -533,9 +533,7 @@ Scala has proven the most viable way to do it, as long as you keep the following
1. If the underlying Scala code requires an `ExecutionContext`, make the Java API take an `Executor` and use
`ExecutionContext.fromExecutor(executor)` for conversion.
-1. Make use of `scala-java8-compat` conversions, see [GitHub](https://github.com/scala/scala-java8-compat)
- (eg. `scala.compat.java8.FutureConverters` to translate Futures to `CompletionStage`s).
- Note that we cannot upgrade to a newer version scala-java8-compat because of binary compatibility issues.
+1. Use `org.apache.pekko.util.FutureConverters` to translate Futures to `CompletionStage`s.
Review Comment:
Specifically about the documentation, I think this is fine because its in `CONTRIBUTING.md`, i.e. its intended for people working on Pekko codebase not Pekko users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on a diff in pull request #361: modify out of date note about java8 compat
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #361:
URL: https://github.com/apache/incubator-pekko/pull/361#discussion_r1209437656
##########
CONTRIBUTING.md:
##########
@@ -533,9 +533,7 @@ Scala has proven the most viable way to do it, as long as you keep the following
1. If the underlying Scala code requires an `ExecutionContext`, make the Java API take an `Executor` and use
`ExecutionContext.fromExecutor(executor)` for conversion.
-1. Make use of `scala-java8-compat` conversions, see [GitHub](https://github.com/scala/scala-java8-compat)
- (eg. `scala.compat.java8.FutureConverters` to translate Futures to `CompletionStage`s).
- Note that we cannot upgrade to a newer version scala-java8-compat because of binary compatibility issues.
+1. Use `org.apache.pekko.util.FutureConverters` to translate Futures to `CompletionStage`s.
Review Comment:
@mdedetrich Should we make it public?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #361: modify out of date note about java8 compat
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #361:
URL: https://github.com/apache/incubator-pekko/pull/361#discussion_r1209443484
##########
CONTRIBUTING.md:
##########
@@ -533,9 +533,7 @@ Scala has proven the most viable way to do it, as long as you keep the following
1. If the underlying Scala code requires an `ExecutionContext`, make the Java API take an `Executor` and use
`ExecutionContext.fromExecutor(executor)` for conversion.
-1. Make use of `scala-java8-compat` conversions, see [GitHub](https://github.com/scala/scala-java8-compat)
- (eg. `scala.compat.java8.FutureConverters` to translate Futures to `CompletionStage`s).
- Note that we cannot upgrade to a newer version scala-java8-compat because of binary compatibility issues.
+1. Use `org.apache.pekko.util.FutureConverters` to translate Futures to `CompletionStage`s.
Review Comment:
These particular notes are for people contributing code to Pekko project. They are not about public APIs.
Users writing code that uses Pekko: if they are using Java APIs of Pekko, they should not be getting Scala Futures as return types - so they won't need to convert them.
##########
CONTRIBUTING.md:
##########
@@ -533,9 +533,7 @@ Scala has proven the most viable way to do it, as long as you keep the following
1. If the underlying Scala code requires an `ExecutionContext`, make the Java API take an `Executor` and use
`ExecutionContext.fromExecutor(executor)` for conversion.
-1. Make use of `scala-java8-compat` conversions, see [GitHub](https://github.com/scala/scala-java8-compat)
- (eg. `scala.compat.java8.FutureConverters` to translate Futures to `CompletionStage`s).
- Note that we cannot upgrade to a newer version scala-java8-compat because of binary compatibility issues.
+1. Use `org.apache.pekko.util.FutureConverters` to translate Futures to `CompletionStage`s.
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin merged pull request #361: modify out of date note about java8 compat
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin merged PR #361:
URL: https://github.com/apache/incubator-pekko/pull/361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #361: modify out of date note about java8 compat
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #361:
URL: https://github.com/apache/incubator-pekko/pull/361#discussion_r1209441567
##########
CONTRIBUTING.md:
##########
@@ -533,9 +533,7 @@ Scala has proven the most viable way to do it, as long as you keep the following
1. If the underlying Scala code requires an `ExecutionContext`, make the Java API take an `Executor` and use
`ExecutionContext.fromExecutor(executor)` for conversion.
-1. Make use of `scala-java8-compat` conversions, see [GitHub](https://github.com/scala/scala-java8-compat)
- (eg. `scala.compat.java8.FutureConverters` to translate Futures to `CompletionStage`s).
- Note that we cannot upgrade to a newer version scala-java8-compat because of binary compatibility issues.
+1. Use `org.apache.pekko.util.FutureConverters` to translate Futures to `CompletionStage`s.
Review Comment:
The whole point of having it private is so that we can completely drop these API's when we drop support for Scala 2.12 without having to break users.
I think the discussion of making these API's public is a bit of a red herring (i.e. 红鲱鱼). For me the real question is whether https://github.com/lomigmegard/pekko-http-cors and https://github.com/pjfanning/aws-spi-pekko-http should be included within Pekko itself. While Pekko having dependencies is generally not a problem, the issue in this case is that these dependencies use Pekko while Pekko happens to also rely on these dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on a diff in pull request #361: modify out of date note about java8 compat
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #361:
URL: https://github.com/apache/incubator-pekko/pull/361#discussion_r1209449113
##########
CONTRIBUTING.md:
##########
@@ -533,9 +533,7 @@ Scala has proven the most viable way to do it, as long as you keep the following
1. If the underlying Scala code requires an `ExecutionContext`, make the Java API take an `Executor` and use
`ExecutionContext.fromExecutor(executor)` for conversion.
-1. Make use of `scala-java8-compat` conversions, see [GitHub](https://github.com/scala/scala-java8-compat)
- (eg. `scala.compat.java8.FutureConverters` to translate Futures to `CompletionStage`s).
- Note that we cannot upgrade to a newer version scala-java8-compat because of binary compatibility issues.
+1. Use `org.apache.pekko.util.FutureConverters` to translate Futures to `CompletionStage`s.
Review Comment:
Ha, I forgot that, I was thinking a user guide:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #361: modify out of date note about java8 compat
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #361:
URL: https://github.com/apache/incubator-pekko/pull/361#discussion_r1209441567
##########
CONTRIBUTING.md:
##########
@@ -533,9 +533,7 @@ Scala has proven the most viable way to do it, as long as you keep the following
1. If the underlying Scala code requires an `ExecutionContext`, make the Java API take an `Executor` and use
`ExecutionContext.fromExecutor(executor)` for conversion.
-1. Make use of `scala-java8-compat` conversions, see [GitHub](https://github.com/scala/scala-java8-compat)
- (eg. `scala.compat.java8.FutureConverters` to translate Futures to `CompletionStage`s).
- Note that we cannot upgrade to a newer version scala-java8-compat because of binary compatibility issues.
+1. Use `org.apache.pekko.util.FutureConverters` to translate Futures to `CompletionStage`s.
Review Comment:
The whole point of having it private is so that we can completely drop these API's when we drop support for Scala 2.12 without having to break users.
I think the discussion of making these API's relevant is a bit of a red herring (i.e. 红鲱鱼). For me the real question is whether https://github.com/lomigmegard/pekko-http-cors and https://github.com/pjfanning/aws-spi-pekko-http should be included within Pekko itself. While Pekko having dependencies is generally not a problem, the issue in this case is that these dependencies use Pekko while Pekko happens to also rely on these dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #361: modify out of date note about java8 compat
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #361:
URL: https://github.com/apache/incubator-pekko/pull/361#discussion_r1209446380
##########
CONTRIBUTING.md:
##########
@@ -533,9 +533,7 @@ Scala has proven the most viable way to do it, as long as you keep the following
1. If the underlying Scala code requires an `ExecutionContext`, make the Java API take an `Executor` and use
`ExecutionContext.fromExecutor(executor)` for conversion.
-1. Make use of `scala-java8-compat` conversions, see [GitHub](https://github.com/scala/scala-java8-compat)
- (eg. `scala.compat.java8.FutureConverters` to translate Futures to `CompletionStage`s).
- Note that we cannot upgrade to a newer version scala-java8-compat because of binary compatibility issues.
+1. Use `org.apache.pekko.util.FutureConverters` to translate Futures to `CompletionStage`s.
Review Comment:
Can we also add vice versa after these statements since the converters go both ways?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #361: modify out of date note about java8 compat
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #361:
URL: https://github.com/apache/incubator-pekko/pull/361#discussion_r1209443409
##########
CONTRIBUTING.md:
##########
@@ -533,9 +533,7 @@ Scala has proven the most viable way to do it, as long as you keep the following
1. If the underlying Scala code requires an `ExecutionContext`, make the Java API take an `Executor` and use
`ExecutionContext.fromExecutor(executor)` for conversion.
-1. Make use of `scala-java8-compat` conversions, see [GitHub](https://github.com/scala/scala-java8-compat)
- (eg. `scala.compat.java8.FutureConverters` to translate Futures to `CompletionStage`s).
- Note that we cannot upgrade to a newer version scala-java8-compat because of binary compatibility issues.
+1. Use `org.apache.pekko.util.FutureConverters` to translate Futures to `CompletionStage`s.
Review Comment:
Can we add `ObjectConverters`/`FunctionConverters` in here as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #361: modify out of date note about java8 compat
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #361:
URL: https://github.com/apache/incubator-pekko/pull/361#discussion_r1209448005
##########
CONTRIBUTING.md:
##########
@@ -533,9 +533,7 @@ Scala has proven the most viable way to do it, as long as you keep the following
1. If the underlying Scala code requires an `ExecutionContext`, make the Java API take an `Executor` and use
`ExecutionContext.fromExecutor(executor)` for conversion.
-1. Make use of `scala-java8-compat` conversions, see [GitHub](https://github.com/scala/scala-java8-compat)
- (eg. `scala.compat.java8.FutureConverters` to translate Futures to `CompletionStage`s).
- Note that we cannot upgrade to a newer version scala-java8-compat because of binary compatibility issues.
+1. Use `org.apache.pekko.util.FutureConverters` to translate Futures to `CompletionStage`s.
Review Comment:
added the 'vice versa' to each
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org