You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fury.apache.org by "chaokunyang (via GitHub)" <gi...@apache.org> on 2024/05/29 15:16:01 UTC
[PR] feat(java): scoped meta share mode for type forward/backward compaibility [incubator-fury]
chaokunyang opened a new pull request, #1660:
URL: https://github.com/apache/incubator-fury/pull/1660
## What does this PR do?
This PR implements scoped meta share mode for type forward/backward compaibility
## Related issues
#202
## Does this PR introduce any user-facing change?
<!--
If any user-facing interface changes, please [open an issue](https://github.com/apache/incubator-fury/issues/new/choose) describing the need to do so and update the document if necessary.
-->
- [ ] Does this PR introduce any public API change?
- [ ] Does this PR introduce any binary protocol compatibility change?
## Benchmark
<!--
When the PR has an impact on performance (if you don't know whether the PR will have an impact on performance, you can submit the PR first, and if it will have impact on performance, the code reviewer will explain it), be sure to attach a benchmark data here.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] feat(java): scoped meta share mode for type forward/backward compaibility [incubator-fury]
Posted by "MrChang0 (via GitHub)" <gi...@apache.org>.
MrChang0 commented on PR #1660:
URL: https://github.com/apache/incubator-fury/pull/1660#issuecomment-2138758064
It fine for me, I will try to experiment this feature.
btw, how about increase that init buffer size in `org.apache.fury.meta.ClassDefEncoder#encodeClassDef`. take less growth operate may take more performance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] feat(java): scoped meta share mode for type forward/backward compaibility [incubator-fury]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang merged PR #1660:
URL: https://github.com/apache/incubator-fury/pull/1660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] feat(java): scoped meta share mode for type forward/backward compaibility [incubator-fury]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on PR #1660:
URL: https://github.com/apache/incubator-fury/pull/1660#issuecomment-2138763606
Struct perf:
```
Before:
fury_deserialize array STRUCT false thrpt 10 4103952.355 ± 461542.704 ops/s
fury_deserialize_compatible array STRUCT false thrpt 10 2104530.838 ± 283950.067 ops/s
After:
Benchmark (bufferType) (objectType) (references) Mode Cnt Score Error Units
fury_deserialize array STRUCT false thrpt 10 3846945.672 ± 281139.320 ops/s
fury_deserialize_compatible array STRUCT false thrpt 10 3119394.319 ± 476422.038 ops/s
```
Size:
```
Before:
2024-05-30 02:06:42 INFO FuryState:157 [fury_deserialize-jmh-worker-1] - ======> Fury | STRUCT | false | array | 710 |
2024-05-30 02:07:19 INFO FuryState:157 [fury_deserialize_compatible-jmh-worker-1] - ======> Fury | STRUCT | false | array | 1134 |
After:
2024-05-30 02:01:16 INFO FuryState:157 [fury_deserialize-jmh-worker-1] - ======> Fury | STRUCT | false | array | 710 |
2024-05-30 02:01:52 INFO FuryState:157 [fury_deserialize_compatible-jmh-worker-1] - ======> Fury | STRUCT | false | array | 1227 |
```
Size bloat a little, we can optimize it later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] feat(java): scoped meta share mode for type forward/backward compaibility [incubator-fury]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on PR #1660:
URL: https://github.com/apache/incubator-fury/pull/1660#issuecomment-2138761020
> encodeClassDef
Would you like to submit a PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [PR] feat(java): scoped meta share mode for type forward/backward compaibility [incubator-fury]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on PR #1660:
URL: https://github.com/apache/incubator-fury/pull/1660#issuecomment-2137673589
Hi @MrChang0, this PR should make the meta share mode replace kv compatible mode for better performance and smaller space cost
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org