You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Roc Marshal (Jira)" <ji...@apache.org> on 2020/10/24 14:14:00 UTC

[jira] [Comment Edited] (FLINK-19749) Improve documentation for "Column Operations" in Table API page

    [ https://issues.apache.org/jira/browse/FLINK-19749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220110#comment-17220110 ] 

Roc Marshal edited comment on FLINK-19749 at 10/24/20, 2:13 PM:
----------------------------------------------------------------

Hi, 
[~jark]
[~appleyuchi]
Is it more appropriate if the jira title is set as "Improve documentation in 'Table API' page" ?
I hope to be able to fix some old code usage problems  as shown in the picture[Old API examples.png] in this PR.

What do you think of it ?





was (Author: rocmarshal):
Hi, 
[~jark]
[~appleyuchi]
Is it more appropriate if the jira title is set as 'Update expired sample code and semantics' ?
I hope to be able to fix some old code usage problems  as shown in the picture[Old API examples.png] in this PR.

What do you think of it ?




> Improve documentation for "Column Operations" in Table API page
> ---------------------------------------------------------------
>
>                 Key: FLINK-19749
>                 URL: https://issues.apache.org/jira/browse/FLINK-19749
>             Project: Flink
>          Issue Type: Improvement
>          Components: Documentation, Table SQL / API
>            Reporter: appleyuchi
>            Priority: Major
>         Attachments: Old API examples.png
>
>
> in this [link|https://ci.apache.org/projects/flink/flink-docs-stable/dev/table/tableApi.html] there's a "description":
> *Performs a field add operation. Existing fields will be replaced if add columns name is the same as the existing column name. Moreover, if the added fields have duplicate field name, then the last one is used.*
> Two point:
> ①" add columns name "->" added column's name"
> ②"if the added fields have duplicate field name",
> what's the example that has two duplicate field name?
> Could you modify them?
> They're a little misleading/unclear.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)