You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/03/31 09:34:53 UTC

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #6182: UI: Fix minor UI issues

weizhouapache commented on a change in pull request #6182:
URL: https://github.com/apache/cloudstack/pull/6182#discussion_r839386519



##########
File path: server/src/main/java/com/cloud/network/vpc/NetworkACLServiceImpl.java
##########
@@ -1146,6 +1146,9 @@ protected void validateMoveAclRulesData(NetworkACLItemVO ruleBeingMoved, Network
         NetworkACLVO acl = _networkACLDao.findById(aclId);
         Vpc vpc = _entityMgr.findById(Vpc.class, acl.getVpcId());
         Account caller = CallContext.current().getCallingAccount();
+        if (acl.getVpcId() == null) {
+            throw new InvalidParameterValueException("Unable to move rules for a default ACL");
+        }

Review comment:
       @Pearl1594 
   What does this change fix ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org