You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celix.apache.org by "pnoltes (via GitHub)" <gi...@apache.org> on 2023/10/01 16:37:14 UTC
[PR] Feature/509 remove install of v2 headers (celix)
pnoltes opened a new pull request, #666:
URL: https://github.com/apache/celix/pull/666
This PR removes the installation of the deprecated headers (those without the `celix_` prefix) from the `utils` and `framework` libraries.
This is a task in #509.
Additionally, the PR removes the installation and usage of the v2 headers for the `shell_api`, `log_service_api`, and `pubsub_spi` libraries.
As a consequence, the `shell_bonjour` and `psa_udp_mc` bundles, which relied respectively on the v2 `shell_api` and v2 pubsub serializer api and both hasn't been maintained, are also removed.
Lastly, the remote service admin bundles/libraries have been using the `service_reference` and `hashmap` in their API/SPI. As a result, they are not currently usable downstream. Addressing this requires a significant effort; thus, for this PR, I've disabled the Conan test package test for RSA. This will be addressed in a future PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feature/509 remove install of v2 headers (celix)
Posted by "pnoltes (via GitHub)" <gi...@apache.org>.
pnoltes merged PR #666:
URL: https://github.com/apache/celix/pull/666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feature/509 remove install of v2 headers (celix)
Posted by "pnoltes (via GitHub)" <gi...@apache.org>.
pnoltes commented on PR #666:
URL: https://github.com/apache/celix/pull/666#issuecomment-1752051979
> @xuzhenbao Please have a look at the RSA part.
Given that the removal of the deprecated headers and therefore the refactor RSA will be done later, I will merge this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feature/509 remove install of v2 headers (celix)
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #666:
URL: https://github.com/apache/celix/pull/666#issuecomment-1742135796
## [Codecov](https://app.codecov.io/gh/apache/celix/pull/666?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#666](https://app.codecov.io/gh/apache/celix/pull/666?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (e4a88c1) into [master](https://app.codecov.io/gh/apache/celix/commit/fedbff5e60a11421cff239581e42bfdb0283d032?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (fedbff5) will **increase** coverage by `1.38%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head e4a88c1 differs from pull request most recent head 4050a03. Consider uploading reports for the commit 4050a03 to get more accurate results
```diff
@@ Coverage Diff @@
## master #666 +/- ##
==========================================
+ Coverage 81.61% 83.00% +1.38%
==========================================
Files 260 252 -8
Lines 34677 32789 -1888
==========================================
- Hits 28303 27217 -1086
+ Misses 6374 5572 -802
```
| [Files](https://app.codecov.io/gh/apache/celix/pull/666?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...les/pubsub/pubsub\_admin\_tcp/src/pubsub\_tcp\_admin.c](https://app.codecov.io/gh/apache/celix/pull/666?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF9hZG1pbi5j) | `50.50% <ø> (ø)` | |
| [...b/pubsub\_admin\_tcp/src/pubsub\_tcp\_topic\_receiver.c](https://app.codecov.io/gh/apache/celix/pull/666?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF90b3BpY19yZWNlaXZlci5j) | `68.95% <ø> (ø)` | |
| [...sub/pubsub\_admin\_tcp/src/pubsub\_tcp\_topic\_sender.c](https://app.codecov.io/gh/apache/celix/pull/666?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC9zcmMvcHVic3ViX3RjcF90b3BpY19zZW5kZXIuYw==) | `84.01% <ø> (ø)` | |
| [.../pubsub/pubsub\_admin\_websocket/src/psa\_activator.c](https://app.codecov.io/gh/apache/celix/pull/666?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3dlYnNvY2tldC9zcmMvcHNhX2FjdGl2YXRvci5j) | `100.00% <ø> (ø)` | |
| [...ubsub\_admin\_websocket/src/pubsub\_websocket\_admin.c](https://app.codecov.io/gh/apache/celix/pull/666?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3dlYnNvY2tldC9zcmMvcHVic3ViX3dlYnNvY2tldF9hZG1pbi5j) | `42.47% <ø> (ø)` | |
| [...in\_websocket/src/pubsub\_websocket\_topic\_receiver.c](https://app.codecov.io/gh/apache/celix/pull/666?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3dlYnNvY2tldC9zcmMvcHVic3ViX3dlYnNvY2tldF90b3BpY19yZWNlaXZlci5j) | `67.56% <ø> (ø)` | |
| [...dmin\_websocket/src/pubsub\_websocket\_topic\_sender.c](https://app.codecov.io/gh/apache/celix/pull/666?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3dlYnNvY2tldC9zcmMvcHVic3ViX3dlYnNvY2tldF90b3BpY19zZW5kZXIuYw==) | `83.22% <ø> (-0.68%)` | :arrow_down: |
| [...les/pubsub/pubsub\_admin\_zmq/src/pubsub\_zmq\_admin.c](https://app.codecov.io/gh/apache/celix/pull/666?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3ptcS9zcmMvcHVic3ViX3ptcV9hZG1pbi5j) | `53.42% <ø> (ø)` | |
| [...b/pubsub\_admin\_zmq/src/pubsub\_zmq\_topic\_receiver.c](https://app.codecov.io/gh/apache/celix/pull/666?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3ptcS9zcmMvcHVic3ViX3ptcV90b3BpY19yZWNlaXZlci5j) | `76.71% <ø> (ø)` | |
| [...sub/pubsub\_admin\_zmq/src/pubsub\_zmq\_topic\_sender.c](https://app.codecov.io/gh/apache/celix/pull/666?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3ptcS9zcmMvcHVic3ViX3ptcV90b3BpY19zZW5kZXIuYw==) | `84.05% <ø> (ø)` | |
| ... and [6 more](https://app.codecov.io/gh/apache/celix/pull/666?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1 file with indirect coverage changes](https://app.codecov.io/gh/apache/celix/pull/666/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feature/509 remove install of v2 headers (celix)
Posted by "pnoltes (via GitHub)" <gi...@apache.org>.
pnoltes commented on PR #666:
URL: https://github.com/apache/celix/pull/666#issuecomment-1751698024
>
> If the current 3.0 API can not address some requirements, it is a good chance to have some discussions before actually removing deprecated 2.0 APIs.
>
I understand. My proposal is to reintroduce the framework v2 headers install and RSA conan create test in PR.
We can then discuss the removal of service_reference, etc and the future of RSA, before removing all v2 headers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Feature/509 remove install of v2 headers (celix)
Posted by "PengZheng (via GitHub)" <gi...@apache.org>.
PengZheng commented on PR #666:
URL: https://github.com/apache/celix/pull/666#issuecomment-1751701291
> I understand. My proposal is to reintroduce the framework v2 headers install and RSA conan create test in PR.
We can then discuss the removal of service_reference, etc and the future of RSA, before removing all v2 headers.
It's a good idea to temporarily reintroduce framework v2 headers.
Now that 2.4.0 is available, I am working on introducing it into my day job projects.
After that I will be able to provide precise feedback about the current usage of deprecated APIs in these projects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org