You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by ca...@apache.org on 2020/08/09 13:41:19 UTC

[royale-asjs] branch develop updated: Revert "jewel-sectioncontent: fix an issue with sizing in components inside SectionContent containers. Since SC default state is hidden, that made components inside report 0 for width and height instead getting the right size, This should hopefully solve other layout issues"

This is an automated email from the ASF dual-hosted git repository.

carlosrovira pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to refs/heads/develop by this push:
     new dd761da  Revert "jewel-sectioncontent: fix an issue with sizing in components inside SectionContent containers. Since SC default state is hidden, that made components inside report 0 for width and height instead getting the right size, This should hopefully solve other layout issues"
dd761da is described below

commit dd761da232b7b921e580fed8ff6c5eb630edfa29
Author: Carlos Rovira <ca...@apache.org>
AuthorDate: Sun Aug 9 15:40:54 2020 +0200

    Revert "jewel-sectioncontent: fix an issue with sizing in components inside SectionContent containers. Since SC default state is hidden, that made components inside report 0 for width and height instead getting the right size, This should hopefully solve other layout issues"
    
    This reverts commit 2af3137baccfcc2df5ea500edef4b8eced3a320a.
---
 frameworks/projects/Jewel/src/main/resources/defaults.css            | 5 ++---
 .../projects/Jewel/src/main/sass/components/_sectioncontent.sass     | 5 ++---
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/frameworks/projects/Jewel/src/main/resources/defaults.css b/frameworks/projects/Jewel/src/main/resources/defaults.css
index c0592b0..c52645f 100644
--- a/frameworks/projects/Jewel/src/main/resources/defaults.css
+++ b/frameworks/projects/Jewel/src/main/resources/defaults.css
@@ -3504,8 +3504,7 @@ j|PopUp {
   }
 }
 .jewel.section {
-  display: flex;
-  visibility: hidden;
+  display: none;
   flex-flow: column nowrap;
   height: 100%;
 }
@@ -3513,7 +3512,7 @@ j|PopUp {
   flex: 0 0 auto;
 }
 .jewel.section.is-selected {
-  visibility: visible;
+  display: flex;
 }
 
 j|SectionContent {
diff --git a/frameworks/projects/Jewel/src/main/sass/components/_sectioncontent.sass b/frameworks/projects/Jewel/src/main/sass/components/_sectioncontent.sass
index 418382b..8fe2f99 100644
--- a/frameworks/projects/Jewel/src/main/sass/components/_sectioncontent.sass
+++ b/frameworks/projects/Jewel/src/main/sass/components/_sectioncontent.sass
@@ -22,8 +22,7 @@
 // SectionContent variables
 
 .jewel.section
-    display: flex
-    visibility: hidden
+    display: none
     flex-flow: column nowrap
     height: 100%
 
@@ -31,7 +30,7 @@
         flex: 0 0 auto
     
     &.is-selected
-        visibility: visible
+        display: flex
 
 j|SectionContent
     IBeadLayout: ClassReference("org.apache.royale.jewel.beads.layouts.NullLayout")