[jira] [Commented] (AVRO-1957) TimeConversions do not implement getRecommendedSchema()

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AVRO-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717789#comment-16717789 ] 

ASF subversion and git services commented on AVRO-1957:
-------------------------------------------------------

Commit 3fe8df71592b149500f2f5e1c666268ded63d1fc in avro's branch refs/heads/branch-1.8 from [~nstimm]
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=3fe8df7 ]

AVRO-1957: TimeConversions do not implement getRecommendedSchema()

This closes #154

Signed-off-by: Gabor Szadovszky <ga...@apache.org>
Signed-off-by: sacharya <su...@apache.org>
Signed-off-by: Nandor Kollar <nk...@apache.org>
(cherry picked from commit 027d196fd3f6f990977a4e86c1c07464506cabc3)


> TimeConversions do not implement getRecommendedSchema()
> -------------------------------------------------------
>
>                 Key: AVRO-1957
>                 URL: https://issues.apache.org/jira/browse/AVRO-1957
>             Project: Apache Avro
>          Issue Type: Bug
>    Affects Versions: 1.8.1
>            Reporter: Sean Timm
>            Assignee: Sean Timm
>            Priority: Major
>             Fix For: 1.9.0, 1.8.3
>
>
> org.apache.avro.data.TimeConversions.TimestampConversion and other date and time conversions do not implement getRecommendedSchema(). When trying to dynamically generate an Avro schema from a pojo that contains a DateTime object using ReflectData, I get an unsupported operation exception.
> I think the implementation should be as simple as
> {code}
> @Override
> public Schema getRecommendedSchema() {
>       return LogicalTypes.timestampMillis().addToSchema(Schema.create(Schema.Type.LONG));
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)