[GitHub] [hbase] timoha commented on a change in pull request #1613: HBASE-24273 HBCK's "Orphan Regions on FileSystem" reports regions wit…

[GitBox <gi...@apache.org>]

timoha commented on a change in pull request #1613:
URL: https://github.com/apache/hbase/pull/1613#discussion_r418087209



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HbckChore.java
##########
@@ -134,7 +135,7 @@ protected synchronized void chore() {
       loadRegionsFromInMemoryState();
       loadRegionsFromRSReport();
       try {
-        loadRegionsFromFS();
+        loadRegionsFromFS(scanForMergedParentRegions());

Review comment:
       would it make sense to make it a bit more generic and have "loadRegionsFromMeta()" function (similar to loadRegionsFromInMemoryState/loadRegionsFromRSReport) as then you'd have another source to compare against - hbase:meta. Then loadRegionsFromFS() would check against that state to see if a region is merged or not.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org