You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/11/08 19:32:18 UTC
[GitHub] [superset] lyndsiWilliams opened a new pull request, #22066: fix: Fixed spacing in alert modal
lyndsiWilliams opened a new pull request, #22066:
URL: https://github.com/apache/superset/pull/22066
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
This PR fixes the spacing under the "Message content" section of the alert modal.
Note: When I adjusted the spacing I noticed a few spots in the component that needed translating/cleanup so I added that to this PR as well.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
#### BEFORE:
#### AFTER:
#### AFTER (extended)
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
- Go to the Alerts & reports page and click the "+ ALERT" button
- Observe the spacing between elements
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] lyndsiWilliams commented on a diff in pull request #22066: fix: Fixed spacing in alert modal
Posted by GitBox <gi...@apache.org>.
lyndsiWilliams commented on code in PR #22066:
URL: https://github.com/apache/superset/pull/22066#discussion_r1052378536
##########
superset-frontend/src/views/CRUD/alert/AlertReportModal.tsx:
##########
@@ -1044,14 +1051,50 @@ const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({
setIsHidden(false);
}
+ const SAVE_TEXT = t('Save');
Review Comment:
Definitely! Done in [`this commit`](https://github.com/apache/superset/pull/22066/commits/c74039460331569ae9d29c6398fd2dd937a3971b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] lyndsiWilliams commented on pull request #22066: fix: Fixed spacing in alert modal
Posted by GitBox <gi...@apache.org>.
lyndsiWilliams commented on PR #22066:
URL: https://github.com/apache/superset/pull/22066#issuecomment-1340296847
Closing and reopening to reset the ephemeral environment, things aren't showing up properly 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #22066: fix: Fixed spacing in alert modal
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22066:
URL: https://github.com/apache/superset/pull/22066#issuecomment-1340297057
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] lyndsiWilliams closed pull request #22066: fix: Fixed spacing in alert modal
Posted by GitBox <gi...@apache.org>.
lyndsiWilliams closed pull request #22066: fix: Fixed spacing in alert modal
URL: https://github.com/apache/superset/pull/22066
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] lyndsiWilliams commented on pull request #22066: fix: Fixed spacing in alert modal
Posted by GitBox <gi...@apache.org>.
lyndsiWilliams commented on PR #22066:
URL: https://github.com/apache/superset/pull/22066#issuecomment-1340267898
/testenv up ALERT_REPORTS=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] lyndsiWilliams commented on pull request #22066: fix: Fixed spacing in alert modal
Posted by GitBox <gi...@apache.org>.
lyndsiWilliams commented on PR #22066:
URL: https://github.com/apache/superset/pull/22066#issuecomment-1339392622
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #22066: fix: Fixed spacing in alert modal
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22066:
URL: https://github.com/apache/superset/pull/22066#issuecomment-1340270591
@lyndsiWilliams Ephemeral environment spinning up at http://35.88.163.217:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #22066: fix: Fixed spacing in alert modal
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22066:
URL: https://github.com/apache/superset/pull/22066#issuecomment-1359868888
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] lyndsiWilliams commented on a diff in pull request #22066: fix: Fixed spacing in alert modal
Posted by GitBox <gi...@apache.org>.
lyndsiWilliams commented on code in PR #22066:
URL: https://github.com/apache/superset/pull/22066#discussion_r1041670247
##########
superset-frontend/src/views/CRUD/alert/AlertReportModal.tsx:
##########
@@ -1300,7 +1309,7 @@ const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({
placeholder={t('Time in seconds')}
onChange={onTimeoutVerifyChange}
/>
- <span className="input-label">seconds</span>
+ <span className="input-label">{t('seconds')}</span>
Review Comment:
You got it! Done in [`this commit`](https://github.com/apache/superset/pull/22066/commits/44a5883c12fd8d6d00d149723956a744dd87dc98). (I think I got them all!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #22066: fix: Fixed spacing in alert modal
Posted by GitBox <gi...@apache.org>.
rusackas commented on PR #22066:
URL: https://github.com/apache/superset/pull/22066#issuecomment-1341578741
Ephemeral environment seems to be running OK, but I spotted a couple of styling issues there. I can't seem to upload an image here for some reason at the moment, so I'll Slack ya.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on a diff in pull request #22066: fix: Fixed spacing in alert modal
Posted by GitBox <gi...@apache.org>.
eschutho commented on code in PR #22066:
URL: https://github.com/apache/superset/pull/22066#discussion_r1051140384
##########
superset-frontend/src/views/CRUD/alert/AlertReportModal.tsx:
##########
@@ -1044,14 +1051,50 @@ const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({
setIsHidden(false);
}
+ const SAVE_TEXT = t('Save');
Review Comment:
@lyndsiWilliams are we going to move these into a `TRANSLATIONS` object?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #22066: fix: Fixed spacing in alert modal
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22066:
URL: https://github.com/apache/superset/pull/22066#issuecomment-1340978010
@lyndsiWilliams Ephemeral environment spinning up at http://34.221.178.82:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #22066: fix: Fixed spacing in alert modal
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22066:
URL: https://github.com/apache/superset/pull/22066#issuecomment-1339398187
@lyndsiWilliams Ephemeral environment spinning up at http://34.212.220.189:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] lyndsiWilliams commented on pull request #22066: fix: Fixed spacing in alert modal
Posted by GitBox <gi...@apache.org>.
lyndsiWilliams commented on PR #22066:
URL: https://github.com/apache/superset/pull/22066#issuecomment-1340289649
/testenv up FEATURE_ALERT_REPORTS=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] lyndsiWilliams merged pull request #22066: fix: Fixed spacing in alert modal
Posted by GitBox <gi...@apache.org>.
lyndsiWilliams merged PR #22066:
URL: https://github.com/apache/superset/pull/22066
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] lyndsiWilliams commented on pull request #22066: fix: Fixed spacing in alert modal
Posted by GitBox <gi...@apache.org>.
lyndsiWilliams commented on PR #22066:
URL: https://github.com/apache/superset/pull/22066#issuecomment-1338680718
> @lyndsiWilliams @yousoph will there be any more actions happening on this PR, or should we merge it as-is?
More actions for sure! @yousoph , @eschutho , Karan, and I all got together on zoom to check this out together and discuss the styling. We decided to, for now, just get everything aligned with the 16px border to clean it up a little more. I just pushed up the changes in [`this commit`](https://github.com/apache/superset/pull/22066/commits/af49885ce136d8c23fde80fc263d919bc83ed82b).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] lyndsiWilliams commented on pull request #22066: fix: Fixed spacing in alert modal
Posted by GitBox <gi...@apache.org>.
lyndsiWilliams commented on PR #22066:
URL: https://github.com/apache/superset/pull/22066#issuecomment-1340975006
/testenv up FEATURE_ALERT_REPORTS=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] lyndsiWilliams commented on pull request #22066: fix: Fixed spacing in alert modal
Posted by GitBox <gi...@apache.org>.
lyndsiWilliams commented on PR #22066:
URL: https://github.com/apache/superset/pull/22066#issuecomment-1307826917
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Antonio-RiveroMartnez commented on a diff in pull request #22066: fix: Fixed spacing in alert modal
Posted by GitBox <gi...@apache.org>.
Antonio-RiveroMartnez commented on code in PR #22066:
URL: https://github.com/apache/superset/pull/22066#discussion_r1041254546
##########
superset-frontend/src/views/CRUD/alert/AlertReportModal.tsx:
##########
@@ -1300,7 +1309,7 @@ const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({
placeholder={t('Time in seconds')}
onChange={onTimeoutVerifyChange}
/>
- <span className="input-label">seconds</span>
+ <span className="input-label">{t('seconds')}</span>
Review Comment:
I totally liked what you did here: https://github.com/apache/superset/pull/22262/files#diff-bbf91464669d98b9e120f57ce26155804f7238a277fcc30c0d805a943f6c73edR98 , could we do the same for these?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #22066: fix: Fixed spacing in alert modal
Posted by GitBox <gi...@apache.org>.
rusackas commented on PR #22066:
URL: https://github.com/apache/superset/pull/22066#issuecomment-1353673710
Do we still have build/ephemeral concerns here, or is this ready for the final once-over?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #22066: fix: Fixed spacing in alert modal
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #22066:
URL: https://github.com/apache/superset/pull/22066#issuecomment-1307730959
# [Codecov](https://codecov.io/gh/apache/superset/pull/22066?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22066](https://codecov.io/gh/apache/superset/pull/22066?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c86219c) into [master](https://codecov.io/gh/apache/superset/commit/cd1b379bdf323f78c2e7d574525a55898c920942?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cd1b379) will **decrease** coverage by `11.34%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #22066 +/- ##
===========================================
- Coverage 67.07% 55.72% -11.35%
===========================================
Files 1815 1815
Lines 69575 69575
Branches 7486 7486
===========================================
- Hits 46665 38771 -7894
- Misses 20974 28868 +7894
Partials 1936 1936
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.82% <ø> (ø)` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `52.73% <ø> (ø)` | |
| python | `58.03% <ø> (-23.54%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `51.20% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/22066?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...frontend/src/views/CRUD/alert/AlertReportModal.tsx](https://codecov.io/gh/apache/superset/pull/22066/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvQWxlcnRSZXBvcnRNb2RhbC50c3g=) | `52.08% <0.00%> (ø)` | |
| [superset/utils/dashboard\_import\_export.py](https://codecov.io/gh/apache/superset/pull/22066/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ltcG9ydF9leHBvcnQucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/tags/core.py](https://codecov.io/gh/apache/superset/pull/22066/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdGFncy9jb3JlLnB5) | `4.54% <0.00%> (-95.46%)` | :arrow_down: |
| [superset/key\_value/commands/update.py](https://codecov.io/gh/apache/superset/pull/22066/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQva2V5X3ZhbHVlL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `0.00% <0.00%> (-90.91%)` | :arrow_down: |
| [superset/key\_value/commands/delete.py](https://codecov.io/gh/apache/superset/pull/22066/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQva2V5X3ZhbHVlL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `0.00% <0.00%> (-87.88%)` | :arrow_down: |
| [superset/key\_value/commands/delete\_expired.py](https://codecov.io/gh/apache/superset/pull/22066/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQva2V5X3ZhbHVlL2NvbW1hbmRzL2RlbGV0ZV9leHBpcmVkLnB5) | `0.00% <0.00%> (-84.00%)` | :arrow_down: |
| [superset/dashboards/commands/importers/v0.py](https://codecov.io/gh/apache/superset/pull/22066/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjAucHk=) | `15.62% <0.00%> (-76.25%)` | :arrow_down: |
| [superset/datasets/commands/create.py](https://codecov.io/gh/apache/superset/pull/22066/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvY3JlYXRlLnB5) | `30.61% <0.00%> (-69.39%)` | :arrow_down: |
| [superset/datasets/commands/update.py](https://codecov.io/gh/apache/superset/pull/22066/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvdXBkYXRlLnB5) | `25.00% <0.00%> (-69.05%)` | :arrow_down: |
| [superset/datasets/commands/importers/v0.py](https://codecov.io/gh/apache/superset/pull/22066/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YwLnB5) | `24.03% <0.00%> (-69.00%)` | :arrow_down: |
| ... and [285 more](https://codecov.io/gh/apache/superset/pull/22066/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #22066: fix: Fixed spacing in alert modal
Posted by GitBox <gi...@apache.org>.
eschutho commented on PR #22066:
URL: https://github.com/apache/superset/pull/22066#issuecomment-1307983198
@lyndsiWilliams This looks great!! Can we also left align it to either match up with the dashboard/chart select box or the email select box? Maybe @yousoph or a designer my have more opinions there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #22066: fix: Fixed spacing in alert modal
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22066:
URL: https://github.com/apache/superset/pull/22066#issuecomment-1340292135
@lyndsiWilliams Ephemeral environment spinning up at http://18.237.171.173:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] lyndsiWilliams commented on pull request #22066: fix: Fixed spacing in alert modal
Posted by GitBox <gi...@apache.org>.
lyndsiWilliams commented on PR #22066:
URL: https://github.com/apache/superset/pull/22066#issuecomment-1341333244
The ephemeral environment doesn't seem to be working correctly for this PR, so visual testing will have to be done locally. This is how it should look:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #22066: fix: Fixed spacing in alert modal
Posted by GitBox <gi...@apache.org>.
rusackas commented on PR #22066:
URL: https://github.com/apache/superset/pull/22066#issuecomment-1338236337
@lyndsiWilliams @yousoph will there be any more actions happening on this PR, or should we merge it as-is?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #22066: fix: Fixed spacing in alert modal
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22066:
URL: https://github.com/apache/superset/pull/22066#issuecomment-1341797119
@lyndsiWilliams Ephemeral environment spinning up at http://54.244.206.8:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] lyndsiWilliams commented on pull request #22066: fix: Fixed spacing in alert modal
Posted by GitBox <gi...@apache.org>.
lyndsiWilliams commented on PR #22066:
URL: https://github.com/apache/superset/pull/22066#issuecomment-1341793941
/testenv up FEATURE_ALERT_REPORTS=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] lyndsiWilliams commented on pull request #22066: fix: Fixed spacing in alert modal
Posted by GitBox <gi...@apache.org>.
lyndsiWilliams commented on PR #22066:
URL: https://github.com/apache/superset/pull/22066#issuecomment-1355417484
> Do we still have build/ephemeral concerns here, or is this ready for the final once-over?
I'm not sure what's going on with the ephemeral, I'd be happy to zoom and show this locally if that would increase confidence in this. I feel (and hope) that this is just a case of the ephemeral not working correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #22066: fix: Fixed spacing in alert modal
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22066:
URL: https://github.com/apache/superset/pull/22066#issuecomment-1307829113
@lyndsiWilliams Ephemeral environment spinning up at http://34.216.6.154:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org