You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@geode.apache.org by "Owen Nichols (Jira)" <ji...@apache.org> on 2022/06/22 20:46:01 UTC

[jira] [Closed] (GEODE-9449) remove 'b' prefix from constants

     [ https://issues.apache.org/jira/browse/GEODE-9449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen Nichols closed GEODE-9449.
-------------------------------

> remove 'b' prefix from constants
> --------------------------------
>
>                 Key: GEODE-9449
>                 URL: https://issues.apache.org/jira/browse/GEODE-9449
>             Project: Geode
>          Issue Type: Improvement
>          Components: redis
>    Affects Versions: 1.15.0
>            Reporter: Darrel Schneider
>            Assignee: Kristen
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.15.0
>
>
> I number of constants in the redis packages have a 'b' prefix on their name. This might have been a use of Hungarian notation but that is not clear. The convention for constant names in geode is all upper case with underscore between words. So the 'b' prefix should be removed. See StringBytesGlossary for the location of many of these constants. Most of the constants in StringBytesGlossary contains bytes, one or more, but if a few of the constants in it are actually String instances. Consider renaming them to have _STRING suffix or moving them to another class like StringGlossary. 
> The byte array constants in this class are marked with the MakeImmutable annotation. 



--
This message was sent by Atlassian Jira
(v8.20.7#820007)