You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2015/07/14 02:30:32 UTC
Review Request 36469: Updated scheduler driver to send MESSAGE call.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36469/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: MESOS-2913
https://issues.apache.org/jira/browse/MESOS-2913
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/sched/sched.cpp a748686dfc6bff39d81fd7adbd5cce88ddaaa73d
src/tests/fault_tolerance_tests.cpp 1070ccf17f98f6b3800684a5edd6517d90631c3e
Diff: https://reviews.apache.org/r/36469/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 36469: Updated scheduler driver to send MESSAGE
call.
Posted by Vinod Kone <vi...@gmail.com>.
> On July 15, 2015, 5:58 p.m., Ben Mahler wrote:
> > src/tests/fault_tolerance_tests.cpp, lines 1313-1315
> > <https://reviews.apache.org/r/36469/diff/1/?file=1010296#file1010296line1313>
> >
> > We don't need to worry about gcc 4.1.* anymore, you can assign now on the same line :)
copy paste error. fixed.
> On July 15, 2015, 5:58 p.m., Ben Mahler wrote:
> > src/tests/fault_tolerance_tests.cpp, line 1265
> > <https://reviews.apache.org/r/36469/diff/1/?file=1010296#file1010296line1265>
> >
> > Did you want to expect that the message is sent to through the master using call, since it looks like no offers go to the second scheduler?
sure thing.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36469/#review91770
-----------------------------------------------------------
On July 14, 2015, 12:30 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36469/
> -----------------------------------------------------------
>
> (Updated July 14, 2015, 12:30 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-2913
> https://issues.apache.org/jira/browse/MESOS-2913
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/sched/sched.cpp a748686dfc6bff39d81fd7adbd5cce88ddaaa73d
> src/tests/fault_tolerance_tests.cpp 1070ccf17f98f6b3800684a5edd6517d90631c3e
>
> Diff: https://reviews.apache.org/r/36469/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 36469: Updated scheduler driver to send MESSAGE
call.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36469/#review91770
-----------------------------------------------------------
Ship it!
src/sched/sched.cpp (line 1132)
<https://reviews.apache.org/r/36469/#comment145414>
Ditto newline comment from other reviews.
src/tests/fault_tolerance_tests.cpp (line 1265)
<https://reviews.apache.org/r/36469/#comment145418>
Did you want to expect that the message is sent to through the master using call, since it looks like no offers go to the second scheduler?
src/tests/fault_tolerance_tests.cpp (lines 1313 - 1315)
<https://reviews.apache.org/r/36469/#comment145415>
We don't need to worry about gcc 4.1.* anymore, you can assign now on the same line :)
- Ben Mahler
On July 14, 2015, 12:30 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36469/
> -----------------------------------------------------------
>
> (Updated July 14, 2015, 12:30 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-2913
> https://issues.apache.org/jira/browse/MESOS-2913
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/sched/sched.cpp a748686dfc6bff39d81fd7adbd5cce88ddaaa73d
> src/tests/fault_tolerance_tests.cpp 1070ccf17f98f6b3800684a5edd6517d90631c3e
>
> Diff: https://reviews.apache.org/r/36469/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 36469: Updated scheduler driver to send MESSAGE
call.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36469/
-----------------------------------------------------------
(Updated July 17, 2015, 3:16 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
benm's. NNFR.
Bugs: MESOS-2913
https://issues.apache.org/jira/browse/MESOS-2913
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/sched/sched.cpp de76803581d32d7f7e93aac1678e3a2eba577e73
src/tests/fault_tolerance_tests.cpp 1070ccf17f98f6b3800684a5edd6517d90631c3e
src/tests/slave_recovery_tests.cpp 2f882cf7b4235583b0ec8397cfcbbc02930fbc88
Diff: https://reviews.apache.org/r/36469/diff/
Testing
-------
make check
Thanks,
Vinod Kone