[GitHub] saintstack commented on a change in pull request #3: HBASE-21002 make an assembly for hbase-connectors

[GitBox <gi...@apache.org>]

saintstack commented on a change in pull request #3: HBASE-21002 make an assembly for hbase-connectors
URL: https://github.com/apache/hbase-connectors/pull/3#discussion_r218127793
 
 

 ##########
 File path: kafka/hbase-kafka-proxy/src/main/java/org/apache/hadoop/hbase/kafka/KafkaProxy.java
 ##########
 @@ -154,19 +150,28 @@ public static void main(String[] args) throws Exception {
     options.addOption("e", "enablepeer", false,
         "enable peer on startup (defaults to false)");
 
-
     LOG.info("STARTING executorService " + HRegionServer.class.getSimpleName());
     VersionInfo.logVersion();
 
     Configuration conf = HBaseConfiguration.create();
     CommandLine commandLine = null;
+
+    Configuration commandLineConf = new Configuration();
 
 Review comment:
   Should this be HBaseConfiguration.create to pick up hbase-site?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services