[jira] Commented: (ODE-236) Add support for from-spec inside a variable declaration to initialize it. . This is a standard BPEL 2.0 construct

["Matthieu Riou (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ODE-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699446#action_12699446 ] 

Matthieu Riou commented on ODE-236:
-----------------------------------

Overall it's a very good patch, well tested and implemented.

About point 3&4 I agree it would be better to externalize the few methods you're reusing, instantiating an ASSIGN in SCOPE just to access those isn't very nice. So I'd create an AssignHelper class also in the runtime package that both ASSIGN and SCOPE could use. It wouldn't be a general purpose helper, just one for the specific problem of doing assignments in the runtime so placing it in the same package is fair. Would it also be doable to make common the code you have in SCOPE.initVar and SCOPE.evalLValue ?

Thanks a lot for the patch!



> Add support for from-spec inside a variable declaration to initialize it. . This is a standard BPEL 2.0 construct
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: ODE-236
>                 URL: https://issues.apache.org/jira/browse/ODE-236
>             Project: ODE
>          Issue Type: Improvement
>          Components: BPEL Runtime
>    Affects Versions: 1.1.1
>            Reporter: Hugues Malphettes
>             Fix For: 2.0
>
>         Attachments: inline-var-init-trunk-rev-764976-20090415.patch
>
>
> This limitation is listed here:
> http://cwiki.apache.org/confluence/display/ODExSITE/WS-BPEL+2.0+Specification+Compliance#WS-BPEL2.0SpecificationCompliance-Initialization

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.