You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "1996fanrui (via GitHub)" <gi...@apache.org> on 2023/06/29 09:26:49 UTC

[GitHub] [flink] 1996fanrui commented on a diff in pull request #22900: [FLINK-32478][connectors/common] Fix the bug that the shared thread pool causes the source alignment unit test to fail

1996fanrui commented on code in PR #22900:
URL: https://github.com/apache/flink/pull/22900#discussion_r1246374609


##########
flink-runtime/src/test/java/org/apache/flink/runtime/source/coordinator/SourceCoordinatorTestBase.java:
##########
@@ -215,7 +211,7 @@ Source<Integer, MockSourceSplit, Set<MockSourceSplit>> createMockSource() {
 
     protected SourceCoordinatorContext<MockSourceSplit> getNewSourceCoordinatorContext() {
         return new SourceCoordinatorContext<>(
-                coordinatorExecutor,
+                Executors.newScheduledThreadPool(1, coordinatorThreadFactory),
                 Executors.newScheduledThreadPool(
                         1,
                         new ExecutorThreadFactory(

Review Comment:
   Thanks for the review!
   
   Good catch! updated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org