[jira] [Commented] (HBASE-3852) ThriftServer leaks scanners

["Lars George (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13702266#comment-13702266 ] 

Lars George commented on HBASE-3852:
------------------------------------

Just ran across this in 0.89-fb:

{noformat}
commit b5f787b2836ce9750087392a4a3092f9a94f7360
Author: Mikhail Bautin <mb...@apache.org>
Date:   Tue Aug 28 21:15:39 2012 +0000

    [HBASE-6673] Clear up the scanner in the thrift server whenever these scanners failed to read data
    
    Author: liyintang
    
    Summary:
    We have run into some memory leak problem in the thrift server. It is caused either by the application client never closed the outstanding scanner or the thr
    
    Test Plan: not tested; will tested in dev cluster;
    
    Reviewers: kannan, kranganathan
    
    Reviewed By: kannan
    
    CC: arjen, hbase-eng@, davejwatson
    
    Differential Revision: https://phabricator.fb.com/D541137
    
    git-svn-id: https://svn.apache.org/repos/asf/hbase/branches/0.89-fb@1378350 13f79535-47bb-0310-9956-ffa450edef68
{noformat}

We should check what FB did there as well.
                
> ThriftServer leaks scanners
> ---------------------------
>
>                 Key: HBASE-3852
>                 URL: https://issues.apache.org/jira/browse/HBASE-3852
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Thrift
>    Affects Versions: 0.90.2
>            Reporter: Jean-Daniel Cryans
>            Assignee: Lars George
>         Attachments: 3852.txt, HBASE-3852-0.94.patch, thrift2-scanner.patch
>
>
> The scannerMap in ThriftServer relies on the user to clean it by closing the scanner. If that doesn't happen, the ResultScanner will stay in the thrift server's memory and if any pre-fetching was done, it will also start accumulating Results (with all their data).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira