[GitHub] [pinot] zhtaoxiang commented on a diff in pull request #9954: report minion task metadata last update time as metric

[GitBox <gi...@apache.org>]

zhtaoxiang commented on code in PR #9954:
URL: https://github.com/apache/pinot/pull/9954#discussion_r1048873343


##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ControllerGauge.java:
##########
@@ -52,6 +52,7 @@ public enum ControllerGauge implements AbstractMetrics.Gauge {
   OFFLINE_TABLE_COUNT("TableCount", true),
   DISABLED_TABLE_COUNT("TableCount", true),
   PERIODIC_TASK_NUM_TABLES_PROCESSED("PeriodicTaskNumTablesProcessed", true),
+  MINION_TASK_METADATA_LAST_UPDATE_TIME_MS("MinionTaskMetadataLastUpdateTimeMs", true),

Review Comment:
   Had an offline discussion with @snleee .
   
   Although it is fairly easy to perform calculation in PromQL (e.g., `now() - last update time` will be the time since the last update time), it may still be more straight forward if we use normalized metrics.
   
   Therefore, we will update this metric to be `the time since the last update time`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org