You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "PengningYang (via GitHub)" <gi...@apache.org> on 2025/06/05 10:54:55 UTC
[PR] optimize: Remove the unused defaultEventExecutorGroup initialization … [incubator-seata]
PengningYang opened a new pull request, #7414:
URL: https://github.com/apache/incubator-seata/pull/7414
…make it final
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<!-- Please make sure you have read and understood the contributing guidelines -->
- [ ] I have registered the PR [changes](../changes).
### Ⅰ. Describe what this PR did
Remove the unused defaultEventExecutorGroup initialization in NettyClientBootstrap and make it final
### Ⅱ. Does this pull request fix one issue?
<!-- If that, add "fixes #xxx" below in the next line, for example, fixes #97. -->
fixes #6132
### Ⅲ. Why don't you add test cases (unit test/integration test)?
### Ⅳ. Describe how to verify it
### Ⅴ. Special notes for reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: Remove the unused defaultEventExecutorGroup initialization … [incubator-seata]
Posted by "YongGoose (via GitHub)" <gi...@apache.org>.
YongGoose commented on code in PR #7414:
URL: https://github.com/apache/incubator-seata/pull/7414#discussion_r2129030736
##########
core/src/main/java/org/apache/seata/core/rpc/netty/NettyClientBootstrap.java:
##########
@@ -70,7 +69,7 @@ public class NettyClientBootstrap implements RemotingBootstrap {
private final NettyPoolKey.TransactionRole transactionRole;
private final EventLoopGroup eventLoopGroupWorker;
- private EventExecutorGroup defaultEventExecutorGroup;
+ private final EventExecutorGroup defaultEventExecutorGroup;
Review Comment:
+1
Since we’ve already confirmed in the issue that it’s no longer being used, I believe it’s best to remove it!
Splitting the work into two steps introduces unnecessary process, in my opinion.
Since both PMC members and committers will review the code and catch any unexpected issues, I don’t think there’s any need to worry.
I believe this is the purpose of the code review process. 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: Remove the unused defaultEventExecutorGroup [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on PR #7414:
URL: https://github.com/apache/incubator-seata/pull/7414#issuecomment-2947964242
Please send your DingTalk ID to jianbin@apache.org, and I will invite you to join the Seata developers group.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: Remove the unused defaultEventExecutorGroup initialization … [incubator-seata]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7414:
URL: https://github.com/apache/incubator-seata/pull/7414#issuecomment-2943937829
## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/7414?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 58.82%. Comparing base [(`f46065c`)](https://app.codecov.io/gh/apache/incubator-seata/commit/f46065cf3ddbc1744f341dee79b0fcf2eb70ab25?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`cea47cf`)](https://app.codecov.io/gh/apache/incubator-seata/commit/cea47cf745e9c70454bedb781f6b08c0806122ef?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 1 commits behind head on 2.x.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 2.x #7414 +/- ##
============================================
- Coverage 58.84% 58.82% -0.03%
Complexity 531 531
============================================
Files 1280 1280
Lines 46066 46062 -4
Branches 5557 5557
============================================
- Hits 27108 27096 -12
- Misses 16381 16391 +10
+ Partials 2577 2575 -2
```
| [Files with missing lines](https://app.codecov.io/gh/apache/incubator-seata/pull/7414?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...che/seata/core/rpc/netty/NettyClientBootstrap.java](https://app.codecov.io/gh/apache/incubator-seata/pull/7414?src=pr&el=tree&filepath=core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fcore%2Frpc%2Fnetty%2FNettyClientBootstrap.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvY29yZS9ycGMvbmV0dHkvTmV0dHlDbGllbnRCb290c3RyYXAuamF2YQ==) | `56.84% <ø> (-2.76%)` | :arrow_down: |
... and [7 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/7414/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
[](https://app.codecov.io/gh/apache/incubator-seata/pull/7414?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: Remove the unused defaultEventExecutorGroup initialization … [incubator-seata]
Posted by "YongGoose (via GitHub)" <gi...@apache.org>.
YongGoose commented on code in PR #7414:
URL: https://github.com/apache/incubator-seata/pull/7414#discussion_r2128671464
##########
core/src/main/java/org/apache/seata/core/rpc/netty/NettyClientBootstrap.java:
##########
@@ -70,7 +69,7 @@ public class NettyClientBootstrap implements RemotingBootstrap {
private final NettyPoolKey.TransactionRole transactionRole;
private final EventLoopGroup eventLoopGroupWorker;
- private EventExecutorGroup defaultEventExecutorGroup;
+ private final EventExecutorGroup defaultEventExecutorGroup;
Review Comment:
Was there any specific reason you decided not to remove `defaultEventExecutorGroup`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: Remove the unused defaultEventExecutorGroup initialization … [incubator-seata]
Posted by "PengningYang (via GitHub)" <gi...@apache.org>.
PengningYang commented on code in PR #7414:
URL: https://github.com/apache/incubator-seata/pull/7414#discussion_r2129251915
##########
core/src/main/java/org/apache/seata/core/rpc/netty/NettyClientBootstrap.java:
##########
@@ -70,7 +69,7 @@ public class NettyClientBootstrap implements RemotingBootstrap {
private final NettyPoolKey.TransactionRole transactionRole;
private final EventLoopGroup eventLoopGroupWorker;
- private EventExecutorGroup defaultEventExecutorGroup;
+ private final EventExecutorGroup defaultEventExecutorGroup;
Review Comment:
It has been completely removed. Please review it, experts.😊
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: Remove the unused defaultEventExecutorGroup initialization … [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on code in PR #7414:
URL: https://github.com/apache/incubator-seata/pull/7414#discussion_r2128966894
##########
core/src/main/java/org/apache/seata/core/rpc/netty/NettyClientBootstrap.java:
##########
@@ -70,7 +69,7 @@ public class NettyClientBootstrap implements RemotingBootstrap {
private final NettyPoolKey.TransactionRole transactionRole;
private final EventLoopGroup eventLoopGroupWorker;
- private EventExecutorGroup defaultEventExecutorGroup;
+ private final EventExecutorGroup defaultEventExecutorGroup;
Review Comment:
> > Was there any specific reason you decided not to remove `defaultEventExecutorGroup`?
>
> Considering the limited understanding of the original design, we will adhere to the principle of minimal changes and prioritize resolving the resource consumption issue with the DefaultEventExecutorGroup. If there are no plans to enable this feature in the future, I could also consider removing it.
I think it can be deleted now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: Remove the unused defaultEventExecutorGroup initialization … [incubator-seata]
Posted by "PengningYang (via GitHub)" <gi...@apache.org>.
PengningYang commented on code in PR #7414:
URL: https://github.com/apache/incubator-seata/pull/7414#discussion_r2128963811
##########
core/src/main/java/org/apache/seata/core/rpc/netty/NettyClientBootstrap.java:
##########
@@ -70,7 +69,7 @@ public class NettyClientBootstrap implements RemotingBootstrap {
private final NettyPoolKey.TransactionRole transactionRole;
private final EventLoopGroup eventLoopGroupWorker;
- private EventExecutorGroup defaultEventExecutorGroup;
+ private final EventExecutorGroup defaultEventExecutorGroup;
Review Comment:
> Was there any specific reason you decided not to remove `defaultEventExecutorGroup`?
Considering the limited understanding of the original design, we will adhere to the principle of minimal changes and prioritize resolving the resource consumption issue with the DefaultEventExecutorGroup. If there are no plans to enable this feature in the future, I could also consider removing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: Remove the unused defaultEventExecutorGroup [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes merged PR #7414:
URL: https://github.com/apache/incubator-seata/pull/7414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org