You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2020/09/16 09:28:42 UTC

[GitHub] [thrift] LiuXing-R commented on a change in pull request #2191: THRIFT-5237 Implement MAX_MESSAGE_SIZE and consolidate limits into a TConfiguration class(JAVA)

LiuXing-R commented on a change in pull request #2191:
URL: https://github.com/apache/thrift/pull/2191#discussion_r489297170



##########
File path: lib/java/src/org/apache/thrift/protocol/TBinaryProtocol.java
##########
@@ -279,6 +280,10 @@ public void readFieldEnd() throws TException {}
   @Override
   public TMap readMapBegin() throws TException {
     TMap map = new TMap(readByte(), readByte(), readI32());
+
+    //

Review comment:
       This is a redundant comment.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org