[GitHub] [flink-kubernetes-operator] jbusche commented on a diff in pull request #491: [FLINK-30456] Fixing Version and provider in OLM Description

[GitBox <gi...@apache.org>]

jbusche commented on code in PR #491:
URL: https://github.com/apache/flink-kubernetes-operator/pull/491#discussion_r1053777424


##########
tools/olm/docker-entry.sh:
##########
@@ -102,6 +96,10 @@ generate_olm_bundle() {
   yq ea -i ".spec.replaces = \"${PACKAGE_NAME}.v${PREVIOUS_BUNDLE_VERSION}\" | .spec.replaces style=\"\"" "${CSV_FILE}"
 
   yq ea -i "del(.subjects[0].namespace)" "${ROLE_BINDING}"
+
+  # Needed to replace description with new bundle values
+  sed -i "s/release-1.1/release-${BUNDLE_VERSION}/" "${CSV_FILE}"
+  sed -i "s/version: 1.2.0/version: ${BUNDLE_VERSION}/" "${CSV_FILE}"

Review Comment:
   That's a great idea @gyfora, I've added a RELEASE_VERSION placeholder and also I've added a few items under links, specifically:
       - name: Website
         url: https://flink.apache.org/
       - name: Documentation
         url: https://nightlies.apache.org/flink/flink-kubernetes-operator-docs-main/
       - name: Mailing list
         url: https://lists.apache.org/list.html?dev@flink.apache.org
       - name: Slack
         url: https://apache-flink.slack.com/join/shared_invite/zt-1llkzbgyt-K2nNGGg88rfsDGLkT09Qzg#/shared-invite/email
       - name: GitHub
         url: https://github.com/apache/flink-kubernetes-operator



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org