You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2022/06/22 00:53:35 UTC
[GitHub] [tinkerpop] xiazcy commented on a diff in pull request #1700: gremlin-go: support per-request arguments in bytecode
xiazcy commented on code in PR #1700:
URL: https://github.com/apache/tinkerpop/pull/1700#discussion_r903184326
##########
gremlin-go/driver/connection_test.go:
##########
@@ -1121,4 +1121,26 @@ func TestConnection(t *testing.T) {
// This routine.
assert.Equal(t, startCount, runtime.NumGoroutine())
})
+
+ t.Run("Test per-request arguments", func(t *testing.T) {
+ skipTestsIfNotEnabled(t, integrationTestSuiteName, testNoAuthEnable)
+
+ g := getTestGraph(t, testNoAuthUrl, testNoAuthAuthInfo, testNoAuthTlsConfig)
+ defer g.remoteConnection.Close()
+
+ _, err := g.With("evaluationTimeout", 10).Inject(1).SideEffect(&Lambda{"Thread.sleep(5000)", "gremlin-groovy"}).Next()
+ assert.NotNil(t, err)
+
+ _, err = g.With("evaluationTimeout", 10000).Inject(1).SideEffect(&Lambda{"Thread.sleep(5000)", "gremlin-groovy"}).Next()
+ assert.Nil(t, err)
+
+ _, err = g.With("evaluationTimeout", 10000).With("evaluationTimeout", 10).Inject(1).SideEffect(&Lambda{"Thread.sleep(5000)", "gremlin-groovy"}).Next()
+ assert.NotNil(t, err)
+
+ _, err = g.WithStrategies(OptionsStrategy(map[string]interface{}{"evaluationTimeout": 10})).Inject(1).SideEffect(&Lambda{"Thread.sleep(5000)", "gremlin-groovy"}).Next()
+ assert.NotNil(t, err)
+
+ _, err = g.WithStrategies(OptionsStrategy(map[string]interface{}{"evaluationTimeout": 10000})).Inject(1).SideEffect(&Lambda{"Thread.sleep(5000)", "gremlin-groovy"}).Next()
+ assert.Nil(t, err)
+ })
Review Comment:
Hi @jroimartin, just to make sure it's not due to the gremlin-go test server set up. Have you tried running the python script against the built gremlin server it self, instead of through docker compose? This would be running the file `gremlin-server/target/apache-tinkerpop-gremlin-server-3.5.4-SNAPSHOT-standalone/bin/gremlin-server.sh`, just starting the default server should be enough for the inject. Note the port will be different, `8182` instead of `45940`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org