You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "cxzl25 (via GitHub)" <gi...@apache.org> on 2023/04/14 10:36:25 UTC
[GitHub] [incubator-celeborn] cxzl25 opened a new pull request, #1430: [CELEBORN-525] Fix wrong parameter celeborn.push.buffer.size
cxzl25 opened a new pull request, #1430:
URL: https://github.com/apache/incubator-celeborn/pull/1430
### What changes were proposed in this pull request?
Replac `celeborn.push.buffer.size` with the correct parameter `celeborn.push.buffer.max.size`.
### Why are the changes needed?
The documentation is incorrect.
### Does this PR introduce _any_ user-facing change?
Users who read the documentation.
### How was this patch tested?
exist UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1430: [CELEBORN-525] Fix wrong parameter celeborn.push.buffer.size
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1430:
URL: https://github.com/apache/incubator-celeborn/pull/1430#issuecomment-1508317941
## [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1430?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1430](https://codecov.io/gh/apache/incubator-celeborn/pull/1430?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b82a8aa) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/fb7b311c898a46874b7168b73c3178e2d6210164?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fb7b311) will **increase** coverage by `0.28%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #1430 +/- ##
==========================================
+ Coverage 45.39% 45.67% +0.28%
==========================================
Files 165 165
Lines 10519 10519
Branches 1049 1049
==========================================
+ Hits 4774 4803 +29
+ Misses 5409 5383 -26
+ Partials 336 333 -3
```
[see 4 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-celeborn/pull/1430/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture merged pull request #1430: [CELEBORN-525] Fix wrong parameter celeborn.push.buffer.size
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture merged PR #1430:
URL: https://github.com/apache/incubator-celeborn/pull/1430
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org