You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "chungen0126 (via GitHub)" <gi...@apache.org> on 2024/08/12 13:34:55 UTC
[PR] HDDS-11282. Combine test setup for datanode upgrade unit tests [ozone]
chungen0126 opened a new pull request, #7063:
URL: https://github.com/apache/ozone/pull/7063
## What changes were proposed in this pull request?
TestDatanodeUpgradeToScmHA was the firstĀ unit test for handling of a specific datanode layout version. It works by starting just the minimal [SCM RPC server](https://github.com/apache/ozone/blob/6ed1e58dd598e4dbc8948e1c23ae67dd1e55104c/hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/upgrade/TestDatanodeUpgradeToScmHA.java#L561) and running datanodes without their [heartbeat thread](https://github.com/apache/ozone/blob/0c47b0f3bfaf39f1625295a2631c21276c48b9f8/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeStateMachine.java#L331). This allows most fo the functionality that would be present in a MiniOzoneCluster integration test but runs at the speed of a unit test.
The framework has since been adopted for testing other layout features in TestDatanodeUpgradeToSchemaV3 and TestDatanodeUpgradeToHBaseSupport, but the code has been copied each time. This Jira is to extract the common setup code so that it can be re-used to test datanode layout features in the future.
## What is the link to the Apache JIRA
[HDDS-11282](https://issues.apache.org/jira/browse/HDDS-11282)
## How was this patch tested?
CI:
https://github.com/chungen0126/ozone/actions/runs/10351405194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11282. Combine test setup for datanode upgrade unit tests [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #7063:
URL: https://github.com/apache/ozone/pull/7063
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11282. Combine test setup for datanode upgrade unit tests [ozone]
Posted by "jojochuang (via GitHub)" <gi...@apache.org>.
jojochuang commented on code in PR #7063:
URL: https://github.com/apache/ozone/pull/7063#discussion_r1717545634
##########
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/upgrade/TestDatanodeUpgradeToSchemaV3.java:
##########
@@ -314,10 +310,13 @@ public void testAddHddsVolumeAfterFinalize(boolean schemaV3Enabled)
public void testAddDbVolumeAfterFinalize(boolean schemaV3Enabled)
throws Exception {
initTests(schemaV3Enabled);
- startScmServer();
- addHddsVolume();
+ scmRpcServer = SCMTestUtils.startScmRpcServer(conf,
+ new ScmTestMock(CLUSTER_ID), address, 10);
+ UpgradeTestHelper.addHddsVolume(conf, tempFolder);
- startPreFinalizedDatanode();
+ //startPreFinalizedDatanode();
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11282. Combine test setup for datanode upgrade unit tests [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #7063:
URL: https://github.com/apache/ozone/pull/7063#issuecomment-2290961134
Thanks @chungen0126 for the patch, @jojochuang for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org