You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/03/25 12:37:21 UTC
[GitHub] [kylin] ChangjiGuo opened a new pull request #1168: KYLIN-4433 use
cube config when uhc step enabled
ChangjiGuo opened a new pull request #1168: KYLIN-4433 use cube config when uhc step enabled
URL: https://github.com/apache/kylin/pull/1168
issue: https://issues.apache.org/jira/browse/KYLIN-4433
If the system level configuration is used, it will cause the dictionary to be built repeatedly, so I think the configuration of the cube should be used here.
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] coveralls commented on issue #1168: KYLIN-4433 use cube
config when uhc step enabled
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1168: KYLIN-4433 use cube config when uhc step enabled
URL: https://github.com/apache/kylin/pull/1168#issuecomment-603831387
## Pull Request Test Coverage Report for [Build 5785](https://coveralls.io/builds/29606127)
* **0** of **2** **(0.0%)** changed or added relevant lines in **1** file are covered.
* **1** unchanged line in **1** file lost coverage.
* Overall coverage increased (+**0.003%**) to **27.523%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/CreateDictionaryJob.java](https://coveralls.io/builds/29606127/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FCreateDictionaryJob.java#L85) | 0 | 2 | 0.0%
<!-- | **Total:** | **0** | **2** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/29606127/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% |
<!-- | **Total:** | **1** | | -->
| Totals | [](https://coveralls.io/builds/29606127) |
| :-- | --: |
| Change from base [Build 5776](https://coveralls.io/builds/29463823): | 0.003% |
| Covered Lines: | 24306 |
| Relevant Lines: | 88310 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] shaofengshi commented on issue #1168: KYLIN-4433 use cube
config when uhc step enabled
Posted by GitBox <gi...@apache.org>.
shaofengshi commented on issue #1168: KYLIN-4433 use cube config when uhc step enabled
URL: https://github.com/apache/kylin/pull/1168#issuecomment-604260059
Thank you Changji! Next time if you can add the JIRA id in git commit message, that would be great! like "KYLIN-4433 use cube config when uhc step enabled"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] shaofengshi merged pull request #1168: KYLIN-4433 use cube
config when uhc step enabled
Posted by GitBox <gi...@apache.org>.
shaofengshi merged pull request #1168: KYLIN-4433 use cube config when uhc step enabled
URL: https://github.com/apache/kylin/pull/1168
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] ChangjiGuo commented on issue #1168: KYLIN-4433 use cube
config when uhc step enabled
Posted by GitBox <gi...@apache.org>.
ChangjiGuo commented on issue #1168: KYLIN-4433 use cube config when uhc step enabled
URL: https://github.com/apache/kylin/pull/1168#issuecomment-604263088
@shaofengshi ok, next time i will pay attention. I am very glad to contribute to the community!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services