You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by cu...@apache.org on 2006/09/12 20:59:44 UTC
svn commit: r442673 - in /lucene/hadoop/trunk: CHANGES.txt
src/java/org/apache/hadoop/mapred/JobInProgress.java
src/test/org/apache/hadoop/mapred/TestMiniMRWithDFS.java
Author: cutting
Date: Tue Sep 12 11:59:44 2006
New Revision: 442673
URL: http://svn.apache.org/viewvc?view=rev&rev=442673
Log:
HADOOP-523. Fix a NullPointerException when TextInputFormat is explicitly specified. Contributed by Owen.
Modified:
lucene/hadoop/trunk/CHANGES.txt
lucene/hadoop/trunk/src/java/org/apache/hadoop/mapred/JobInProgress.java
lucene/hadoop/trunk/src/test/org/apache/hadoop/mapred/TestMiniMRWithDFS.java
Modified: lucene/hadoop/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/lucene/hadoop/trunk/CHANGES.txt?view=diff&rev=442673&r1=442672&r2=442673
==============================================================================
--- lucene/hadoop/trunk/CHANGES.txt (original)
+++ lucene/hadoop/trunk/CHANGES.txt Tue Sep 12 11:59:44 2006
@@ -6,6 +6,10 @@
1. HADOOP-520. Fix a bug in libhdfs, where write failures were not
correctly returning error codes. (Arun C Murthy via cutting)
+ 2. HADOOP-523. Fix a NullPointerException when TextInputFormat is
+ explicitly specified. Also add a test case for this.
+ (omalley via cutting)
+
Release 0.6.0 - 2006-08-08
Modified: lucene/hadoop/trunk/src/java/org/apache/hadoop/mapred/JobInProgress.java
URL: http://svn.apache.org/viewvc/lucene/hadoop/trunk/src/java/org/apache/hadoop/mapred/JobInProgress.java?view=diff&rev=442673&r1=442672&r2=442673
==============================================================================
--- lucene/hadoop/trunk/src/java/org/apache/hadoop/mapred/JobInProgress.java (original)
+++ lucene/hadoop/trunk/src/java/org/apache/hadoop/mapred/JobInProgress.java Tue Sep 12 11:59:44 2006
@@ -109,24 +109,15 @@
//
String jobFile = profile.getJobFile();
- JobConf jd = new JobConf(localJobFile);
FileSystem fs = FileSystem.get(conf);
- String ifClassName = jd.get("mapred.input.format.class");
- InputFormat inputFormat;
- if (ifClassName != null && localJarFile != null) {
- try {
+ if (localJarFile != null) {
ClassLoader loader =
new URLClassLoader(new URL[]{ localFs.pathToFile(localJarFile).toURL() });
- Class inputFormatClass = Class.forName(ifClassName, true, loader);
- inputFormat = (InputFormat)inputFormatClass.newInstance();
- } catch (Exception e) {
- throw new IOException(e.toString());
- }
- } else {
- inputFormat = jd.getInputFormat();
+ conf.setClassLoader(loader);
}
+ InputFormat inputFormat = conf.getInputFormat();
- FileSplit[] splits = inputFormat.getSplits(fs, jd, numMapTasks);
+ FileSplit[] splits = inputFormat.getSplits(fs, conf, numMapTasks);
//
// sort splits by decreasing length, to reduce job's tail
Modified: lucene/hadoop/trunk/src/test/org/apache/hadoop/mapred/TestMiniMRWithDFS.java
URL: http://svn.apache.org/viewvc/lucene/hadoop/trunk/src/test/org/apache/hadoop/mapred/TestMiniMRWithDFS.java?view=diff&rev=442673&r1=442672&r2=442673
==============================================================================
--- lucene/hadoop/trunk/src/test/org/apache/hadoop/mapred/TestMiniMRWithDFS.java (original)
+++ lucene/hadoop/trunk/src/test/org/apache/hadoop/mapred/TestMiniMRWithDFS.java Tue Sep 12 11:59:44 2006
@@ -56,6 +56,7 @@
conf.set("fs.default.name", fileSys);
conf.set("mapred.job.tracker", jobTracker);
conf.setJobName("wordcount");
+ conf.setInputFormat(TextInputFormat.class);
// the keys are words (strings)
conf.setOutputKeyClass(Text.class);