You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@avro.apache.org by GitBox <gi...@apache.org> on 2021/12/11 20:56:24 UTC
[GitHub] [avro] opwvhk commented on pull request #1411: AVRO-3257: IDL support for nullable types
opwvhk commented on pull request #1411:
URL: https://github.com/apache/avro/pull/1411#issuecomment-991781519
There are now still three PRs open (this one, #1377 and #1412; all by me) that touch the file `idl.jj`, and that slightly conflict with each other.
I suggest that if all three meet approval, I merge them all into this PR. Is that a good idea?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [GitHub] [avro] opwvhk commented on pull request #1411: AVRO-3257: IDL support for nullable types
Posted by Martin Grigorov <mg...@apache.org>.
I think it would be better if you leave them three and be merged one by one.
The benefits are:
* better Git history
* easier to identify regressions in smaller diffs and revert the
problematic one if needed
My 2c.
On Sat, Dec 11, 2021, 22:56 GitBox <gi...@apache.org> wrote:
>
> opwvhk commented on pull request #1411:
> URL: https://github.com/apache/avro/pull/1411#issuecomment-991781519
>
>
> There are now still three PRs open (this one, #1377 and #1412; all by
> me) that touch the file `idl.jj`, and that slightly conflict with each
> other.
>
> I suggest that if all three meet approval, I merge them all into this
> PR. Is that a good idea?
>
>
> --
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
>
>
Re: [GitHub] [avro] opwvhk commented on pull request #1411: AVRO-3257: IDL support for nullable types
Posted by Martin Grigorov <mg...@apache.org>.
I think it would be better if you leave them three and be merged one by one.
The benefits are:
* better Git history
* easier to identify regressions in smaller diffs and revert the
problematic one if needed
My 2c.
On Sat, Dec 11, 2021, 22:56 GitBox <gi...@apache.org> wrote:
>
> opwvhk commented on pull request #1411:
> URL: https://github.com/apache/avro/pull/1411#issuecomment-991781519
>
>
> There are now still three PRs open (this one, #1377 and #1412; all by
> me) that touch the file `idl.jj`, and that slightly conflict with each
> other.
>
> I suggest that if all three meet approval, I merge them all into this
> PR. Is that a good idea?
>
>
> --
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
>
>