You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "xy2953396112 (via GitHub)" <gi...@apache.org> on 2025/10/12 07:25:30 UTC
[PR] [CELEBORN-2172] S3 and OSS storage select appropriate fileMeta type b… [celeborn]
xy2953396112 opened a new pull request, #3502:
URL: https://github.com/apache/celeborn/pull/3502
…ased on actual partition type
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
`S3` and `OSS` storage select appropriate fileMeta type based on actual partition type
### Why are the changes needed?
In the `createDiskFile` method, when handling the `S3` and `OSS` storage types, `ReduceFileMeta` is hard-coded for use regardless of whether the partition type is `MAP` or `REDUCE`. The appropriate FileMeta type is not selected based on the actual partition type, which is inconsistent with the logic for handling `local disk` and `HDFS` storage types.
### Does this PR introduce _any_ user-facing change?
NO
### How was this patch tested?
CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2172] S3 and OSS storage select appropriate fileMeta type b… [celeborn]
Posted by "xy2953396112 (via GitHub)" <gi...@apache.org>.
xy2953396112 commented on PR #3502:
URL: https://github.com/apache/celeborn/pull/3502#issuecomment-3395665745
> @xy2953396112, MapParttion does not support S3 and OSS, therefore this change is unnecessary.
ok, i will close this pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2172] S3 and OSS storage select appropriate fileMeta type b… [celeborn]
Posted by "xy2953396112 (via GitHub)" <gi...@apache.org>.
xy2953396112 closed pull request #3502: [CELEBORN-2172] S3 and OSS storage select appropriate fileMeta type b…
URL: https://github.com/apache/celeborn/pull/3502
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2172] S3 and OSS storage select appropriate fileMeta type b… [celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on PR #3502:
URL: https://github.com/apache/celeborn/pull/3502#issuecomment-3395656921
@xy2953396112, MapParttion does not support S3 and OSS, therefore this change is unnecessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org