[GitHub] [pulsar] jerrypeng commented on a change in pull request #4223: Make Function submission checks optional

[GitBox <gi...@apache.org>]

jerrypeng commented on a change in pull request #4223: Make Function submission checks optional
URL: https://github.com/apache/pulsar/pull/4223#discussion_r281383566
 
 

 ##########
 File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/source/PulsarSource.java
 ##########
 @@ -145,9 +158,42 @@ public void close() throws Exception {
     @VisibleForTesting
     Map<String, ConsumerConfig<T>> setupConsumerConfigs() throws ClassNotFoundException {
         Map<String, ConsumerConfig<T>> configs = new TreeMap<>();
-
-        Class<?> typeArg = Reflections.loadClass(this.pulsarSourceConfig.getTypeClassName(),
-                Thread.currentThread().getContextClassLoader());
+        Class<?> typeArg;
 
 Review comment:
   Is this change related to "Make Function submission checks optional"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services