[GitHub] erisu commented on a change in pull request #56: Test framework consistency

[GitBox <gi...@apache.org>]

erisu commented on a change in pull request #56: Test framework consistency
URL: https://github.com/apache/cordova-osx/pull/56#discussion_r216991838
 
 

 ##########
 File path: package.json
 ##########
 @@ -41,7 +41,7 @@
     "eslint-plugin-node": "^5.0.0",
     "eslint-plugin-promise": "^3.5.0",
     "eslint-plugin-standard": "^3.0.1",
-    "jasmine": "^2.6.0",
+    "jasmine": "^3.1.0",
 
 Review comment:
   Yes, there is an issue with 3.2.0 but not all repos show the problem. This repo worked OK with 3.2.0 when I tested.
   
   *Hopefully my package-lock.json was deleted.*🤣
   
   The other repos will not be able to upgrade until the issue is fixed. Or we have to identify another way around for those tests. Being either changes in the test or code itself. Depending where the issues originate and what is required to work around their change.
   
   Anyways, I can either
   1. Bump to `^3.2.0` as your preference. 
   2. Or change to `~3.1.0` to match other repos.
   
   There will always be confusion for those who don't understand `^`. Even if set to `^3.2.0`, it is possible they release a minor or patch revision and somebody decided to delete the package-lock.json to do a fresh install. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org