You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Martijn Visser (Jira)" <ji...@apache.org> on 2022/01/03 07:15:00 UTC
[jira] [Commented] (FLINK-18717) reuse MiniCluster in table integration test class ?
[ https://issues.apache.org/jira/browse/FLINK-18717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17467810#comment-17467810 ]
Martijn Visser commented on FLINK-18717:
----------------------------------------
[~godfreyhe] Is still is a valid issue?
> reuse MiniCluster in table integration test class ?
> ----------------------------------------------------
>
> Key: FLINK-18717
> URL: https://issues.apache.org/jira/browse/FLINK-18717
> Project: Flink
> Issue Type: Improvement
> Components: Table SQL / Planner
> Affects Versions: 1.11.0
> Reporter: godfrey he
> Priority: Minor
> Labels: auto-deprioritized-major, stale-minor
>
> before 1.11, {{MiniCluster}} can be reused in each integration test class. (see TestStreamEnvironment#setAsContext)
> In 1.11, after we correct the execution behavior of TableEnvironment, StreamTableEnvironment and BatchTableEnvironment (see [FLINK-16363|https://issues.apache.org/jira/browse/FLINK-16363], [FLINK-17126|https://issues.apache.org/jira/browse/FLINK-17126]), MiniCluster will be created for each test case even in same test class (see {{org.apache.flink.client.deployment.executors.LocalExecutor}}). It's better we can reuse {{MiniCluster}} like before. One approach is we provide a new kind of MiniCluster factory (such as: SessionMiniClusterFactory) instead of using {{PerJobMiniClusterFactory}}. WDYT ?
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)