You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Brian Wickman <wi...@apache.org> on 2014/07/23 22:51:12 UTC
Review Request 23863: AURORA-587: Example ServerSet Announcer implementation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23863/
-----------------------------------------------------------
Review request for Aurora, Kevin Sweeney and Bill Farner.
Bugs: AURORA-587
https://issues.apache.org/jira/browse/AURORA-587
Repository: aurora
Description
-------
This is an exemplar ServerSet Announcer implementation in apache.aurora.executor.common. Open to suggestions about wiring up -- right now it is enabled via command line flags, but we don't have prior art for invoking the executor with command line flags (I think the scheduler just takes -thermos_executor_path, which is fine if we promote the pattern of writing a thin shell wrapper around the executor.pex.) We can alternately switch to entry_points style a la AURORA-216 prior to submitting this, so that people just need to pip install as a plugin, but would require a separate review. Open to ideas.
Diffs
-----
src/main/python/apache/aurora/executor/bin/BUILD 6b3f620a1d1b004c6be9965f6dceb7c8913a8e4c
src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 198f2f6feb3782a98c3784297599ad218b54209e
src/main/python/apache/aurora/executor/common/BUILD d0ff6fbf594663cd12ffb4b6d3f330e3a1ac123c
src/main/python/apache/aurora/executor/common/announcer.py PRE-CREATION
src/test/python/apache/aurora/executor/common/BUILD 8b54e910a671cde0265ade3155cb495c6314347b
src/test/python/apache/aurora/executor/common/test_announcer.py PRE-CREATION
Diff: https://reviews.apache.org/r/23863/diff/
Testing
-------
./pants src/test/python/apache/aurora/executor/common:announcer -v
Thanks,
Brian Wickman
Re: Review Request 23863: AURORA-587: Example ServerSet Announcer
implementation
Posted by Bill Farner <wf...@apache.org>.
> On July 23, 2014, 11:12 p.m., Bill Farner wrote:
> > Can you summarize the reason(s) it's not wired in by default?
>
> Brian Wickman wrote:
> The main issue is that the --announcer-ensemble flag is required if the announcer is enabled. This means that the executor will stop working for you by default even if you have no interest in announcing. Opt-in seems like a more sane option for the casual user.
Seems reasonable. Are you up for demonstrating the shim script approach in the vagrant example?
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23863/#review48567
-----------------------------------------------------------
On July 23, 2014, 8:51 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23863/
> -----------------------------------------------------------
>
> (Updated July 23, 2014, 8:51 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-587
> https://issues.apache.org/jira/browse/AURORA-587
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is an exemplar ServerSet Announcer implementation in apache.aurora.executor.common. Open to suggestions about wiring up -- right now it is enabled via command line flags, but we don't have prior art for invoking the executor with command line flags (I think the scheduler just takes -thermos_executor_path, which is fine if we promote the pattern of writing a thin shell wrapper around the executor.pex.) We can alternately switch to entry_points style a la AURORA-216 prior to submitting this, so that people just need to pip install as a plugin, but would require a separate review. Open to ideas.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/bin/BUILD 6b3f620a1d1b004c6be9965f6dceb7c8913a8e4c
> src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 198f2f6feb3782a98c3784297599ad218b54209e
> src/main/python/apache/aurora/executor/common/BUILD d0ff6fbf594663cd12ffb4b6d3f330e3a1ac123c
> src/main/python/apache/aurora/executor/common/announcer.py PRE-CREATION
> src/test/python/apache/aurora/executor/common/BUILD 8b54e910a671cde0265ade3155cb495c6314347b
> src/test/python/apache/aurora/executor/common/test_announcer.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23863/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/executor/common:announcer -v
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 23863: AURORA-587: Example ServerSet Announcer
implementation
Posted by Brian Wickman <wi...@apache.org>.
> On July 23, 2014, 11:12 p.m., Bill Farner wrote:
> > Can you summarize the reason(s) it's not wired in by default?
The main issue is that the --announcer-ensemble flag is required if the announcer is enabled. This means that the executor will stop working for you by default even if you have no interest in announcing. Opt-in seems like a more sane option for the casual user.
- Brian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23863/#review48567
-----------------------------------------------------------
On July 23, 2014, 8:51 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23863/
> -----------------------------------------------------------
>
> (Updated July 23, 2014, 8:51 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-587
> https://issues.apache.org/jira/browse/AURORA-587
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is an exemplar ServerSet Announcer implementation in apache.aurora.executor.common. Open to suggestions about wiring up -- right now it is enabled via command line flags, but we don't have prior art for invoking the executor with command line flags (I think the scheduler just takes -thermos_executor_path, which is fine if we promote the pattern of writing a thin shell wrapper around the executor.pex.) We can alternately switch to entry_points style a la AURORA-216 prior to submitting this, so that people just need to pip install as a plugin, but would require a separate review. Open to ideas.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/bin/BUILD 6b3f620a1d1b004c6be9965f6dceb7c8913a8e4c
> src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 198f2f6feb3782a98c3784297599ad218b54209e
> src/main/python/apache/aurora/executor/common/BUILD d0ff6fbf594663cd12ffb4b6d3f330e3a1ac123c
> src/main/python/apache/aurora/executor/common/announcer.py PRE-CREATION
> src/test/python/apache/aurora/executor/common/BUILD 8b54e910a671cde0265ade3155cb495c6314347b
> src/test/python/apache/aurora/executor/common/test_announcer.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23863/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/executor/common:announcer -v
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 23863: AURORA-587: Example ServerSet Announcer
implementation
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23863/#review48567
-----------------------------------------------------------
Can you summarize the reason(s) it's not wired in by default?
- Bill Farner
On July 23, 2014, 8:51 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23863/
> -----------------------------------------------------------
>
> (Updated July 23, 2014, 8:51 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-587
> https://issues.apache.org/jira/browse/AURORA-587
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is an exemplar ServerSet Announcer implementation in apache.aurora.executor.common. Open to suggestions about wiring up -- right now it is enabled via command line flags, but we don't have prior art for invoking the executor with command line flags (I think the scheduler just takes -thermos_executor_path, which is fine if we promote the pattern of writing a thin shell wrapper around the executor.pex.) We can alternately switch to entry_points style a la AURORA-216 prior to submitting this, so that people just need to pip install as a plugin, but would require a separate review. Open to ideas.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/bin/BUILD 6b3f620a1d1b004c6be9965f6dceb7c8913a8e4c
> src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 198f2f6feb3782a98c3784297599ad218b54209e
> src/main/python/apache/aurora/executor/common/BUILD d0ff6fbf594663cd12ffb4b6d3f330e3a1ac123c
> src/main/python/apache/aurora/executor/common/announcer.py PRE-CREATION
> src/test/python/apache/aurora/executor/common/BUILD 8b54e910a671cde0265ade3155cb495c6314347b
> src/test/python/apache/aurora/executor/common/test_announcer.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23863/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/executor/common:announcer -v
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 23863: AURORA-587: Example ServerSet Announcer
implementation
Posted by Kevin Sweeney <ke...@apache.org>.
> On July 23, 2014, 5:40 p.m., Kevin Sweeney wrote:
> > Good start, thanks for getting this out here. Any thoughts on wiring up executor command-line flags as a scheduler command-line flag? Should make this relatively easy to wire up, demo, and integration test. Worth a followup review?
>
> Bill Farner wrote:
> I like Brian's suggestion to use a shim script instead. My sense is that this gives the end-user the most flexibility.
We should be mindful to preserve flexibility in executor deploys. Right now you can (for example) supply a url to the scheduler as the executor_path and mesos will fetch it for you. For public clouds it's feasible there's a well-known stable executor url that needs some (global per-cluster) configuration (zk ensemble for example). Letting the user configure that on the scheduler command-line frees them from needing to arrange for a special executor shim script somewhere every node in the cluster can see.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23863/#review48593
-----------------------------------------------------------
On July 23, 2014, 1:51 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23863/
> -----------------------------------------------------------
>
> (Updated July 23, 2014, 1:51 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-587
> https://issues.apache.org/jira/browse/AURORA-587
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is an exemplar ServerSet Announcer implementation in apache.aurora.executor.common. Open to suggestions about wiring up -- right now it is enabled via command line flags, but we don't have prior art for invoking the executor with command line flags (I think the scheduler just takes -thermos_executor_path, which is fine if we promote the pattern of writing a thin shell wrapper around the executor.pex.) We can alternately switch to entry_points style a la AURORA-216 prior to submitting this, so that people just need to pip install as a plugin, but would require a separate review. Open to ideas.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/bin/BUILD 6b3f620a1d1b004c6be9965f6dceb7c8913a8e4c
> src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 198f2f6feb3782a98c3784297599ad218b54209e
> src/main/python/apache/aurora/executor/common/BUILD d0ff6fbf594663cd12ffb4b6d3f330e3a1ac123c
> src/main/python/apache/aurora/executor/common/announcer.py PRE-CREATION
> src/test/python/apache/aurora/executor/common/BUILD 8b54e910a671cde0265ade3155cb495c6314347b
> src/test/python/apache/aurora/executor/common/test_announcer.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23863/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/executor/common:announcer -v
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 23863: AURORA-587: Example ServerSet Announcer
implementation
Posted by Bill Farner <wf...@apache.org>.
> On July 24, 2014, 12:40 a.m., Kevin Sweeney wrote:
> > Good start, thanks for getting this out here. Any thoughts on wiring up executor command-line flags as a scheduler command-line flag? Should make this relatively easy to wire up, demo, and integration test. Worth a followup review?
I like Brian's suggestion to use a shim script instead. My sense is that this gives the end-user the most flexibility.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23863/#review48593
-----------------------------------------------------------
On July 23, 2014, 8:51 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23863/
> -----------------------------------------------------------
>
> (Updated July 23, 2014, 8:51 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-587
> https://issues.apache.org/jira/browse/AURORA-587
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is an exemplar ServerSet Announcer implementation in apache.aurora.executor.common. Open to suggestions about wiring up -- right now it is enabled via command line flags, but we don't have prior art for invoking the executor with command line flags (I think the scheduler just takes -thermos_executor_path, which is fine if we promote the pattern of writing a thin shell wrapper around the executor.pex.) We can alternately switch to entry_points style a la AURORA-216 prior to submitting this, so that people just need to pip install as a plugin, but would require a separate review. Open to ideas.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/bin/BUILD 6b3f620a1d1b004c6be9965f6dceb7c8913a8e4c
> src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 198f2f6feb3782a98c3784297599ad218b54209e
> src/main/python/apache/aurora/executor/common/BUILD d0ff6fbf594663cd12ffb4b6d3f330e3a1ac123c
> src/main/python/apache/aurora/executor/common/announcer.py PRE-CREATION
> src/test/python/apache/aurora/executor/common/BUILD 8b54e910a671cde0265ade3155cb495c6314347b
> src/test/python/apache/aurora/executor/common/test_announcer.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23863/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/executor/common:announcer -v
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 23863: AURORA-587: Example ServerSet Announcer
implementation
Posted by Bill Farner <wf...@apache.org>.
> On July 24, 2014, 12:40 a.m., Kevin Sweeney wrote:
> > Good start, thanks for getting this out here. Any thoughts on wiring up executor command-line flags as a scheduler command-line flag? Should make this relatively easy to wire up, demo, and integration test. Worth a followup review?
>
> Bill Farner wrote:
> I like Brian's suggestion to use a shim script instead. My sense is that this gives the end-user the most flexibility.
>
> Kevin Sweeney wrote:
> We should be mindful to preserve flexibility in executor deploys. Right now you can (for example) supply a url to the scheduler as the executor_path and mesos will fetch it for you. For public clouds it's feasible there's a well-known stable executor url that needs some (global per-cluster) configuration (zk ensemble for example). Letting the user configure that on the scheduler command-line frees them from needing to arrange for a special executor shim script somewhere every node in the cluster can see.
This is also a good point.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23863/#review48593
-----------------------------------------------------------
On July 23, 2014, 8:51 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23863/
> -----------------------------------------------------------
>
> (Updated July 23, 2014, 8:51 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-587
> https://issues.apache.org/jira/browse/AURORA-587
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is an exemplar ServerSet Announcer implementation in apache.aurora.executor.common. Open to suggestions about wiring up -- right now it is enabled via command line flags, but we don't have prior art for invoking the executor with command line flags (I think the scheduler just takes -thermos_executor_path, which is fine if we promote the pattern of writing a thin shell wrapper around the executor.pex.) We can alternately switch to entry_points style a la AURORA-216 prior to submitting this, so that people just need to pip install as a plugin, but would require a separate review. Open to ideas.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/bin/BUILD 6b3f620a1d1b004c6be9965f6dceb7c8913a8e4c
> src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 198f2f6feb3782a98c3784297599ad218b54209e
> src/main/python/apache/aurora/executor/common/BUILD d0ff6fbf594663cd12ffb4b6d3f330e3a1ac123c
> src/main/python/apache/aurora/executor/common/announcer.py PRE-CREATION
> src/test/python/apache/aurora/executor/common/BUILD 8b54e910a671cde0265ade3155cb495c6314347b
> src/test/python/apache/aurora/executor/common/test_announcer.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23863/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/executor/common:announcer -v
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 23863: AURORA-587: Example ServerSet Announcer
implementation
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23863/#review48593
-----------------------------------------------------------
Ship it!
Good start, thanks for getting this out here. Any thoughts on wiring up executor command-line flags as a scheduler command-line flag? Should make this relatively easy to wire up, demo, and integration test. Worth a followup review?
src/main/python/apache/aurora/executor/common/announcer.py
<https://reviews.apache.org/r/23863/#comment85302>
Drop Twitter?
- Kevin Sweeney
On July 23, 2014, 1:51 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23863/
> -----------------------------------------------------------
>
> (Updated July 23, 2014, 1:51 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-587
> https://issues.apache.org/jira/browse/AURORA-587
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is an exemplar ServerSet Announcer implementation in apache.aurora.executor.common. Open to suggestions about wiring up -- right now it is enabled via command line flags, but we don't have prior art for invoking the executor with command line flags (I think the scheduler just takes -thermos_executor_path, which is fine if we promote the pattern of writing a thin shell wrapper around the executor.pex.) We can alternately switch to entry_points style a la AURORA-216 prior to submitting this, so that people just need to pip install as a plugin, but would require a separate review. Open to ideas.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/bin/BUILD 6b3f620a1d1b004c6be9965f6dceb7c8913a8e4c
> src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 198f2f6feb3782a98c3784297599ad218b54209e
> src/main/python/apache/aurora/executor/common/BUILD d0ff6fbf594663cd12ffb4b6d3f330e3a1ac123c
> src/main/python/apache/aurora/executor/common/announcer.py PRE-CREATION
> src/test/python/apache/aurora/executor/common/BUILD 8b54e910a671cde0265ade3155cb495c6314347b
> src/test/python/apache/aurora/executor/common/test_announcer.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23863/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/executor/common:announcer -v
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 23863: AURORA-587: Example ServerSet Announcer
implementation
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23863/#review49501
-----------------------------------------------------------
sorry for the radio silence on this -- vacation + other work. will send out an updated review once the e2e finishes.
- Brian Wickman
On July 24, 2014, 10:32 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23863/
> -----------------------------------------------------------
>
> (Updated July 24, 2014, 10:32 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-587
> https://issues.apache.org/jira/browse/AURORA-587
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is an exemplar ServerSet Announcer implementation in apache.aurora.executor.common. Open to suggestions about wiring up -- right now it is enabled via command line flags, but we don't have prior art for invoking the executor with command line flags (I think the scheduler just takes -thermos_executor_path, which is fine if we promote the pattern of writing a thin shell wrapper around the executor.pex.) We can alternately switch to entry_points style a la AURORA-216 prior to submitting this, so that people just need to pip install as a plugin, but would require a separate review. Open to ideas.
>
>
> Diffs
> -----
>
> examples/vagrant/aurorabuild.sh 9f604d36cc083c3679d0c4c8821d74dca64a1805
> examples/vagrant/upstart/aurora-scheduler.conf 05b2f2662311cd4859bfe57df6eee7b431c474eb
> src/main/python/apache/aurora/executor/bin/BUILD 6b3f620a1d1b004c6be9965f6dceb7c8913a8e4c
> src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 198f2f6feb3782a98c3784297599ad218b54209e
> src/main/python/apache/aurora/executor/common/BUILD d0ff6fbf594663cd12ffb4b6d3f330e3a1ac123c
> src/main/python/apache/aurora/executor/common/announcer.py PRE-CREATION
> src/test/python/apache/aurora/executor/common/BUILD 8b54e910a671cde0265ade3155cb495c6314347b
> src/test/python/apache/aurora/executor/common/test_announcer.py PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora dcf61033743317a51dd2f77e8d254c4781cb6a93
> src/test/sh/org/apache/aurora/e2e/test_common.sh def823b2f1f4bc67304221efa06e0e561d9bf521
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 9c5652829ac306dda5f7e95e164c85713e18988f
> src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 2af256d65850bd861111279dff4b5c53f234cf7a
>
> Diff: https://reviews.apache.org/r/23863/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/executor/common:announcer -v
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 23863: AURORA-587: Example ServerSet Announcer
implementation
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23863/#review49517
-----------------------------------------------------------
Neglected to catch this in previous rounds, but can you add a snippet about this in docs/user-guide.md?
src/test/sh/org/apache/aurora/e2e/validate_serverset.py
<https://reviews.apache.org/r/23863/#comment86594>
comment cut off?
- Bill Farner
On Aug. 4, 2014, 9:14 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23863/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2014, 9:14 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-587
> https://issues.apache.org/jira/browse/AURORA-587
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is an exemplar ServerSet Announcer implementation in apache.aurora.executor.common. Open to suggestions about wiring up -- right now it is enabled via command line flags, but we don't have prior art for invoking the executor with command line flags (I think the scheduler just takes -thermos_executor_path, which is fine if we promote the pattern of writing a thin shell wrapper around the executor.pex.) We can alternately switch to entry_points style a la AURORA-216 prior to submitting this, so that people just need to pip install as a plugin, but would require a separate review. Open to ideas.
>
>
> Diffs
> -----
>
> examples/vagrant/aurorabuild.sh 9f604d36cc083c3679d0c4c8821d74dca64a1805
> examples/vagrant/upstart/aurora-scheduler.conf 05b2f2662311cd4859bfe57df6eee7b431c474eb
> src/main/python/apache/aurora/executor/bin/BUILD 6b3f620a1d1b004c6be9965f6dceb7c8913a8e4c
> src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 198f2f6feb3782a98c3784297599ad218b54209e
> src/main/python/apache/aurora/executor/common/BUILD d0ff6fbf594663cd12ffb4b6d3f330e3a1ac123c
> src/main/python/apache/aurora/executor/common/announcer.py PRE-CREATION
> src/test/python/apache/aurora/client/api/test_scheduler_client.py e1f1a95d1757d584056fe6be9c98049444f6a75b
> src/test/python/apache/aurora/executor/common/BUILD 8b54e910a671cde0265ade3155cb495c6314347b
> src/test/python/apache/aurora/executor/common/test_announcer.py PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora 9dfc65193f655794a92f64631c244fbf890618a8
> src/test/sh/org/apache/aurora/e2e/test_common.sh def823b2f1f4bc67304221efa06e0e561d9bf521
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 3529c184e9ba0c7577baba40e9ad501b02f4c037
> src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh a3f530f26afe7a4472e431c4dfbff175f9b7e53c
> src/test/sh/org/apache/aurora/e2e/validate_serverset.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23863/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/executor/common:announcer -v
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 23863: AURORA-587: Example ServerSet Announcer
implementation
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23863/#review49527
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On Aug. 4, 2014, 4:02 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23863/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2014, 4:02 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-587
> https://issues.apache.org/jira/browse/AURORA-587
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is an exemplar ServerSet Announcer implementation in apache.aurora.executor.common. Open to suggestions about wiring up -- right now it is enabled via command line flags, but we don't have prior art for invoking the executor with command line flags (I think the scheduler just takes -thermos_executor_path, which is fine if we promote the pattern of writing a thin shell wrapper around the executor.pex.) We can alternately switch to entry_points style a la AURORA-216 prior to submitting this, so that people just need to pip install as a plugin, but would require a separate review. Open to ideas.
>
>
> Diffs
> -----
>
> docs/configuration-reference.md 34f2359342958a34532ba9b98b14488efdd07d93
> docs/user-guide.md 6c703a3169491c100540b34761ee57a6caa9edcd
> examples/vagrant/aurorabuild.sh 9f604d36cc083c3679d0c4c8821d74dca64a1805
> examples/vagrant/upstart/aurora-scheduler.conf 05b2f2662311cd4859bfe57df6eee7b431c474eb
> src/main/python/apache/aurora/executor/bin/BUILD 6b3f620a1d1b004c6be9965f6dceb7c8913a8e4c
> src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 198f2f6feb3782a98c3784297599ad218b54209e
> src/main/python/apache/aurora/executor/common/BUILD d0ff6fbf594663cd12ffb4b6d3f330e3a1ac123c
> src/main/python/apache/aurora/executor/common/announcer.py PRE-CREATION
> src/test/python/apache/aurora/client/api/test_scheduler_client.py e1f1a95d1757d584056fe6be9c98049444f6a75b
> src/test/python/apache/aurora/executor/common/BUILD 8b54e910a671cde0265ade3155cb495c6314347b
> src/test/python/apache/aurora/executor/common/test_announcer.py PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora 9dfc65193f655794a92f64631c244fbf890618a8
> src/test/sh/org/apache/aurora/e2e/test_common.sh def823b2f1f4bc67304221efa06e0e561d9bf521
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 3529c184e9ba0c7577baba40e9ad501b02f4c037
> src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh a3f530f26afe7a4472e431c4dfbff175f9b7e53c
> src/test/sh/org/apache/aurora/e2e/validate_serverset.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23863/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/executor/common:announcer -v
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 23863: AURORA-587: Example ServerSet Announcer
implementation
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23863/#review49526
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On Aug. 4, 2014, 11:02 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23863/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2014, 11:02 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-587
> https://issues.apache.org/jira/browse/AURORA-587
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is an exemplar ServerSet Announcer implementation in apache.aurora.executor.common. Open to suggestions about wiring up -- right now it is enabled via command line flags, but we don't have prior art for invoking the executor with command line flags (I think the scheduler just takes -thermos_executor_path, which is fine if we promote the pattern of writing a thin shell wrapper around the executor.pex.) We can alternately switch to entry_points style a la AURORA-216 prior to submitting this, so that people just need to pip install as a plugin, but would require a separate review. Open to ideas.
>
>
> Diffs
> -----
>
> docs/configuration-reference.md 34f2359342958a34532ba9b98b14488efdd07d93
> docs/user-guide.md 6c703a3169491c100540b34761ee57a6caa9edcd
> examples/vagrant/aurorabuild.sh 9f604d36cc083c3679d0c4c8821d74dca64a1805
> examples/vagrant/upstart/aurora-scheduler.conf 05b2f2662311cd4859bfe57df6eee7b431c474eb
> src/main/python/apache/aurora/executor/bin/BUILD 6b3f620a1d1b004c6be9965f6dceb7c8913a8e4c
> src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 198f2f6feb3782a98c3784297599ad218b54209e
> src/main/python/apache/aurora/executor/common/BUILD d0ff6fbf594663cd12ffb4b6d3f330e3a1ac123c
> src/main/python/apache/aurora/executor/common/announcer.py PRE-CREATION
> src/test/python/apache/aurora/client/api/test_scheduler_client.py e1f1a95d1757d584056fe6be9c98049444f6a75b
> src/test/python/apache/aurora/executor/common/BUILD 8b54e910a671cde0265ade3155cb495c6314347b
> src/test/python/apache/aurora/executor/common/test_announcer.py PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora 9dfc65193f655794a92f64631c244fbf890618a8
> src/test/sh/org/apache/aurora/e2e/test_common.sh def823b2f1f4bc67304221efa06e0e561d9bf521
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 3529c184e9ba0c7577baba40e9ad501b02f4c037
> src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh a3f530f26afe7a4472e431c4dfbff175f9b7e53c
> src/test/sh/org/apache/aurora/e2e/validate_serverset.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23863/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/executor/common:announcer -v
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 23863: AURORA-587: Example ServerSet Announcer
implementation
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23863/
-----------------------------------------------------------
(Updated Aug. 5, 2014, 8:02 p.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Changes
-------
Fix merge conflict prior to submit.
Bugs: AURORA-587
https://issues.apache.org/jira/browse/AURORA-587
Repository: aurora
Description
-------
This is an exemplar ServerSet Announcer implementation in apache.aurora.executor.common. Open to suggestions about wiring up -- right now it is enabled via command line flags, but we don't have prior art for invoking the executor with command line flags (I think the scheduler just takes -thermos_executor_path, which is fine if we promote the pattern of writing a thin shell wrapper around the executor.pex.) We can alternately switch to entry_points style a la AURORA-216 prior to submitting this, so that people just need to pip install as a plugin, but would require a separate review. Open to ideas.
Diffs (updated)
-----
docs/configuration-reference.md 34f2359342958a34532ba9b98b14488efdd07d93
docs/user-guide.md 6c703a3169491c100540b34761ee57a6caa9edcd
examples/vagrant/aurorabuild.sh 9f604d36cc083c3679d0c4c8821d74dca64a1805
examples/vagrant/upstart/aurora-scheduler.conf 05b2f2662311cd4859bfe57df6eee7b431c474eb
src/main/python/apache/aurora/executor/bin/BUILD 6b3f620a1d1b004c6be9965f6dceb7c8913a8e4c
src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 198f2f6feb3782a98c3784297599ad218b54209e
src/main/python/apache/aurora/executor/common/BUILD d0ff6fbf594663cd12ffb4b6d3f330e3a1ac123c
src/main/python/apache/aurora/executor/common/announcer.py PRE-CREATION
src/test/python/apache/aurora/client/api/test_scheduler_client.py ab74db34d61e72c50d4ac9252b02cbf69377d194
src/test/python/apache/aurora/executor/common/BUILD 8b54e910a671cde0265ade3155cb495c6314347b
src/test/python/apache/aurora/executor/common/test_announcer.py PRE-CREATION
src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora 9dfc65193f655794a92f64631c244fbf890618a8
src/test/sh/org/apache/aurora/e2e/test_common.sh def823b2f1f4bc67304221efa06e0e561d9bf521
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 3529c184e9ba0c7577baba40e9ad501b02f4c037
src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh a3f530f26afe7a4472e431c4dfbff175f9b7e53c
src/test/sh/org/apache/aurora/e2e/validate_serverset.py PRE-CREATION
Diff: https://reviews.apache.org/r/23863/diff/
Testing
-------
./pants src/test/python/apache/aurora/executor/common:announcer -v
Thanks,
Brian Wickman
Re: Review Request 23863: AURORA-587: Example ServerSet Announcer
implementation
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23863/#review49553
-----------------------------------------------------------
Ship it!
Ship It!
- Joe Smith
On Aug. 4, 2014, 4:02 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23863/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2014, 4:02 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-587
> https://issues.apache.org/jira/browse/AURORA-587
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is an exemplar ServerSet Announcer implementation in apache.aurora.executor.common. Open to suggestions about wiring up -- right now it is enabled via command line flags, but we don't have prior art for invoking the executor with command line flags (I think the scheduler just takes -thermos_executor_path, which is fine if we promote the pattern of writing a thin shell wrapper around the executor.pex.) We can alternately switch to entry_points style a la AURORA-216 prior to submitting this, so that people just need to pip install as a plugin, but would require a separate review. Open to ideas.
>
>
> Diffs
> -----
>
> docs/configuration-reference.md 34f2359342958a34532ba9b98b14488efdd07d93
> docs/user-guide.md 6c703a3169491c100540b34761ee57a6caa9edcd
> examples/vagrant/aurorabuild.sh 9f604d36cc083c3679d0c4c8821d74dca64a1805
> examples/vagrant/upstart/aurora-scheduler.conf 05b2f2662311cd4859bfe57df6eee7b431c474eb
> src/main/python/apache/aurora/executor/bin/BUILD 6b3f620a1d1b004c6be9965f6dceb7c8913a8e4c
> src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 198f2f6feb3782a98c3784297599ad218b54209e
> src/main/python/apache/aurora/executor/common/BUILD d0ff6fbf594663cd12ffb4b6d3f330e3a1ac123c
> src/main/python/apache/aurora/executor/common/announcer.py PRE-CREATION
> src/test/python/apache/aurora/client/api/test_scheduler_client.py e1f1a95d1757d584056fe6be9c98049444f6a75b
> src/test/python/apache/aurora/executor/common/BUILD 8b54e910a671cde0265ade3155cb495c6314347b
> src/test/python/apache/aurora/executor/common/test_announcer.py PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora 9dfc65193f655794a92f64631c244fbf890618a8
> src/test/sh/org/apache/aurora/e2e/test_common.sh def823b2f1f4bc67304221efa06e0e561d9bf521
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 3529c184e9ba0c7577baba40e9ad501b02f4c037
> src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh a3f530f26afe7a4472e431c4dfbff175f9b7e53c
> src/test/sh/org/apache/aurora/e2e/validate_serverset.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23863/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/executor/common:announcer -v
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 23863: AURORA-587: Example ServerSet Announcer
implementation
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23863/
-----------------------------------------------------------
(Updated Aug. 4, 2014, 11:02 p.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Changes
-------
Fix truncated comment.
Bugs: AURORA-587
https://issues.apache.org/jira/browse/AURORA-587
Repository: aurora
Description
-------
This is an exemplar ServerSet Announcer implementation in apache.aurora.executor.common. Open to suggestions about wiring up -- right now it is enabled via command line flags, but we don't have prior art for invoking the executor with command line flags (I think the scheduler just takes -thermos_executor_path, which is fine if we promote the pattern of writing a thin shell wrapper around the executor.pex.) We can alternately switch to entry_points style a la AURORA-216 prior to submitting this, so that people just need to pip install as a plugin, but would require a separate review. Open to ideas.
Diffs (updated)
-----
docs/configuration-reference.md 34f2359342958a34532ba9b98b14488efdd07d93
docs/user-guide.md 6c703a3169491c100540b34761ee57a6caa9edcd
examples/vagrant/aurorabuild.sh 9f604d36cc083c3679d0c4c8821d74dca64a1805
examples/vagrant/upstart/aurora-scheduler.conf 05b2f2662311cd4859bfe57df6eee7b431c474eb
src/main/python/apache/aurora/executor/bin/BUILD 6b3f620a1d1b004c6be9965f6dceb7c8913a8e4c
src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 198f2f6feb3782a98c3784297599ad218b54209e
src/main/python/apache/aurora/executor/common/BUILD d0ff6fbf594663cd12ffb4b6d3f330e3a1ac123c
src/main/python/apache/aurora/executor/common/announcer.py PRE-CREATION
src/test/python/apache/aurora/client/api/test_scheduler_client.py e1f1a95d1757d584056fe6be9c98049444f6a75b
src/test/python/apache/aurora/executor/common/BUILD 8b54e910a671cde0265ade3155cb495c6314347b
src/test/python/apache/aurora/executor/common/test_announcer.py PRE-CREATION
src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora 9dfc65193f655794a92f64631c244fbf890618a8
src/test/sh/org/apache/aurora/e2e/test_common.sh def823b2f1f4bc67304221efa06e0e561d9bf521
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 3529c184e9ba0c7577baba40e9ad501b02f4c037
src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh a3f530f26afe7a4472e431c4dfbff175f9b7e53c
src/test/sh/org/apache/aurora/e2e/validate_serverset.py PRE-CREATION
Diff: https://reviews.apache.org/r/23863/diff/
Testing
-------
./pants src/test/python/apache/aurora/executor/common:announcer -v
Thanks,
Brian Wickman
Re: Review Request 23863: AURORA-587: Example ServerSet Announcer
implementation
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23863/
-----------------------------------------------------------
(Updated Aug. 4, 2014, 11:01 p.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Changes
-------
Add docs.
Bugs: AURORA-587
https://issues.apache.org/jira/browse/AURORA-587
Repository: aurora
Description
-------
This is an exemplar ServerSet Announcer implementation in apache.aurora.executor.common. Open to suggestions about wiring up -- right now it is enabled via command line flags, but we don't have prior art for invoking the executor with command line flags (I think the scheduler just takes -thermos_executor_path, which is fine if we promote the pattern of writing a thin shell wrapper around the executor.pex.) We can alternately switch to entry_points style a la AURORA-216 prior to submitting this, so that people just need to pip install as a plugin, but would require a separate review. Open to ideas.
Diffs (updated)
-----
docs/configuration-reference.md 34f2359342958a34532ba9b98b14488efdd07d93
docs/user-guide.md 6c703a3169491c100540b34761ee57a6caa9edcd
examples/vagrant/aurorabuild.sh 9f604d36cc083c3679d0c4c8821d74dca64a1805
examples/vagrant/upstart/aurora-scheduler.conf 05b2f2662311cd4859bfe57df6eee7b431c474eb
src/main/python/apache/aurora/executor/bin/BUILD 6b3f620a1d1b004c6be9965f6dceb7c8913a8e4c
src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 198f2f6feb3782a98c3784297599ad218b54209e
src/main/python/apache/aurora/executor/common/BUILD d0ff6fbf594663cd12ffb4b6d3f330e3a1ac123c
src/main/python/apache/aurora/executor/common/announcer.py PRE-CREATION
src/test/python/apache/aurora/client/api/test_scheduler_client.py e1f1a95d1757d584056fe6be9c98049444f6a75b
src/test/python/apache/aurora/executor/common/BUILD 8b54e910a671cde0265ade3155cb495c6314347b
src/test/python/apache/aurora/executor/common/test_announcer.py PRE-CREATION
src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora 9dfc65193f655794a92f64631c244fbf890618a8
src/test/sh/org/apache/aurora/e2e/test_common.sh def823b2f1f4bc67304221efa06e0e561d9bf521
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 3529c184e9ba0c7577baba40e9ad501b02f4c037
src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh a3f530f26afe7a4472e431c4dfbff175f9b7e53c
src/test/sh/org/apache/aurora/e2e/validate_serverset.py PRE-CREATION
Diff: https://reviews.apache.org/r/23863/diff/
Testing
-------
./pants src/test/python/apache/aurora/executor/common:announcer -v
Thanks,
Brian Wickman
Re: Review Request 23863: AURORA-587: Example ServerSet Announcer
implementation
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23863/
-----------------------------------------------------------
(Updated Aug. 4, 2014, 9:14 p.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Changes
-------
Split validate_serverset into a separate python file.
Update to check for 4 znodes since the updated example aurora file now has 4 instances.
Bugs: AURORA-587
https://issues.apache.org/jira/browse/AURORA-587
Repository: aurora
Description
-------
This is an exemplar ServerSet Announcer implementation in apache.aurora.executor.common. Open to suggestions about wiring up -- right now it is enabled via command line flags, but we don't have prior art for invoking the executor with command line flags (I think the scheduler just takes -thermos_executor_path, which is fine if we promote the pattern of writing a thin shell wrapper around the executor.pex.) We can alternately switch to entry_points style a la AURORA-216 prior to submitting this, so that people just need to pip install as a plugin, but would require a separate review. Open to ideas.
Diffs (updated)
-----
examples/vagrant/aurorabuild.sh 9f604d36cc083c3679d0c4c8821d74dca64a1805
examples/vagrant/upstart/aurora-scheduler.conf 05b2f2662311cd4859bfe57df6eee7b431c474eb
src/main/python/apache/aurora/executor/bin/BUILD 6b3f620a1d1b004c6be9965f6dceb7c8913a8e4c
src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 198f2f6feb3782a98c3784297599ad218b54209e
src/main/python/apache/aurora/executor/common/BUILD d0ff6fbf594663cd12ffb4b6d3f330e3a1ac123c
src/main/python/apache/aurora/executor/common/announcer.py PRE-CREATION
src/test/python/apache/aurora/client/api/test_scheduler_client.py e1f1a95d1757d584056fe6be9c98049444f6a75b
src/test/python/apache/aurora/executor/common/BUILD 8b54e910a671cde0265ade3155cb495c6314347b
src/test/python/apache/aurora/executor/common/test_announcer.py PRE-CREATION
src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora 9dfc65193f655794a92f64631c244fbf890618a8
src/test/sh/org/apache/aurora/e2e/test_common.sh def823b2f1f4bc67304221efa06e0e561d9bf521
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 3529c184e9ba0c7577baba40e9ad501b02f4c037
src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh a3f530f26afe7a4472e431c4dfbff175f9b7e53c
src/test/sh/org/apache/aurora/e2e/validate_serverset.py PRE-CREATION
Diff: https://reviews.apache.org/r/23863/diff/
Testing
-------
./pants src/test/python/apache/aurora/executor/common:announcer -v
Thanks,
Brian Wickman
Re: Review Request 23863: AURORA-587: Example ServerSet Announcer
implementation
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23863/#review48767
-----------------------------------------------------------
src/test/sh/org/apache/aurora/e2e/test_common.sh
<https://reviews.apache.org/r/23863/#comment85508>
Better yet, just put a .py file in the repo and reference it from /vagrant/...
- Bill Farner
On July 24, 2014, 10:32 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23863/
> -----------------------------------------------------------
>
> (Updated July 24, 2014, 10:32 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-587
> https://issues.apache.org/jira/browse/AURORA-587
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is an exemplar ServerSet Announcer implementation in apache.aurora.executor.common. Open to suggestions about wiring up -- right now it is enabled via command line flags, but we don't have prior art for invoking the executor with command line flags (I think the scheduler just takes -thermos_executor_path, which is fine if we promote the pattern of writing a thin shell wrapper around the executor.pex.) We can alternately switch to entry_points style a la AURORA-216 prior to submitting this, so that people just need to pip install as a plugin, but would require a separate review. Open to ideas.
>
>
> Diffs
> -----
>
> examples/vagrant/aurorabuild.sh 9f604d36cc083c3679d0c4c8821d74dca64a1805
> examples/vagrant/upstart/aurora-scheduler.conf 05b2f2662311cd4859bfe57df6eee7b431c474eb
> src/main/python/apache/aurora/executor/bin/BUILD 6b3f620a1d1b004c6be9965f6dceb7c8913a8e4c
> src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 198f2f6feb3782a98c3784297599ad218b54209e
> src/main/python/apache/aurora/executor/common/BUILD d0ff6fbf594663cd12ffb4b6d3f330e3a1ac123c
> src/main/python/apache/aurora/executor/common/announcer.py PRE-CREATION
> src/test/python/apache/aurora/executor/common/BUILD 8b54e910a671cde0265ade3155cb495c6314347b
> src/test/python/apache/aurora/executor/common/test_announcer.py PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora dcf61033743317a51dd2f77e8d254c4781cb6a93
> src/test/sh/org/apache/aurora/e2e/test_common.sh def823b2f1f4bc67304221efa06e0e561d9bf521
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 9c5652829ac306dda5f7e95e164c85713e18988f
> src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 2af256d65850bd861111279dff4b5c53f234cf7a
>
> Diff: https://reviews.apache.org/r/23863/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/executor/common:announcer -v
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 23863: AURORA-587: Example ServerSet Announcer
implementation
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23863/
-----------------------------------------------------------
(Updated July 24, 2014, 10:32 p.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Changes
-------
Address kevin's comments.
Bugs: AURORA-587
https://issues.apache.org/jira/browse/AURORA-587
Repository: aurora
Description
-------
This is an exemplar ServerSet Announcer implementation in apache.aurora.executor.common. Open to suggestions about wiring up -- right now it is enabled via command line flags, but we don't have prior art for invoking the executor with command line flags (I think the scheduler just takes -thermos_executor_path, which is fine if we promote the pattern of writing a thin shell wrapper around the executor.pex.) We can alternately switch to entry_points style a la AURORA-216 prior to submitting this, so that people just need to pip install as a plugin, but would require a separate review. Open to ideas.
Diffs (updated)
-----
examples/vagrant/aurorabuild.sh 9f604d36cc083c3679d0c4c8821d74dca64a1805
examples/vagrant/upstart/aurora-scheduler.conf 05b2f2662311cd4859bfe57df6eee7b431c474eb
src/main/python/apache/aurora/executor/bin/BUILD 6b3f620a1d1b004c6be9965f6dceb7c8913a8e4c
src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 198f2f6feb3782a98c3784297599ad218b54209e
src/main/python/apache/aurora/executor/common/BUILD d0ff6fbf594663cd12ffb4b6d3f330e3a1ac123c
src/main/python/apache/aurora/executor/common/announcer.py PRE-CREATION
src/test/python/apache/aurora/executor/common/BUILD 8b54e910a671cde0265ade3155cb495c6314347b
src/test/python/apache/aurora/executor/common/test_announcer.py PRE-CREATION
src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora dcf61033743317a51dd2f77e8d254c4781cb6a93
src/test/sh/org/apache/aurora/e2e/test_common.sh def823b2f1f4bc67304221efa06e0e561d9bf521
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 9c5652829ac306dda5f7e95e164c85713e18988f
src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 2af256d65850bd861111279dff4b5c53f234cf7a
Diff: https://reviews.apache.org/r/23863/diff/
Testing
-------
./pants src/test/python/apache/aurora/executor/common:announcer -v
Thanks,
Brian Wickman
Re: Review Request 23863: AURORA-587: Example ServerSet Announcer
implementation
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23863/#review48684
-----------------------------------------------------------
Ship it!
src/test/sh/org/apache/aurora/e2e/test_common.sh
<https://reviews.apache.org/r/23863/#comment85430>
local
src/test/sh/org/apache/aurora/e2e/test_common.sh
<https://reviews.apache.org/r/23863/#comment85429>
No need for cat here - can use vagrant... <<EOF
- Kevin Sweeney
On July 24, 2014, 2:43 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23863/
> -----------------------------------------------------------
>
> (Updated July 24, 2014, 2:43 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-587
> https://issues.apache.org/jira/browse/AURORA-587
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is an exemplar ServerSet Announcer implementation in apache.aurora.executor.common. Open to suggestions about wiring up -- right now it is enabled via command line flags, but we don't have prior art for invoking the executor with command line flags (I think the scheduler just takes -thermos_executor_path, which is fine if we promote the pattern of writing a thin shell wrapper around the executor.pex.) We can alternately switch to entry_points style a la AURORA-216 prior to submitting this, so that people just need to pip install as a plugin, but would require a separate review. Open to ideas.
>
>
> Diffs
> -----
>
> examples/vagrant/aurorabuild.sh 9f604d36cc083c3679d0c4c8821d74dca64a1805
> examples/vagrant/upstart/aurora-scheduler.conf 05b2f2662311cd4859bfe57df6eee7b431c474eb
> src/main/python/apache/aurora/executor/bin/BUILD 6b3f620a1d1b004c6be9965f6dceb7c8913a8e4c
> src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 198f2f6feb3782a98c3784297599ad218b54209e
> src/main/python/apache/aurora/executor/common/BUILD d0ff6fbf594663cd12ffb4b6d3f330e3a1ac123c
> src/main/python/apache/aurora/executor/common/announcer.py PRE-CREATION
> src/test/python/apache/aurora/executor/common/BUILD 8b54e910a671cde0265ade3155cb495c6314347b
> src/test/python/apache/aurora/executor/common/test_announcer.py PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora dcf61033743317a51dd2f77e8d254c4781cb6a93
> src/test/sh/org/apache/aurora/e2e/test_common.sh def823b2f1f4bc67304221efa06e0e561d9bf521
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 9c5652829ac306dda5f7e95e164c85713e18988f
> src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 2af256d65850bd861111279dff4b5c53f234cf7a
>
> Diff: https://reviews.apache.org/r/23863/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python/apache/aurora/executor/common:announcer -v
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 23863: AURORA-587: Example ServerSet Announcer
implementation
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23863/
-----------------------------------------------------------
(Updated July 24, 2014, 9:43 p.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Changes
-------
Last update, promise.
Adds clauses to test for announcing / expiring in the end-to-end test.
Adds LICENSE headers to announcer files.
Bugs: AURORA-587
https://issues.apache.org/jira/browse/AURORA-587
Repository: aurora
Description
-------
This is an exemplar ServerSet Announcer implementation in apache.aurora.executor.common. Open to suggestions about wiring up -- right now it is enabled via command line flags, but we don't have prior art for invoking the executor with command line flags (I think the scheduler just takes -thermos_executor_path, which is fine if we promote the pattern of writing a thin shell wrapper around the executor.pex.) We can alternately switch to entry_points style a la AURORA-216 prior to submitting this, so that people just need to pip install as a plugin, but would require a separate review. Open to ideas.
Diffs (updated)
-----
examples/vagrant/aurorabuild.sh 9f604d36cc083c3679d0c4c8821d74dca64a1805
examples/vagrant/upstart/aurora-scheduler.conf 05b2f2662311cd4859bfe57df6eee7b431c474eb
src/main/python/apache/aurora/executor/bin/BUILD 6b3f620a1d1b004c6be9965f6dceb7c8913a8e4c
src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 198f2f6feb3782a98c3784297599ad218b54209e
src/main/python/apache/aurora/executor/common/BUILD d0ff6fbf594663cd12ffb4b6d3f330e3a1ac123c
src/main/python/apache/aurora/executor/common/announcer.py PRE-CREATION
src/test/python/apache/aurora/executor/common/BUILD 8b54e910a671cde0265ade3155cb495c6314347b
src/test/python/apache/aurora/executor/common/test_announcer.py PRE-CREATION
src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora dcf61033743317a51dd2f77e8d254c4781cb6a93
src/test/sh/org/apache/aurora/e2e/test_common.sh def823b2f1f4bc67304221efa06e0e561d9bf521
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 9c5652829ac306dda5f7e95e164c85713e18988f
src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 2af256d65850bd861111279dff4b5c53f234cf7a
Diff: https://reviews.apache.org/r/23863/diff/
Testing
-------
./pants src/test/python/apache/aurora/executor/common:announcer -v
Thanks,
Brian Wickman
Re: Review Request 23863: AURORA-587: Example ServerSet Announcer
implementation
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23863/
-----------------------------------------------------------
(Updated July 24, 2014, 2:36 a.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Changes
-------
Enable the Announcer in the end-to-end test. TODO: Add check in the test to validate that the instances are being registered correctly (verified this manually on my laptop.)
I reworked the Announcer slightly to be more flexible with how the serverset is constructed and use a vanilla KazooClient rather than the TwitterKazooClient. This should make it easier for users to derive their own bespoke announcers (e.g. with credentials/acls.)
Bugs: AURORA-587
https://issues.apache.org/jira/browse/AURORA-587
Repository: aurora
Description
-------
This is an exemplar ServerSet Announcer implementation in apache.aurora.executor.common. Open to suggestions about wiring up -- right now it is enabled via command line flags, but we don't have prior art for invoking the executor with command line flags (I think the scheduler just takes -thermos_executor_path, which is fine if we promote the pattern of writing a thin shell wrapper around the executor.pex.) We can alternately switch to entry_points style a la AURORA-216 prior to submitting this, so that people just need to pip install as a plugin, but would require a separate review. Open to ideas.
Diffs (updated)
-----
examples/vagrant/aurorabuild.sh 9f604d36cc083c3679d0c4c8821d74dca64a1805
examples/vagrant/upstart/aurora-scheduler.conf 05b2f2662311cd4859bfe57df6eee7b431c474eb
src/main/python/apache/aurora/executor/bin/BUILD 6b3f620a1d1b004c6be9965f6dceb7c8913a8e4c
src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 198f2f6feb3782a98c3784297599ad218b54209e
src/main/python/apache/aurora/executor/common/BUILD d0ff6fbf594663cd12ffb4b6d3f330e3a1ac123c
src/main/python/apache/aurora/executor/common/announcer.py PRE-CREATION
src/test/python/apache/aurora/executor/common/BUILD 8b54e910a671cde0265ade3155cb495c6314347b
src/test/python/apache/aurora/executor/common/test_announcer.py PRE-CREATION
src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora dcf61033743317a51dd2f77e8d254c4781cb6a93
Diff: https://reviews.apache.org/r/23863/diff/
Testing
-------
./pants src/test/python/apache/aurora/executor/common:announcer -v
Thanks,
Brian Wickman